Received-SPF: pass (google.com: domain of linux-kernel+bounces-23898-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Jan 2024 12:54:35 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>, joro@8bytes.org,
	alex.williamson@redhat.com, kevin.tian@intel.com,
	robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
	eric.auger@redhat.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com,
	chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
	peterx@redhat.com, jasowang@redhat.com,
	shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
	suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	zhenzhong.duan@intel.com, joao.m.martins@oracle.com,
	xin.zeng@intel.com, yan.y.zhao@intel.com, j.granados@samsung.com,
	binbin.wu@linux.intel.com
Subject: Re: [PATCH v11 6/8] iommufd/selftest: Add coverage for
 IOMMU_HWPT_INVALIDATE ioctl
Message-ID: <20240111165435.GJ439767@nvidia.com>
References: <20240111041015.47920-1-yi.l.liu@intel.com>
 <20240111041015.47920-7-yi.l.liu@intel.com>
 <ZaAcZXrhhQPhKTHq@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZaAcZXrhhQPhKTHq@Asurada-Nvidia>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Fs+KeC0TqfyvQdlSdSHN/hkj/CAhdjZ1ovUmujsdOJEmP1TSBGds36b/4Mz/?=
 =?us-ascii?Q?amN/5HYLYFL5IjsdZcr4XiaNBmsCDv4CbEsxLFMP0RGFUS0uI5RCQ6Jec7oO?=
 =?us-ascii?Q?+O2XUPZ1JKtkKTzDlL4L/FWzieeaG0DfJBsYd0WGZyWAzdgcN5ABFBqY/PAa?=
 =?us-ascii?Q?cK9fLzQOh63rs3ZO7PKz2e7xJs9m+NnlprrlyBazqUNeyflQDTnuhPdUzNMG?=
 =?us-ascii?Q?Vb7v/Xv7spw9fC+6HUWBJxYcZa+/+0QwRKvew4T8e6rVFXfREgJQjM+jCky9?=
 =?us-ascii?Q?PJeSi1Y9CDExp47APJte6SRM9UVcfxEzjPwBbiQ+9tcSur+fllVlJEpEywtk?=
 =?us-ascii?Q?99HPKw/OTuPD0KJ17uZAXiLec1DFQ8N8l9nwdHKq+b4EXP8VQl9BFfjyk/vG?=
 =?us-ascii?Q?2FDDhjVA9AFdBvuRY4ONcFufbnU9fwtxu6OTmf6kQiik1MDHQuaFbAJ8sIc8?=
 =?us-ascii?Q?59hknUp1Z9bG5Vu7BHuITzkPVN7QZMNd5SoERtwhB+5HtZ7Aupf2Xc72JDZS?=
 =?us-ascii?Q?0hfzHILX8XNbI4WqJu/IiALQHRybZMMkf8IGtE44Cb4/hNyklH/krnX5B7t7?=
 =?us-ascii?Q?1w/cXIQ2QMVclazNPkzZP0Me/ZFLpbA8u38UQdHIG+dJFe4qXjZ1zn0x6zs8?=
 =?us-ascii?Q?L1D3EcAxNiD2JEuCBHtJi+MQNwsZYq2aAyYAyW+Ne9veolAKCZ5TROKs0meW?=
 =?us-ascii?Q?ZX1V33bYDAS1vxHsUL0wjjw/T9sP82tv82lcpo4HwOk2Z54XLXtuEpVvR97I?=
 =?us-ascii?Q?mRZEzy9blY/hLs4GrOiLxquEoT2BuuorDlfGta0KmyiIPjUjDI1cTc/MoH4y?=
 =?us-ascii?Q?+7K+Tk3ct4blaee4uEv/Gq9dzQLFoJJhJrHEsRTR6En7KvNFca0qVNoy/TkP?=
 =?us-ascii?Q?7OjMH16z28w02iubHUik25/PblwDRBftdZYh0mpUG6rJJsgJx3cwNW0xKZf3?=
 =?us-ascii?Q?4/miNFThgJ/zHEcPfPu1jmTbqdM3DmrNCjlXP3d+hdLwjwh28/lMH8t8yZWg?=
 =?us-ascii?Q?PFFhCd8pteoDC2GuRE0YCTaMAwXbNvfTutsKg1Stq4E297nPBM7BnplyIG+2?=
 =?us-ascii?Q?IG5icnVjGUGw18DPyk7wum8dYRmFOSVgpMqNrNrlHcCgjdVB3ziOxRdTJeOO?=
 =?us-ascii?Q?URvQ0CybPFM3q1hWzclL0fMxygwjR3PLsWBQVZAlTmAn2hcq3fb36AAfwad+?=
 =?us-ascii?Q?72OIaoGY48nQB1xUyhh7vpUMPprUAmiC00B5C4wh9w0cd43aESPCjm2OzY/M?=
 =?us-ascii?Q?nKFIHvGbLchgPc+zHEytePZvlT8fYeXutslxOmYtfK/HQ7I03LXwK45rDE9I?=
 =?us-ascii?Q?QvRONXrx3RUu1e/hz+g5b51gJZTiWKNxNhZw38c4wJV9nNLA43Snldbf4MaX?=
 =?us-ascii?Q?96tngxwoB/Lv0iAdaxdrCJHgJ1Uj3g7lZPsXyfaEKt4nqVgCnkGKWKUlM6kr?=
 =?us-ascii?Q?P/+yLv0raOb4tM4Fck+NrOQowHHSOIvuXi9iQqS8bLHa2vs0PW1eE78JvuQE?=
 =?us-ascii?Q?VtfXW2J+p8w3x+8DmeDuV5inSAqhUZGHE4RKX4AOdakg4XeZVUbOxhY4L/Ji?=
 =?us-ascii?Q?kK+/gbWawXMMY0AvheA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd2dcb73-c96a-4adf-f4b2-08dc12c5fec9
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 16:54:37.4176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QTBuqqsfpQZG+tFfDjKZ0xlgLedJheUZhHXL6/hYdXoZGJvC+gtefARAWuoOoS0b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5775

On Thu, Jan 11, 2024 at 08:50:45AM -0800, Nicolin Chen wrote:
> On Wed, Jan 10, 2024 at 08:10:13PM -0800, Yi Liu wrote:
> > +#define test_cmd_hwpt_invalidate(hwpt_id, reqs, data_type, lreq, nreqs)        \
> > +       ({                                                                    \
> > +               ASSERT_EQ(0,                                                  \
> > +                         _test_cmd_hwpt_invalidate(self->fd, hwpt_id, reqs,  \
> > +                                                   data_type,                 \
> > +                                                   lreq, nreqs));            \
> > +       })
> > +#define test_err_hwpt_invalidate(_errno, hwpt_id, reqs, data_type, lreq,    \
> > +                                nreqs)                                    \
> > +       ({                                                                 \
> > +               EXPECT_ERRNO(_errno,                                       \
> > +                            _test_cmd_hwpt_invalidate(self->fd, hwpt_id,  \
> > +                                                      reqs, data_type,     \
> > +                                                      lreq, nreqs));      \
> > +       })
> 
> Nit: spaces at the end of the four lines above that have string
> "data_type" are all misaligned, probably because of the previous
> replacement of "req_type".

I will fix it

Jason