Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1775676rdd; Thu, 11 Jan 2024 08:56:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLNmXxu4mEzBBRJLPl6PMwAf7Gd2uw5P/TzqDmWyYcWyNIQPTSqb8jzBRegfCsvw8VtxlO X-Received: by 2002:a17:906:e2cb:b0:a2c:535a:7c00 with SMTP id gr11-20020a170906e2cb00b00a2c535a7c00mr410483ejb.195.1704992205813; Thu, 11 Jan 2024 08:56:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704992205; cv=none; d=google.com; s=arc-20160816; b=a8hese/cm+CjZov5uUV+W494n+PTASPhlL/TC8vxGWrtPMVlBlMprT7DpSYywiHMbR hOdhDJ0r1nAj4cDzXxKx9WIMgFAme0MyNw4aj65dHxqiJtZSAGll07Rfk6/oBzheLLVF 6c9Zm+pOjc2c0pO707kmeDWg42lrd4UIPqs/2+T1A+7/S+oKA0OM6siy/9nFbuQz+5ne /p1Jvf0LPomvLPbwlNtK1Uf5CAWIkP1gr6ttupF5FKDnnNrSe59Cn4pgwGikQQwZtXt+ pD5L0F0mPMk7JKbgT8HNfZwzA4cQQfWZSDlrygjdYs88UMv91ei+C51722JD0ZDSV4c1 qM9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4nAUSt6yFq4qLCYsE347w2X/tEMdQNOumHIBIo0CZe4=; fh=88L52uWwEU86l5tXYL90G7IBrpSUbAcE3zg5Ay8HK0Y=; b=JYmu/DoID+jjYzDvUukt5hkdlAnw1keQTbSL5I027eBUDqX+z1H08njyOND3hPY5tH DPv81Nu433ul7XyorjZQSDW9BvJzUM6anSl1b05VWFs046jPd2onLIlV4CorA9FJt/+g PqTGbkvpwM8Qy+hkYjBQYqYjKeHlcNppRq6lVnFe8CJ2yIDaBXTVNxB2DcdzIqrpEJmY Xghnz9MR9MBk0itLezLbMxK66UISk2PSIA9CDxcskl02GxdR5UqpnVIcZBJko3pDWG0P SQ4edRlOS/b/IheuibP40k02VIewMyyJo55+WnPq5BlmCrwnQSYeeRQ2juDBWRfoI2vq HFLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=1EcrgGZ5; spf=pass (google.com: domain of linux-kernel+bounces-23889-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23889-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id q5-20020a170906a08500b00a23619be213si654927ejy.159.2024.01.11.08.56.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:56:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23889-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=1EcrgGZ5; spf=pass (google.com: domain of linux-kernel+bounces-23889-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23889-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 06B9C1F29542 for ; Thu, 11 Jan 2024 16:46:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59CEA51000; Thu, 11 Jan 2024 16:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1EcrgGZ5" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42ACA487BF; Thu, 11 Jan 2024 16:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4nAUSt6yFq4qLCYsE347w2X/tEMdQNOumHIBIo0CZe4=; b=1EcrgGZ51fFPyiy7XX0/qgvruN 4Dray1N7UtvxeG7hOiLQ2ziZe2a57eeK7ZGzKSw/c4nKyulEyOQijozOkrF80Cl/aV2bZfDvZzDOb P8g4fYXBw4Ek7xb4k8ra6FxGTXlalknbhgvggXbYsGPA07JNMie6H8uysQGYlC08xaaU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rNyBb-0050yR-9I; Thu, 11 Jan 2024 17:45:43 +0100 Date: Thu, 11 Jan 2024 17:45:43 +0100 From: Andrew Lunn To: Catalin Popescu Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, afd@ti.com, hkallweit1@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: phy: dp83826: add support for voltage tuning of logical levels Message-ID: <0323cb84-14fe-422b-9423-3b1599f8452b@lunn.ch> References: <20240111161927.3689084-1-catalin.popescu@leica-geosystems.com> <20240111161927.3689084-3-catalin.popescu@leica-geosystems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111161927.3689084-3-catalin.popescu@leica-geosystems.com> > +u8 dp83826_cfg_dac_minus_raw[DP83826_CFG_DAC_RAW_VALUES_MAX] = {0x38, 0x37, 0x36, 0x35, 0x34, 0x33, > + 0x32, 0x31, 0x30, 0x2f, 0x2e, 0x2d, > + 0x2c, 0x2b, 0x2a, 0x29, 0x28}; > +u8 dp83826_cfg_dac_plus_raw[DP83826_CFG_DAC_RAW_VALUES_MAX] = {0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, > + 0x0e, 0x0f, 0x10, 0x11, 0x12, 0x13, > + 0x14, 0x15, 0x16, 0x17, 0x18}; Both of these should be static const. However, they appear pointless. Plus is just a shift. minus is some simple arithmetic and a shift. Andrew