Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759286AbXLMOTy (ORCPT ); Thu, 13 Dec 2007 09:19:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754603AbXLMOTk (ORCPT ); Thu, 13 Dec 2007 09:19:40 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42672 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754580AbXLMOTj (ORCPT ); Thu, 13 Dec 2007 09:19:39 -0500 Date: Thu, 13 Dec 2007 06:19:38 -0800 (PST) Message-Id: <20071213.061938.86541759.davem@davemloft.net> To: gallatin@myri.com Cc: joonwpark81@gmail.com, auke-jan.h.kok@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jgarzik@pobox.com, shemminger@linux-foundation.org, jesse.brandeburg@intel.com Subject: Re: [RFC] net: napi fix From: David Miller In-Reply-To: <47613E22.6060705@myri.com> References: <47602B77.2090202@intel.com> <47613E22.6060705@myri.com> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 15 From: Andrew Gallatin Date: Thu, 13 Dec 2007 09:13:54 -0500 > If the netif_running() check is indeed required to make a device break > out of napi polling and respond to an ifconfig down, then I think the > netif_running() check should be moved up into net_rx_action() to avoid > potential for driver complexity and bugs like the ones you found. That, or something like it, definitely sounds reasonable and much better than putting the check into every driver :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/