Received-SPF: pass (google.com: domain of linux-kernel+bounces-23963-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1a1f9b11-5a6d-41f7-8bcd-533a61a27a65@quicinc.com>
Date: Thu, 11 Jan 2024 23:39:36 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 3/5] iommu/arm-smmu: introduction of ACTLR for custom
 prefetcher settings
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Pavan Kondeti
	<quic_pkondeti@quicinc.com>
CC: <will@kernel.org>, <robin.murphy@arm.com>, <joro@8bytes.org>,
        <dmitry.baryshkov@linaro.org>, <jsnitsel@redhat.com>,
        <quic_bjorande@quicinc.com>, <mani@kernel.org>,
        <quic_eberman@quicinc.com>, <robdclark@chromium.org>,
        <u.kleine-koenig@pengutronix.de>, <robh@kernel.org>,
        <vladimir.oltean@nxp.com>, <quic_molvera@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20240109114220.30243-1-quic_bibekkum@quicinc.com>
 <20240109114220.30243-4-quic_bibekkum@quicinc.com>
 <2ad70157-27d1-41df-8866-c226af690cf6@quicinc.com>
 <ec31fafa-b912-454a-8b64-e0593911aaf2@quicinc.com>
 <4a595815-7fcc-47e2-b22c-dac349af6d79@quicinc.com>
 <492aeca3-a4df-47a3-9c77-02ea4235d736@linaro.org>
From: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
In-Reply-To: <492aeca3-a4df-47a3-9c77-02ea4235d736@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 1/10/2024 11:26 PM, Konrad Dybcio wrote:
> 
> 
> On 1/10/24 13:55, Bibek Kumar Patro wrote:
>>
>>
>> On 1/10/2024 4:46 PM, Bibek Kumar Patro wrote:
>>>
>>>
>>> On 1/10/2024 9:36 AM, Pavan Kondeti wrote:
>>
>> [...]
>>
>>>>> @@ -274,6 +321,21 @@ static const struct of_device_id 
>>>>> qcom_smmu_client_of_match[] __maybe_unused = {
>>>>>   static int qcom_smmu_init_context(struct arm_smmu_domain 
>>>>> *smmu_domain,
>>>>>           struct io_pgtable_cfg *pgtbl_cfg, struct device *dev)
>>>>>   {
>>>>> +    struct arm_smmu_device *smmu = smmu_domain->smmu;
>>>>> +    struct qcom_smmu *qsmmu = to_qcom_smmu(smmu);
>>>>> +    const struct actlr_variant *actlrvar;
>>>>> +    int cbndx = smmu_domain->cfg.cbndx;
>>>>> +
>>>>> +    if (qsmmu->data->actlrvar) {
>>>>> +        actlrvar = qsmmu->data->actlrvar;
>>>>> +        for (; actlrvar->io_start; actlrvar++) {
>>>>> +            if (actlrvar->io_start == smmu->ioaddr) {
>>>>> +                qcom_smmu_set_actlr(dev, smmu, cbndx, 
>>>>> actlrvar->actlrcfg);
>>>>> +                break;
>>>>> +            }
>>>>> +        }
>>>>> +    }
>>>>> +
>>>>
>>>> This block and the one in qcom_adreno_smmu_init_context() are exactly
>>>> the same. Possible to do some refactoring?
>>>>
>>>
>>> I will check if this repeated blocks can be accomodated this into 
>>> qcom_smmu_set_actlr function if that would be fine.
>>>
>>
>> Also adding to this, this might increase the number of indentation 
>> inside qcom_smmu_set_actlr as well, to around 5. So wouldn't this
>> be an issue?
> 
> By the way, we can refactor this:
> 
> if (qsmmu->data->actlrvar) {
>      actlrvar = qsmmu->data->actlrvar;
>      for (; actlrvar->io_start; actlrvar++) {
>          if (actlrvar->io_start == smmu->ioaddr) {
>              qcom_smmu_set_actlr(dev, smmu, cbndx, actlrvar->actlrcfg);
>              break;
>          }
>      }
> }
> 
> into
> 
> // add const u8 num_actlrcfgs to struct actrl_variant to
> // save on sentinel space:
> //   sizeof(u8) < sizeof(ptr) + sizeof(resource_size_t)
> 

Git it, Would it be better to add this in struct qcom_smmu_match_data ?
Posted a sample below.

> 
> [declarations]
> const struct actlr_variant *actlrvar = qsmmu->data->actlrvar;
> int i;
> 
> [rest of the functions]
> 
> if (!actlrvar)
>      return 0;
>  > for (i = 0; i < actrlvar->num_actrlcfgs; i++) {
>      if (actlrvar[i].io_start == smmu->ioaddr) {
>          qcom_smmu_set_actlr(dev, smmu, cbndx, actlrvar->actlrcfg);
>          break;
>      }
> }
>  > Saving both on .TEXT size and indentation levels :)
> 
Thanks for this suggestion Konrad, will try to implement this, as it 
would reduce the indent levels to good extent.
Would something like this be okay?

static int qcom_smmu_init_context(struct arm_smmu_domain *smmu_domain,
  	struct qcom_smmu *qsmmu = to_qcom_smmu(smmu);
  	const struct actlr_variant *actlrvar;
  	int cbndx = smmu_domain->cfg.cbndx;
+	int i;

+	actlrvar = qsmmu->data->actlrvar;
+
+	if (!actlrvar)
+		goto end;
+
+	for (i = 0; i < qsmmu->data->num_smmu ; i++) {
+		if (actlrvar[i].io_start == smmu->ioaddr) {
+			qcom_smmu_set_actlr(dev, smmu, cbndx,
+						actlrvar[i].actlrcfg);
+			break;
  		}
  	}

+end:
  	smmu_domain->cfg.flush_walk_prefer_tlbiasid = true;

  	return 0;

Thanks & regards,
Bibek

> Konrad