Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1830373rdd; Thu, 11 Jan 2024 10:22:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOP1cEE9yC8BQNXin+GBOiciHoYfa5VJhI8NFT6ht05/ay8sjm3M4G5cle40CzRbn1nwQO X-Received: by 2002:a05:6214:f2e:b0:680:fe46:c944 with SMTP id iw14-20020a0562140f2e00b00680fe46c944mr56252qvb.87.1704997344798; Thu, 11 Jan 2024 10:22:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704997344; cv=none; d=google.com; s=arc-20160816; b=oyi944dudskfZWMjsuSzC7kTHyB1+4xqYDbLcmiPlVOXfKbTv0WEBPeIAJW+tadNqD 65+6JPXdhbF8QjXwIkf+0lBipmFEM3IZ7wJWuFCZeRQ00YufZnvQLreGQtUw35ca2bFs 55FH75KnVQmp6lm0XYZ2GQvyyJSwVazYDJNfgfQKnSAci26yY5vztnMkKIiUdzhb9NtW 88Ktll7FsX3GfXgt+Y+aDW+woZS7BqWt4rn8TqGZGPWZC4SOrfs6t4LJ86vn7eyhGUJO 3CCHp+2AKeBaph8zyvjuwzuBkJRr7n85I0LvbRXPSEm6Ta51ll4H59k3oginLbpBzPEc yF0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JeadZqWdYA2IdNebxsMHN/uo6ca7gtVrMgXVKsPep7I=; fh=vzbfXvY8wq2w7UI9Wj94FuawXg0Ag8zef3+Al4xy7sM=; b=g6vsKyM9y3BMsKI6DxHY22eZ/X8voCCp1zHbIo1o6Bhn3Ch52ztEWcJI05Br7k7Llh qoiSPBcfwBZIwofNvRZyrQ80GIJACn2zVOJtY6cFjDTYEWYSDL/M3ocXS6Go4SP9abZ0 Tk5jZkKHTZhmEo2dPXfzz/m3r5Z8fPdEGtcHyq893gHRoOAh9KGTTc0UVlDFOmgdS5YZ /SBQPOOYuDh/iQvEwvLMYLtnkMdcbQj3EZTrCEI/eeH32HQF9WlkOv0m1chKCShOLTob 8v+QP3c5tKSJ2gPx+kC4jC5t+8inyngKaZoJQcoCMdXaJ/NeLSoXxy4i6qDwI1i9BJTq Yrfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TB6mkpFY; spf=pass (google.com: domain of linux-kernel+bounces-23975-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23975-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v10-20020a0c8e0a000000b0067fa01e78c7si1300443qvb.45.2024.01.11.10.22.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 10:22:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-23975-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=TB6mkpFY; spf=pass (google.com: domain of linux-kernel+bounces-23975-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-23975-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8B8981C2353C for ; Thu, 11 Jan 2024 18:22:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BCCA153E0A; Thu, 11 Jan 2024 18:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TB6mkpFY" Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0CB54BC1 for ; Thu, 11 Jan 2024 18:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d542701796so30732355ad.1 for ; Thu, 11 Jan 2024 10:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704997336; x=1705602136; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JeadZqWdYA2IdNebxsMHN/uo6ca7gtVrMgXVKsPep7I=; b=TB6mkpFYsvXO+6SBUiGal4UiJh0evVOU7VGc1YhpeOa6vKnd41YAHiUZZheaWbdeDu npuORxcmrvm7brKS7IItuIWq18YLkbR9gWbJWVTiQR0ljJpqBnAeZ5KmQ/5NS377/5II dIyRjEW38kQMJ/pbbb5NJNQ/iabiCHLRD2IH4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704997336; x=1705602136; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JeadZqWdYA2IdNebxsMHN/uo6ca7gtVrMgXVKsPep7I=; b=qCZ1fNUrAEV8sbLxrt7iL1Ca53waZ92blN9+pjIZTppUKHULFHYav2yT8hcBDwvjPg tH0HUKJPJCLr4yKtSi2yROXUxlwPlsl66sDQ9hI7UujjuSgOMSggQ2aTxfDpYjhCfw0e Oc1wSRg5VNPrnY+S7cyvfznCyEu2cjEqBsC+a5bpa927bsju+oi2pyhDSAgjdGUv+d9a USR3YcybHFDhscoXykAybRF/NpBbbLuKrwil+V0CsmMBY7PuU343qI4jcybi+fuUtN2F lLFqO/Zk0WDB/k8AQs2u0/wom1LJDF0/hRiwpBiWoUa/Sa1AZWmOSBxEIRVSlt2IpCDk b+2w== X-Gm-Message-State: AOJu0YyhCnPK+lsIZHyEJ36PaiG7jWgxcajdrWgZoLvPdmSHPI/nB4AR T9nACMbCnn4yXmrm+0RXB50BSqOHoyaw X-Received: by 2002:a17:902:f7cd:b0:1d4:2473:e833 with SMTP id h13-20020a170902f7cd00b001d42473e833mr147873plw.69.1704997335994; Thu, 11 Jan 2024 10:22:15 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id kj16-20020a17090306d000b001d4301325a6sm1463892plb.247.2024.01.11.10.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 10:22:15 -0800 (PST) Date: Thu, 11 Jan 2024 10:22:14 -0800 From: Kees Cook To: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado Cc: kernel@collabora.com, AngeloGioacchino Del Regno , "Guilherme G. Piccoli" , Tony Luck , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] pstore/ram: Register to module device table Message-ID: <202401111021.AA9C35CD87@keescook> References: <20240110210600.787703-1-nfraprado@collabora.com> <20240110210600.787703-2-nfraprado@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240110210600.787703-2-nfraprado@collabora.com> On Wed, Jan 10, 2024 at 06:05:02PM -0300, N?colas F. R. A. Prado wrote: > Register the compatible for this module on the module device table so > it can be automatically loaded when a matching DT node is present, > allowing logging of panics and oopses without any intervention. > > Signed-off-by: N?colas F. R. A. Prado Ah-ha! Yeah, good idea. Reviewed-by: Kees Cook -- Kees Cook