Received-SPF: pass (google.com: domain of linux-kernel+bounces-24009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <20240110113730.3704712-1-horatiu.vultur@microchip.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, richardcochran@gmail.com, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net] net: micrel: Fix PTP frame parsing for lan8841
Date: Thu, 11 Jan 2024 11:31:58 -0800
In-reply-to: <20240110113730.3704712-1-horatiu.vultur@microchip.com>
Message-ID: <87jzofy8aq.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JN4ZuyiOET+aJMR9Muq854G4EdWcmcL1D1qEIulpFUvHpV826dzmfYMG1G09?=
 =?us-ascii?Q?AABrj9ido7c9xWVLTxhaMsxm5fa7E1y8B/qJMyHFI4saBueG+4odlnfGKexw?=
 =?us-ascii?Q?Zhponzu8OPcs2j+WVMxj5QkHwLSIAFbtSk+vjuA/AzVOD8x0R2doz/dvCSFA?=
 =?us-ascii?Q?IehHfCM4wFN46oW08jH5WyA+quMlOm36bj4UoRDPzwrQy5aAh73+e36qN6Ay?=
 =?us-ascii?Q?frcT06gaERoIvYczrr9ONWIeUbhtuW3q4ebjNLlgWkK4ynNU/W0Wflop7oXd?=
 =?us-ascii?Q?431+K7RbumB0+AnDZAC+1HI282hZf/9NfZm03QgdXKkK/NO32pgwHIbn18KS?=
 =?us-ascii?Q?lVc2xxBUKViazJK28H9lMujNArBKEvhcRecCu8jMmg5TsyTQKD3P8iLTVckm?=
 =?us-ascii?Q?g3HNWbp2f8spXvj06nBoO8eNwjqRgXinPSwI+i9RVspx1hpI0/7OamphnmWW?=
 =?us-ascii?Q?ynD1QTLwe4uZFkSJ0sFx5PLP9Hac4y0clwFK20fIZDm2DcBCNIvETKtoVGQa?=
 =?us-ascii?Q?cfe4M/7jYrZE+PdaD/g37YoYMzBFhiPICJjZdsvbzmMQJFnOaJk9yUC7OadF?=
 =?us-ascii?Q?pjixc3HLsJYyJcLSPoUpEtUeETtKIQ0Z6RATF/ZmbQtmQCMaQLWtYX9jdaql?=
 =?us-ascii?Q?wpQ78dS9Dmm6YfmYWlGv4gdOfLx+vetVNHseJFPx0IQOQ3urKwbULbMYlvy5?=
 =?us-ascii?Q?KxBMx2LCA7LUViL+rIPFi63NRAxRfmM8FoDnKp5YhNEMNUf5m/HCMPUuWTn3?=
 =?us-ascii?Q?NTTSBvWmqM3hrYDi25ddbvEpdz5L1LsJIkX+qn5gLssI5PFSaxj9je/ZLQOx?=
 =?us-ascii?Q?B7iE7KMbODUDF0V/o7CZHXGoDrpM/IlqUIm4Tpkusbj3Epj2a5bTo8ucE6le?=
 =?us-ascii?Q?ffxWIvXwblsteBV8Vcz2Xo3uUA3wXmnuJqFas0OLTxH2p5b5Woj/2E6axNlZ?=
 =?us-ascii?Q?IOVmWZwq57jo+6N5mc228S4TX2g0foZMC62F6eK/VUSN0ZfWbT1IJ2EIYIbM?=
 =?us-ascii?Q?u4WDpv2v1VGobfUZGqKRUugSwrVz95tswDdSiRSyIN+4L8heunACUJ6eVUJ3?=
 =?us-ascii?Q?j9BH8iWTVpm6nuqw5/tfZEyCxaB5wbPRUog/+AS49ppujrPHwDlfYedEp7+o?=
 =?us-ascii?Q?wLs36kBRSwJ7vBBf7FAw/LRYZBqWh9/Anl0xyX9fRFh7QnrwWzaXmv/gbKc6?=
 =?us-ascii?Q?YYSQVvsIKBsuAzjL0BQYd27QT47CE9aF+3wQhzuUmRVBB/kDj0n4CHl4Potw?=
 =?us-ascii?Q?gQDKtJO7jU59Mjve/Lf3pD/xF401eJr7SZvfd6paFl1Ljn9FEPJBSuYwYDQr?=
 =?us-ascii?Q?zvVah9dDwl8IwoqByToXLxF596xLj2PGKXzGLrX6W96UOLW6ebAz3fYGjqER?=
 =?us-ascii?Q?RlKvMc8o1npu7StIdhXhzPq5LnUtgU87jBElXI1evt8Oxick2x/POGHn+nMP?=
 =?us-ascii?Q?fzNUK84aK8uly4ePt0lJxGGQS5k6AR7WxBJfF2GNiKah9FY2NlTJH29Mo9Ih?=
 =?us-ascii?Q?iqgb0BQ+poytGEDAFrW51Bdvbt8c5x8KoFrYkhi5eFnwzFF1JlSA6v0Rj7zw?=
 =?us-ascii?Q?RvIPwfA+NWif5DMJ15f4a7POHluWqErv9zfOY4bkufvqOlosKB2sNvjQdjRu?=
 =?us-ascii?Q?ug=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08af91ee-cb87-4aa8-eaf4-08dc12dc2a16
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 19:33:19.0116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r4Wbg6CFg74aWz0UQPIqHZPejjVfu+d/qLoTTOaerpUC+QWd1MotfCi9E64QCjUJ0JcU/ENb1QSedK0QfrKHUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8216

On Wed, 10 Jan, 2024 12:37:30 +0100 Horatiu Vultur <horatiu.vultur@microchip.com> wrote:
> The HW has the capability to check each frame if it is a PTP frame,
> which domain it is, which ptp frame type it is, different ip address in
> the frame. And if one of these checks fail then the frame is not
> timestamp. Most of these checks were disabled except checking the field
> minorVersionPTP inside the PTP header. Meaning that once a partner sends
> a frame compliant to 8021AS which has minorVersionPTP set to 1, then the
> frame was not timestamp because the HW expected by default a value of 0
> in minorVersionPTP.
> Fix this issue by removing this check so the userspace can decide on this.
>
> Fixes: cafc3662ee3f ("net: micrel: Add PHC support for lan8841")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---

This is a good design decision.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>