Received-SPF: pass (google.com: domain of linux-kernel+bounces-24043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240105000632.2484182-1-aahila@google.com> <11317.1704418732@famine>
 <ZZtwKFu4GQLQ5AXM@Laptop-X1> <26173.1704830028@famine>
In-Reply-To: <26173.1704830028@famine>
From: Aahil Awatramani <aahila@google.com>
Date: Thu, 11 Jan 2024 12:31:44 -0800
Message-ID: <CAGfWUPzQuk8cw0BRVSCc1gK+_V_MLxCDhAH-=X0LgTSMF9RWKw@mail.gmail.com>
Subject: Re: [PATCH 1/2 net-next v2] bonding: Extending LACP MUX State Machine
 to include a Collecting State.
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>, David Dillow <dave@thedillows.org>, 
	Mahesh Bandewar <maheshb@google.com>, Andy Gospodarek <andy@greyhouse.net>, 
	"David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Martin KaFai Lau <martin.lau@kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>, 
	Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> > >>    Please reference the standard in the description; this is
> > >> implementing the independent control state machine per IEEE 802.1AX-=
2008
> > >> 5.4.15 in addition to the existing coupled control state machine.
> > >
> > >The status of IEEE 802.1AX-2008[1] is "Superseded Standard". Maybe we =
should
> > >use IEEE 802.1AX-2020[2].
> > >
> > >[1] https://standards.ieee.org/ieee/802.1AX/4176/
> > >[2] https://standards.ieee.org/ieee/802.1AX/6768/
> >
> >       I'm fine to still reference the 2008 (or 2014) standard even
> > though it's superseded; the 2020 standard is much more complicated, and
> > I find it harder to follow (particularly for the coupled / independent
> > control sections, the older standard explains them more clearly in my
> > reading).  Bonding does not implement any of the new things added for
> > the 2020 version, so we're not really missing anything.
> >
> >       That said, as long as the citations are for the correct section
> > (the numbering is not consistent between versions) any version is
> > acceptable.

I have gone ahead and referenced 2008 in the documentation.


On Tue, Jan 9, 2024 at 11:53=E2=80=AFAM Jay Vosburgh <jay.vosburgh@canonica=
l.com> wrote:
>
> Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> >On Thu, Jan 04, 2024 at 05:38:52PM -0800, Jay Vosburgh wrote:
> >> >+coupled_control
> >> >+
> >> >+    Specifies whether the LACP state machine's MUX in the 802.3ad mo=
de
> >> >+    should have separate Collecting and Distributing states.
> >> >+
> >> >+    The default value is 1. This setting does not separate the Colle=
cting
> >> >+    and Distributing states, maintaining the bond in coupled control=
.
> >> >+
> >>
> >>      Please reference the standard in the description; this is
> >> implementing the independent control state machine per IEEE 802.1AX-20=
08
> >> 5.4.15 in addition to the existing coupled control state machine.
> >
> >The status of IEEE 802.1AX-2008[1] is "Superseded Standard". Maybe we sh=
ould
> >use IEEE 802.1AX-2020[2].
> >
> >[1] https://standards.ieee.org/ieee/802.1AX/4176/
> >[2] https://standards.ieee.org/ieee/802.1AX/6768/
>
>         I'm fine to still reference the 2008 (or 2014) standard even
> though it's superseded; the 2020 standard is much more complicated, and
> I find it harder to follow (particularly for the coupled / independent
> control sections, the older standard explains them more clearly in my
> reading).  Bonding does not implement any of the new things added for
> the 2020 version, so we're not really missing anything.
>
>         That said, as long as the citations are for the correct section
> (the numbering is not consistent between versions) any version is
> acceptable.
>
>         -J
>
> ---
>         -Jay Vosburgh, jay.vosburgh@canonical.com