Received-SPF: pass (google.com: domain of linux-kernel+bounces-24081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240111001155.746-1-carlosgalo@google.com> <202401120052.rdFjpivG-lkp@intel.com>
In-Reply-To: <202401120052.rdFjpivG-lkp@intel.com>
From: Carlos Galo <carlosgalo@google.com>
Date: Thu, 11 Jan 2024 13:20:30 -0800
Message-ID: <CABtOLRJ8=fPePsAG1-QyF_uo2X=sOGXcgsU_fJJXk3mFyOVN+w@mail.gmail.com>
Subject: Re: [PATCH] mm: Update mark_victim tracepoints fields
To: kernel test robot <lkp@intel.com>
Cc: rostedt@goodmis.org, akpm@linux-foundation.org, surenb@google.com, 
	oe-kbuild-all@lists.linux.dev, android-mm@google.com, kernel-team@android.com, 
	Masami Hiramatsu <mhiramat@kernel.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, 
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, 
	linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 11, 2024 at 9:08=E2=80=AFAM kernel test robot <lkp@intel.com> w=
rote:
>
> Hi Carlos,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 0dd3ee31125508cd67f7e7172247f05b7fd1753a]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Carlos-Galo/mm-Upd=
ate-mark_victim-tracepoints-fields/20240111-081635
> base:   0dd3ee31125508cd67f7e7172247f05b7fd1753a
> patch link:    https://lore.kernel.org/r/20240111001155.746-1-carlosgalo%=
40google.com
> patch subject: [PATCH] mm: Update mark_victim tracepoints fields
> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/2024011=
2/202401120052.rdFjpivG-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi=
ve/20240112/202401120052.rdFjpivG-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new vers=
ion of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401120052.rdFjpivG-lkp=
@intel.com/
>

Sorry, I missed a comma in my final editing.
I posted a V2 here:
https://lore.kernel.org/lkml/20240111210539.636607-1-carlosgalo@google.com/

Thanks,
Carlos

> All errors (new ones prefixed by >>):
>
>    In file included from include/trace/define_trace.h:102,
>                     from include/trace/events/oom.h:206,
>                     from mm/oom_kill.c:54:
>    include/trace/events/oom.h: In function 'trace_raw_output_mark_victim'=
:
> >> include/trace/stages/stage3_trace_output.h:6:17: error: called object =
is not a function or function pointer
>        6 | #define __entry field
>          |                 ^~~~~
>    include/trace/trace_events.h:203:34: note: in definition of macro 'DEC=
LARE_EVENT_CLASS'
>      203 |         trace_event_printf(iter, print);                      =
          \
>          |                                  ^~~~~
>    include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAM=
S'
>       45 |                              PARAMS(print));                  =
 \
>          |                              ^~~~~~
>    include/trace/events/oom.h:74:1: note: in expansion of macro 'TRACE_EV=
ENT'
>       74 | TRACE_EVENT(mark_victim,
>          | ^~~~~~~~~~~
>    include/trace/events/oom.h:93:9: note: in expansion of macro 'TP_print=
k'
>       93 |         TP_printk("pid=3D%d uid=3D%u comm=3D%s oom_score_adj=
=3D%hd",
>          |         ^~~~~~~~~
>    include/trace/events/oom.h:95:17: note: in expansion of macro '__entry=
'
>       95 |                 __entry->uid
>          |                 ^~~~~~~
> >> include/trace/trace_events.h:203:39: error: expected expression before=
 ')' token
>      203 |         trace_event_printf(iter, print);                      =
          \
>          |                                       ^
>    include/trace/trace_events.h:40:9: note: in expansion of macro 'DECLAR=
E_EVENT_CLASS'
>       40 |         DECLARE_EVENT_CLASS(name,                             =
 \
>          |         ^~~~~~~~~~~~~~~~~~~
>    include/trace/events/oom.h:74:1: note: in expansion of macro 'TRACE_EV=
ENT'
>       74 | TRACE_EVENT(mark_victim,
>          | ^~~~~~~~~~~
>
>
> vim +6 include/trace/stages/stage3_trace_output.h
>
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Goog=
le  2022-03-03  4)
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Goog=
le  2022-03-03  5) #undef __entry
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Goog=
le  2022-03-03 @6) #define __entry field
> af6b9668e85ffd include/trace/stages/stage3_defines.h Steven Rostedt (Goog=
le  2022-03-03  7)
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki