Received-SPF: pass (google.com: domain of linux-kernel+bounces-24104-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240109-axi-spi-engine-series-3-v1-0-e42c6a986580@baylibre.com> <20240109-axi-spi-engine-series-3-v1-2-e42c6a986580@baylibre.com>
In-Reply-To: <20240109-axi-spi-engine-series-3-v1-2-e42c6a986580@baylibre.com>
From: Rob Herring <robh+dt@kernel.org>
Date: Thu, 11 Jan 2024 16:03:24 -0600
Message-ID: <CAL_JsqJPRwDbQDAg0nqb2VRT3K3qWPWhQo_jsu20f7RcgSgdsg@mail.gmail.com>
Subject: Re: [PATCH 02/13] scripts: dtc: checks: don't warn on SPI
 non-peripheral child nodes
To: David Lechner <dlechner@baylibre.com>
Cc: Mark Brown <broonie@kernel.org>, Jonathan Cameron <jic23@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Michael Hennerich <michael.hennerich@analog.com>, =?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>, 
	Frank Rowand <frowand.list@gmail.com>, Thierry Reding <thierry.reding@gmail.com>, 
	=?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	Jonathan Corbet <corbet@lwn.net>, linux-spi@vger.kernel.org, linux-iio@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org, 
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 10, 2024 at 1:51=E2=80=AFPM David Lechner <dlechner@baylibre.co=
m> wrote:
>
> According to the spi-controller.yaml bindings, SPI peripheral child
> nodes match the pattern "^.*@[0-9a-f]+$".
>
> A SPI controller binding may require a child object node that is not a
> peripheral. For example, the adi,axi-spi-engine binding requires an
> "offloads" child node that is not a peripheral but rather a part of the
> controller itself.
>
> By checking for '@' in the node name, we can avoids a warnings like:
>
>     Warning (spi_bus_reg): /example-0/spi@44a00000/offloads: missing or e=
mpty reg property
>
> for a binding like:
>
>     spi {
>         ...
>
>         offloads {
>             offload@0 {
>                 ...
>             };
>             ...
>         };
>
>         peripheral@0 {
>             ...
>         };
>     };
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  scripts/dtc/checks.c | 4 ++++
>  1 file changed, 4 insertions(+)

Check the commit history. We don't take changes to kernel's dtc copy.
They must go upstream first.

Rob