Received-SPF: pass (google.com: domain of linux-kernel+bounces-24132-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f45e5b7c-4354-87d3-c7f1-d8dd5f4d2abd@oracle.com>
Date: Fri, 12 Jan 2024 04:54:15 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [btrfs] commit bc27d6f0aa0e4de184b617aceeaf25818cc646de breaks
 update-grub
To: Alex Romosan <aromosan@gmail.com>, CHECK_1234543212345@protonmail.com,
        brauner@kernel.org
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
        linux-btrfs <linux-btrfs@vger.kernel.org>,
        Linux kernel regressions list <regressions@lists.linux.dev>,
        linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>,
        dsterba@suse.cz
References: <CAKLYgeJ1tUuqLcsquwuFqjDXPSJpEiokrWK2gisPKDZLs8Y2TQ@mail.gmail.com>
 <39e3a4fe-d456-4de4-b481-51aabfa02b8d@leemhuis.info>
 <20240111155056.GG31555@twin.jikos.cz> <20240111170644.GK31555@twin.jikos.cz>
Content-Language: en-US
From: Anand Jain <anand.jain@oracle.com>
In-Reply-To: <20240111170644.GK31555@twin.jikos.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QkFiT3prV0RHVWZiRG95N3lCNHZicU8wbnNkdVZqUVZSM1Z3QkZqUXBadnhG?=
 =?utf-8?B?dy9IUXJtN3lzZ1MyRnhUQWxtbFlmeUk0dVpBdWMrUDd0VHB6ODVhWmJ2NEU1?=
 =?utf-8?B?VisySDU5akxOTER6VnZGU3Y0RW8vM1dGcVpIa2VsUjc5SkF4UERFblRWWW83?=
 =?utf-8?B?a3N5WWE0TGJ2d3R0NDN2aGE5Nko0UmtTM1Z0MGFtT1gweTN0eUVUWE1lVnBT?=
 =?utf-8?B?T3lpQ3R5amoxaUs4K0Z3Vk9SUHRJNTRCbTlqZ3VJQ2krdEZSNUI2M2Fmd1Rx?=
 =?utf-8?B?QVd5UlNOMzF3bzF4RkU0T1BvRnZaUHZEV2toOWJqblYydFQzWkxDdjA1WjNG?=
 =?utf-8?B?YURQdFBLcWRBNmpwZjNuY1IrZHorTndxdXNwY3k3WE1neW5BWFFabkZWRnpO?=
 =?utf-8?B?d0dUVGNISmxTd0NOU29oa3cwTDQvd3ozL2NVOXE0UldpZDVpM2c3aGcyQUE2?=
 =?utf-8?B?bVpzcVZYNW13YXAzc1JzTUFnZ0RMR0dLd1NYSFJIeXlQMUF6QW44UUZXMVNS?=
 =?utf-8?B?T0xvdzRtMks2Q05kVm04bmtUN08yMTRMbkZhVXJOWncvZVdIbXA0cjBseGd4?=
 =?utf-8?B?d2tHNXlIbVJEaUwwU3Z0VklJbWt4OGxCWTU3UlVPSEIwNXJWdkYwUUxkVXRy?=
 =?utf-8?B?SGM3OUd0ZGhuTmhIeUZwdUg4K3FHc3dWb2dqM0dzWEh4dWpwZ1U1bWRSVXpM?=
 =?utf-8?B?bWhDbkhHR0MwM0hESGVOZ2dtbWtTcVNEbWRHdkw1aHl2R0VPNDc3NFFBaUM1?=
 =?utf-8?B?T3pUYzdhcGRadXh4OHJ4eDdtaWt5VXMzR05qbzZneDlpTDJrYjVNTGtrNFBQ?=
 =?utf-8?B?Zld6VHdEYjFKR3cxOFhjSWxtU05RcFJsWE5KK1Y1bE41WVl6dHRyVXo2Q3FQ?=
 =?utf-8?B?MzZWY2YrSHJqWjIvZnVrU3RIZzFrT1ZKSzdXZU5rTlVQRUdSaHJYU2pUdmU0?=
 =?utf-8?B?bmlxbFlCSk9LT0I2NkxKbTdjZXF5L2wwWXBXM3F1V1V6am5JdkFkc0dJalcr?=
 =?utf-8?B?K2QxZmtJL2tVbnVPUWYrNjArL3NFdHRxZWR1aTJ5MStIcG14VmdLNVoxNks1?=
 =?utf-8?B?L3NzQTJGbWNYUXFEc0JJSDNkK1hWRzBoSFc4ZW8yclNlWTJSWEJ4SlYzRWhL?=
 =?utf-8?B?NXowdWRQREJ6YUtwajk4cDhMSHRDZENINW9PYytUci9ueGNqTkd1K294NmNV?=
 =?utf-8?B?OU1BdmQ2NS9JOURsc2dCNStKMXBsb0sxYmZYZEpVSHNicGdiczNoMnFhUk5S?=
 =?utf-8?B?TTFWajhVc1NDeTRMUHdJNUlJS0pRRjVNMmxwbFAwS01qditJeFlqRHpLOWVE?=
 =?utf-8?B?aDlRM1RIODFSME4rdmVvdkhUVE41Zmg1MC94cXdWQWx0Q29TQzF5Q3VQS2VD?=
 =?utf-8?B?U0c4RVNOMGtTOGlqOEdCS1JtVk9UQWdDTEpYRE44OWpVK3MzVGFSOEs4dFJn?=
 =?utf-8?B?c2FMVUZYbkdsNmZLZlJLWkFQRHNvdTQzSlBDRVhET01SYkVjK0MycExkdnV2?=
 =?utf-8?B?Q284VzgxNU1JU3ZDNzRVKzBURHJqME5oU0Z2Q0kwM3BkeEtJZTl5QnJmOFV6?=
 =?utf-8?B?THdkR0hKRkZURHl1aGl6d2xURnVuVEx0NlZVSmIyL2RsZ05keDdEUzcyVmgy?=
 =?utf-8?B?R3Z5SnN0b2hCQlR2QjhkazlOWDZ5aS9WSkRvVjVzN3ZReUtuanJKWlIwT092?=
 =?utf-8?B?cDJYZlpkMzVyUVNkc1kzWG5NVUNzV2RvNEJEOU9kSFd3WlZaZ0d1aWdCdXdM?=
 =?utf-8?B?OTlaQ3JpREk4YlhhclFhSjBUODhPRTJubHY3N1R0aDJwT3prekFmbXE0NmR0?=
 =?utf-8?B?cUNmVUQydHhpNFZiRkYvbUFHYzhXZm8vRnEzNkJGRDhlSE9BNDNvdW43dk1m?=
 =?utf-8?B?SWZxbzE4d3NTNzhTbmI1eWkxVk4zbmc1NURtMWp6WHhXalJlb0s5M1VGWjIr?=
 =?utf-8?B?Z1hhL2pqQkphVm1RYVVzZEp2TTJlaWN1VXNjZklodlVHWlBXdmhUR21MUXZQ?=
 =?utf-8?B?VTUrNldFNjdTdFBIU21CZy9Cc3NHalo2QlJSYnFDRi9mZzEydmJybjByZ3Uw?=
 =?utf-8?B?RDZvOUV4KzB4WmRjQnk5NDROOCsreVBtcEV4SXNJZkVnaTZWQ2E5cnJsWDJk?=
 =?utf-8?Q?NpC2N9G6qIHbRY5WMDX1n3c6m?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	AdQTgEdT1BDQhixH0OkHVii7m83edvHffOhKYKo5VtLZqJEfmQdtg0GTnaSY7aANiV8+YUv6jhyUoxOsYqh6raJNw1ZYKqkQCTZhusEmM/rhcNfTPEh/cjltFCPZguZBXD5rqLweztELitEdCgHcLhsPU9Wgj+m3R46iP8dJmClRWxC+yXQLWYOcWGs5syPeF84YegBBBHwnRWmFFVKfbv4bo+OKP5fb4BFmRTScWdwPrnq5A4g3/LptN3Dvrvq+22G0yqi8cuH7aeie6LyfcZAgbfKbstEC0X8yt1OYpzwW7ZpjM7G57paZTiWTY0heqYPsoYy77/mSYa/+aUrRZB5XsnIchtlngD5E+H77ywcPgQp6lA9kq/dmQqPqgppX1Ty3bvRSW7QPe1/GfR4WVyVzSL+VFtbW89bAOhpzYQGRbknwmKIeMeRTmChMPBcf8vN11FIj6n5LQHMf4ESpGvMEbVf+n5PeHyhicutdPJFlhwzw9APMqj3Ysu2oDYsIWzJFIYvq4NRJ7k3O6/iFJrHZds1AhG8XRxBBxVmr8nxBxASJNLRc1BmVfQrMgYhgxLYUI9YHTzZ5IG/FUXLMDyBrXhuXuMXN9Mk6Er94Zo0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44ee16f7-9c8a-459b-4187-08dc12fc713d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 23:24:22.3784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vQh+nrbYRosCdzuTxyai+3ovnzaKUlYRWK5WLzV4NGIyX3AAKMncysAuc0Ejy2mRDMRIDCprlUbn9MvCGe2CTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4904
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-11_13,2024-01-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401110180
X-Proofpoint-GUID: GJX01vQKHBiZywI9Q9g5a8gCIZfkbkN6
X-Proofpoint-ORIG-GUID: GJX01vQKHBiZywI9Q9g5a8gCIZfkbkN6


On 11/01/2024 22:36, David Sterba wrote:
> On Thu, Jan 11, 2024 at 04:50:56PM +0100, David Sterba wrote:
>> On Thu, Jan 11, 2024 at 12:45:50PM +0100, Thorsten Leemhuis wrote:
>>> [Adding Anand Jain, the author of the culprit to the list of recipients;
>>> furthermore CCing the the Btrfs maintainers and the btrfs list; also
>>> CCing regression list, as it should be in the loop for regressions:
>>> https://docs.kernel.org/admin-guide/reporting-regressions.html]
>>>
>>> On 08.01.24 15:11, Alex Romosan wrote:
>>>> Please Cc me as I am not subscribed to the list.
>>>>
>>>> Running my own compiled kernel without initramfs on a lenovo thinkpad
>>>> x1 carbon gen 7.
>>>>
>>>> Since version 6.7-rc1 i haven't been able to to a grub-update,
>>>>
>>>> instead i get this error:
>>>>
>>>> grub-probe: error: cannot find a device for / (is /dev mounted?) solid
>>>> state drive
>>>>
>>>> 6.6 was the last version that worked.
>>>>
>>>> Today I did a git-bisect between these two versions which identified
>>>> commit bc27d6f0aa0e4de184b617aceeaf25818cc646de btrfs: scan but don't
>>>> register device on single device filesystem as the culprit. reverting
>>>> this commit from 6.7 final allowed me to run update-grub again.
>>>>
>>>> not sure if this is the intended behavior or if i'm missing some other
>>>> kernel options. any help/fixes would be appreciated.
>>>>
>>>> thank you.
>>>
>>> Thanks for the report. To be sure the issue doesn't fall through the
>>> cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
>>> tracking bot:
>>>
>>> #regzbot ^introduced bc27d6f0aa0e4de184b617aceeaf25818cc646de
>>> #regzbot title btrfs: update-grub broken (cannot find a device for / (is
>>> /dev mounted?))
>>> #regzbot ignore-activity
>>
>> The bug is also tracked at https://bugzilla.kernel.org/show_bug.cgi?id=218353 .
> 
> About the fix: we can't simply revert the patch because the temp_fsid
> depends on that. A workaround could be to check if the device path is
> "/dev/root" and still register the device. But I'm not sure if this does
> not break the use case that Steamdeck needs, as it's for the root
> partition.


Thank you for the report.

The issue seems more complex than a simple scenario, as the following
test-case works well:

   $ mount /dev/sdb1 /btrfs
   $ cat /proc/self/mountinfo | grep btrfs
345 63 0:34 / /btrfs rw,relatime shared:179 - btrfs /dev/sdb1 
rw,space_cache=v2,subvolid=5,subvol=/

However, the relevant part of the commit
bc27d6f0aa0e4de184b617aceeaf25818cc646de that may be failing could
be in identifying a device, whether it is the same or different
For this, we use:

      lookup_bdev(path, &path_devt);

and match with the devt(MAJ:MIN) saved in the btrfs_device;
would this work during initrd? I need to dig more. Trying
to figure out how can I reproduce this.

Thanks, Anand