Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1980654rdd; Thu, 11 Jan 2024 15:56:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZtImHBAFGaKiQaZnU4KlYL42mo2f52i+DUU+OrUJK7KAGO6PBHs4jkZVZEVZz4ag3bJOB X-Received: by 2002:a05:6a20:7345:b0:199:a1b2:aa04 with SMTP id v5-20020a056a20734500b00199a1b2aa04mr148098pzc.3.1705017396225; Thu, 11 Jan 2024 15:56:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705017396; cv=none; d=google.com; s=arc-20160816; b=Usato1IJqSFjc59ERexaADgAfpY3dVsMj7iW19hKgX2HtXQLPY+mMXSG3RWcrHilix WNfU4h0tX2z/pyyYTtj/+IpeOTjPzSvh5C+lVa8+LnfiEhPdRg6N/ABVNKQmUPToYgV+ BNbeQZJRD2XXC3fk7yIiNTfqy42b1EIPIIxLDw6VAbGQRO/v6fB0k29HfaZ4P9N8HWxc lY+q1gJVhVUNXLRKlLxYQf/pCjKZiidLHf8DfSaRpzEB0AKQazIp5gVIWVR5U+G8HVe/ l8eyRhTxC3S40EwL2fbMBDXBsNQ3pr6JdWeNLZBh0r11rB79WNlIIcISFFULrgxgnZhI jkCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=n+nCZM0hFYgzX3IRWvDp+pC8iDY9a9HsVjeCq52/iDs=; fh=2rcWup1I7VmS06q2ePGjNzDZ5ebwilRHpvtB8StIjE4=; b=YfKDLdErqkAqdZImOPaeaGy6xCPjLMRCjubxXfIihsxuOy80xe2tahoK/a5N+cPmCY n8tz/sx95OFmimu61xN4nTmzjASuxUdsCxRpMvU6df7N+bIZbeTJG+okwPQ/vSzpsNNq iTO4QD3nltx4yVpF2zNFPgJNmeW441ggbA1CPWZncodJl9ookFSIVpW5ZUqjtI5oaR2T 0ERh+U+dUHVVw52XjT1GzOuUHghDjaAMO87I1GRrFGYpF45OMY6McmN4KKzK8+h0g0Ff JXxbr999A53v9ZptmwFb5mZOOjTPmUjvlkA4rl64ME0QI3WrTZ8YwFzcZ5BEksQVBpxk wXMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-24152-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24152-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y189-20020a6364c6000000b005ab53fee611si2041669pgb.423.2024.01.11.15.56.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 15:56:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24152-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-24152-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24152-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8D67E2837F0 for ; Thu, 11 Jan 2024 23:56:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34B015A0EC; Thu, 11 Jan 2024 23:56:25 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9BD5FBF8; Thu, 11 Jan 2024 23:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=heusel.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=heusel.eu Received: from localhost ([84.170.86.196]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mgf4k-1qwTNk0h3s-00h4Vm; Fri, 12 Jan 2024 00:56:08 +0100 Date: Fri, 12 Jan 2024 00:56:06 +0100 From: Christian Heusel To: Damien Le Moal Cc: Jens Axboe , Dave Chinner , Jan Kara , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Christian Brauner , Min Li , Greg Kroah-Hartman , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org Subject: Re: Re: [PATCH] block: print symbolic error name instead of error code Message-ID: References: <20240111231521.1596838-1-christian@heusel.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yarfvsbjhgg33kw3" Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:ZUj61C/DBmc+kOIpNqNL/soE/JLUVBGg1kTN3wxtwTJfGDpoll1 EKGPxx1vsOCNlVdJ65aqnu0lct6/PR62ZZf/Frd1ox5arvXPxboF76At9KAXyoS+X1JkSTq 4GDe1W+hHCr/OhwAwy7xNE65snO+hHnYs14MzVQAT6Zj5+EDJDSGWDOJdKELZzHbAcpn28w HCY5WqrqkwFxxY7u6sukQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0P7DSLV+OxI=;B47Sj56trwMinxQveS9f8LONo0m YcCPXgop/WJzA78DN7jg5XbclOd3zLjrApNH6MQhdCmFWZGIdZ2r7sFY9dVdG2j6F4rWqbkPC Aeu2Mn403WquqOKEu1cxJYdiqd5S4TkGIka6Mlre6Gv7qDhqD18SYZ9/C/6Ha/s2ju946wvVp xYwpbU9kGbruJwm5hf3YimRgJe/sqJ3rUZirNW5MiP9/20yKwYYrexj1BqMHDipRs5Gop76H8 uFTJI9aQgql9TcZNEBVQbNvK+GuTRtnV6kg28zQZ4nlpOmi2ixO5GV/TaQ+ToxLHZmriAypZs Ue/lEmJn4VghIrHqdU9mEKEdN7HcVIuxH6h5nH3MO4Ra1rFfwGowF79y7/d+quPD+zHsaovQp LW2z8ThrlVbkvfFJnl77u9AAP1fLhWtvd3OtY1YQ8XZh3437Jp4Q9Eodc2akYY0P0qtqOdiD3 qh8sjEfbNraEucXModX4NHbZ7w7dsU1wj4wf6Kb2ZCJpmRmY2lYfx94mUGn7j9B+knQk4dT4m eRiwQ/PSZiZ8clx2bodzhdVTVIm34lM4IrZaKrmGMPUbefTVGORT1AxXWyt95WGCxKfqD7PiL eciB5x7w7kXdq4A0RP6SPFu5ROu6fceUuOhSs6N+r24ZxFG3Rjuzci5S3HPIbKtINNMdN0N/b MF04A5himVCt8NmaGVV01W6uuyQwZWx8nc4hEBjUKOYuCFVi1KzmBhlVRyvHODFSDBFAGcvj9 JQfUxNVo9+HwPuXP8Wqt/CXfH4PWQkoSvby1EyPjv8Q/EoIuXh/ISyfuTJha6zS3XGLdrXm7b 0Yv4iILvgKO0Z6yoqWU1zI1/WApBGJGgOnVIERk3r2fBw3Aoufx9Q37Kqx2v2Bdif7InjOBQ9 grhZ+BF834TYoBQ== --yarfvsbjhgg33kw3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 24/01/12 08:37AM, Damien Le Moal wrote: > On 1/12/24 08:15, Christian Heusel wrote: > > - printk(KERN_ERR " %s: p%d could not be added: %ld\n", > > - disk->disk_name, p, -PTR_ERR(part)); > > + printk(KERN_ERR " %s: p%d could not be added: %pe\n", > > + disk->disk_name, p, part); > > pr_err() ? If desired I can send a v2 containing another patch which refactors the usages of printk into their respective pr_* aliases, but I wanted to keep this consistent to the usages in rest of the file and do one change at a time. Cheers, Chris --yarfvsbjhgg33kw3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEb3ea3iR6a4oPcswTwEfU8yi1JYUFAmWggBYACgkQwEfU8yi1 JYW7BxAAtGYU/xIjCnok1HbUvBJdQMBxrK7pg9wVHvfwCRq/zyTItadRbaw2l5nC TXEl4z1Yzcvtu47AiGYwYWvc9D16ZWGHk3CtICEs8lZ+mWZs1kpw22MoUhS4zaov Fpv39OcP60eEp//6Ep8BbfA8VKbNI8iuH7fyLIpAy+t8X87iufpN111PcfNtedHK oVIBqEbV9xVTbOmdurj2nAhAmeecY2ON48WTmxLEtDmDzk+UI6+3SEYRfcBZfMU5 ksSqs7hhXCzyk+yLyHrayq7j2mW9BKgRuNbJTYIPlNw8fzGCe0I6DkwisvgScj3A enZe8wbz+/GG0C29DaCp453BBa2Y+HbBewNUKBrIDvSq7MDKK0wlBaaLMdkIm+Oq ci7jhKka7ApXY+9J5ZKOWuyXwD30W0W9Ha3tkX+sp7TXKf6XT3pQisgRR6KdosKe 3nJkNXj9m3oXeAP/XLutd2qCAsi033oYxL54PLgDKg54Q3TkMhgayWShOyznT4aG u+lkCUKMbqjXWXthnG+6hsFeeILSHUcoAOHh0LuZfrRz9MfVwRxGsOzB76XNUFti f9rzP+O7xbzSCAjBtsu18bZRFAfiOjP0v12GgmoA0GxN2BNa/aETEvMDbmiypNV3 jQI17th5wbtTHqGWQ19d6egy9CerLh/3TujmqRNUPyC+uiAS4x4= =5Gas -----END PGP SIGNATURE----- --yarfvsbjhgg33kw3--