Received-SPF: pass (google.com: domain of linux-kernel+bounces-24185-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Peng Fan <peng.fan@nxp.com>
To: Martin Kaiser <martin@kaiser.cx>, Linus Walleij
	<linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>
CC: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] gpio: vf610: allow disabling the vf610 driver
Thread-Topic: [PATCH] gpio: vf610: allow disabling the vf610 driver
Thread-Index: AQHaRJ+WqP9gCRQCxEO4s+d81h4DHbDVVuJg
Date: Fri, 12 Jan 2024 00:44:10 +0000
Message-ID:
 <DU0PR04MB9417956F985780AD85FD733E886F2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240111150429.681567-1-martin@kaiser.cx>
In-Reply-To: <20240111150429.681567-1-martin@kaiser.cx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?45lyMATeZi4ZR1qTe9S0Jg7mxSaQ1grtsPwmSIv7DmUuLs7fs8N6qCYEOK2d?=
 =?us-ascii?Q?qu4WvwuG+V5m4OBuORv7080uqhwUfS/8SUUkwVatUKhUunGmzcZPU13K5yY8?=
 =?us-ascii?Q?LAa7vIcedfjKhm7oby96rhN5Tic8fNoXjVZjDNuKz+C3kgM/GCFH86vrIgNj?=
 =?us-ascii?Q?SsilN6sRu0QRV18H9cyF7ABQiQBCOkj3EG39l4W8reDT98f+zRFc4L1zmlnw?=
 =?us-ascii?Q?j7ncQ9vKxVwTTnsS/xA2lKZKQQSOq42qRxTQLcZx3Nthh92MQLhkNeaPYpas?=
 =?us-ascii?Q?eexyN/dU5xFb/4M8Rplt0efPg3hGiNccDmX90LkV0Pdy2ID5vlHGUN5AhaL4?=
 =?us-ascii?Q?xfhqL+9KI3rZYYoEF0wiFVC+9plzPxNIu0CZV+AQ1NJ3B1PrWX89EzM/jG/c?=
 =?us-ascii?Q?aj+KHqDOMdoBr9ogwhePHgN8LXNmRV6jELWC8DURvB9bkDBpdMG891R6hDaj?=
 =?us-ascii?Q?OxXgkzomtwdJJDhluA7qhQfhp2RsJ0VVDOGbIKlHB4nCUyRkHv6+kC0+gOXT?=
 =?us-ascii?Q?dIbcKZnt+6jKhJN08VBL5vgheHIARxz7jGzn0vtt+SbBF8Hw1BIAJ2lMSAr7?=
 =?us-ascii?Q?Mt4r19/RQSDF5tDKksHv46U8dsvfxbwLIPDgzOngwjMixdl1TRRMkhWBiert?=
 =?us-ascii?Q?YYWnDTLrCnUwanG/xhC9590BbL4Ik/itD6UJQx6gfiGgryhJjiYAqOsnJoNl?=
 =?us-ascii?Q?IQuudhxXjOTG88MnzbLf8ejsvnUEetnB+QsCa3AyU2p4pCiwMccgrzaqL8Mx?=
 =?us-ascii?Q?+V0lyPXFwNtAeULuroi+B31sro+0TKfIn+3gbFm4qfe6uzEXUmoaXXnOfsDB?=
 =?us-ascii?Q?x+ccuLs500v1/+GL3essedJDn3SRE8nVI+esR1HX5BkKsRAgWm6a2odvN/JZ?=
 =?us-ascii?Q?hAp+K1N37Iwr7aLoxvO0OU8XvfTqr/OjkL7e0XAABS2Yx4MlMoWTPeSI6ozh?=
 =?us-ascii?Q?7zTVarHvHIqbvnxSfrklVr5ipch9S4NDi3Hp37+UWwkRg4dejZJi0dw5GjTw?=
 =?us-ascii?Q?wnZMhYOVLDGckceou3S/SxaVWbc866+9HqrT3WgcDJ5PlIExqhZUXU24fcF0?=
 =?us-ascii?Q?YXASePejLFD8E0p2cYhnI1fSn6VW3fgTmz78og9ALUks8P87K9EGOG3nTGw+?=
 =?us-ascii?Q?IV0lFJecxaHqK/roXFVGecitc4E/Zv5PjG4AGZ75YgJ5p/zHTvUZv822VCgn?=
 =?us-ascii?Q?0KlyQB8+v5TydS8O1Ra/dyjzgln5NF17+i5P+ehkFuBHRPvXkyLl7C9qWE41?=
 =?us-ascii?Q?X2xT7LWGJ5Xxa1LjQA3xltCU4KqjJJq/IRw2HIjOV3LVDHv3PkknheASma6u?=
 =?us-ascii?Q?vrK4jaqsh7Ic7+ZNSHa6uc7y9kQA46Qyjpi9BFmmbSgAne9XSf2QZvNdk+sE?=
 =?us-ascii?Q?AvCpp0/iVLSpLCorfP2gXgZLtlkaM9UqH8wJf7kp9svVY07tNYM/0k4ysx+2?=
 =?us-ascii?Q?ZorjWSmi4x1SclDEHcc9hrO3GPkdRK0LA29ylk2XuLN2Kw8ai7QdXomII7Qk?=
 =?us-ascii?Q?nmp1tT+yYLkrqLSw6kwCzasbK955EWH3zdXT516cxzJaQGd9+kcp7NNlJ1Jl?=
 =?us-ascii?Q?4JFEOi1OcKtXS3IGSp0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62f3b804-2fa8-43bd-a785-08dc1307977d
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 00:44:10.6705
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MqmsHFnBA1fgXvUDMdKYWIobZj2IjFyWubYnk9tWvVJ6F15C8ZB35EW5g493NOW7D8cH1966cpeCaQwjs/MSMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6877

Thanks Linus for Ccing me.

> Subject: [PATCH] gpio: vf610: allow disabling the vf610 driver
>=20
> The vf610 gpio driver is enabled by default for all i.MX machines, withou=
t any
> option to disable it in a board-specific config file.
>=20
> Most i.MX chipsets have no hardware for this driver. Change the default t=
o
> enable GPIO_VF610 for SOC_VF610 and disable it otherwise.
>=20
> Add a text description after the bool type, this makes the driver selecta=
ble by
> make config etc. i.MX chips other than SOC_VF610 can now enable the drive=
r
> from their board config.

This will break i.MX8QM,DXL,ULP/i.MX93 boot. You could add text description
to make it selectable, but please not drop def y. Or you need update defcon=
fig.

Thanks,
Peng.

>=20
> Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for
> GPIO_VF610")
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/gpio/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> 1301cec94f12..353af1a4d0ac 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -711,7 +711,8 @@ config GPIO_UNIPHIER
>  	  Say yes here to support UniPhier GPIOs.
>=20
>  config GPIO_VF610
> -	def_bool y
> +	bool "VF610 GPIO support"
> +	default y if SOC_VF610
>  	depends on ARCH_MXC
>  	select GPIOLIB_IRQCHIP
>  	help
> --
> 2.39.2