Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2014443rdd; Thu, 11 Jan 2024 17:20:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHr7NKSTJc7GuWEb0EfLadD5wFoxu650HVPewmjS4F9a8etHX90LRm2mBgSxbFGXQrQHpps X-Received: by 2002:a50:ed18:0:b0:552:fcca:ee11 with SMTP id j24-20020a50ed18000000b00552fccaee11mr167403eds.74.1705022439795; Thu, 11 Jan 2024 17:20:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705022439; cv=none; d=google.com; s=arc-20160816; b=txcKgVWhtAJuJYnDHRiVZ6cxIiFLhSZdTLQiYsezlPOO7B6CEqpEasPpHbpas8tgwC Q81rHKx9wDYBq602XskmMTGOO+tz2t9Gz8J/1C08DlX7y/3cdo33XFCF08iINC+IUX1F 6rIIyH84gVPbfvkpntB/qCBkv6sWAUMijqvppMu1hRZy4H5ffEhRARcMDc2qeQStEQkx ZkReFly8jC8t2FB0Eleqz8NinC92B/+GvouQt26FMWq/6QvrKh96P1l+R1o90C2S6bzp U1BBZbO6/7FoD7OZgyzjulONe9bZ2BaWIOPxsPAFmvw2/iTisGNX9uS1kLwD1rIj1YRX gIXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=jZN+1ajKgi1G62jx4jQ0OpLK5bmZe6LvzywVjlFRUjY=; fh=OVWHRytJFaPi5Srv6FPaG+0OzUY77ept4AErdF2o8xI=; b=l53yxilYJFs5QGzQPMsSmboSX9AFbrgu6H5iX5Th4Uvc72WmhAQQFQrcUQsO7oi1Df wCnt4qen/dIgoVgwxwCvpxyhi/cQ68ocZUbt23q/mpNDSmmCGkZKxu/76eWYKl91NiHX V0dnP0VWqcpMF93/3clXtjxvOW5g6mLhspIQTLApQOvcymGtUBzBPnAUgh2LGNsufOyP 5HSps5pr6GhUEqJSKnlyjUNu38wJUdx75z6wfZHLmVlynWY62j1Dv9txQHotlHkrZLIE PIc3EiIn0/YEhQx+wDNCi7PG+lep0L8czsghdJ0mxaPGr52dX//6cYyJP7nV87G6SXiA HQ4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fxeUa2DK; spf=pass (google.com: domain of linux-kernel+bounces-24205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ds5-20020a0564021cc500b00557a6156958si1013503edb.28.2024.01.11.17.20.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 17:20:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fxeUa2DK; spf=pass (google.com: domain of linux-kernel+bounces-24205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8233B1F24B7F for ; Fri, 12 Jan 2024 01:20:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5FF6DA3F; Fri, 12 Jan 2024 01:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fxeUa2DK" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 975C61848 for ; Fri, 12 Jan 2024 01:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A88C433C7; Fri, 12 Jan 2024 01:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705022419; bh=j0+E/Eu1d1fbBIbKGo4k8aAFMXexuohOXazoNCv+rS8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fxeUa2DKTJ1j3Du+JMi7AJgR/Zhodxzf+iNDNFVmFj52QCpCkreMjcYuZe5NKc+RK j5LzeN51gm3GNAk7yPaP2bGq3PYWfQFzHUVH8pznX/NMopUAKmq2w9Fk6wAE4u6Rr0 aXWTsxTjnAmCPdOBritt40LONe2K9TJ0ihJJM3Q7UlmwxnnUlu53o91KW6MiPWnAdJ Kskrwac4YFxBk2ZYuzRYqlOdcbtQb+BlZGJPsyRW6XGsR3kQSct8U1NG7xg2HByrWn gt4tbh86eeZyMG0unl7omOhigXnPU5RPoOVgLiwu3S+DH+tBLnQOhneFr9QlPuo6C+ kmEFlEZDuvvyg== Message-ID: <6fa06b29-2828-4b99-a9d2-f96fd89c8873@kernel.org> Date: Fri, 12 Jan 2024 09:20:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] f2fs: check free sections before disable checkpoint Content-Language: en-US To: Wu Bo , Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Wu Bo References: <20231229032507.2016012-1-bo.wu@vivo.com> From: Chao Yu Autocrypt: addr=chao@kernel.org; keydata= xsFNBFYs6bUBEADJuxYGZRMvAEySns+DKVtVQRKDYcHlmj+s9is35mtlhrLyjm35FWJY099R 6DL9bp8tAzLJOMBn9RuTsu7hbRDErCCTiyXWAsFsPkpt5jgTOy90OQVyTon1i/fDz4sgGOrL 1tUfcx4m5i5EICpdSuXm0dLsC5lFB2KffLNw/ZfRuS+nNlzUm9lomLXxOgAsOpuEVps7RdYy UEC81IYCAnweojFbbK8U6u4Xuu5DNlFqRFe/MBkpOwz4Nb+caCx4GICBjybG1qLl2vcGFNkh eV2i8XEdUS8CJP2rnp0D8DM0+Js+QmAi/kNHP8jzr7CdG5tje1WIVGH6ec8g8oo7kIuFFadO kwy6FSG1kRzkt4Ui2d0z3MF5SYgA1EWQfSqhCPzrTl4rJuZ72ZVirVxQi49Ei2BI+PQhraJ+ pVXd8SnIKpn8L2A/kFMCklYUaLT8kl6Bm+HhKP9xYMtDhgZatqOiyVV6HFewfb58HyUjxpza 1C35+tplQ9klsejuJA4Fw9y4lhdiFk8y2MppskaqKg950oHiqbJcDMEOfdo3NY6/tXHFaeN1 etzLc1N3Y0pG8qS/mehcIXa3Qs2fcurIuLBa+mFiFWrdfgUkvicSYqOimsrE/Ezw9hYhAHq4 KoW4LQoKyLbrdOBJFW0bn5FWBI4Jir1kIFHNgg3POH8EZZDWbQARAQABzRlDaGFvIFl1IDxj aGFvQGtlcm5lbC5vcmc+wsF3BBMBCgAhBQJWLOm1AhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4B AheAAAoJEKTPgB1/p52Gm2MP/0zawCU6QN7TZuJ8R1yfdhYr0cholc8ZuPoGim69udQ3otet wkTNARnpuK5FG5la0BxFKPlazdgAU1pt+dTzCTS6a3/+0bXYQ5DwOeBPRWeFFklm5Frmk8sy wSTxxEty0UBMjzElczkJflmCiDfQunBpWGy9szn/LZ6jjIVK/BiR7CgwXTdlvKcCEkUlI7MD vTj/4tQ3y4Vdx+p7P53xlacTzZkP+b6D2VsjK+PsnsPpKwaiPzVFMUwjt1MYtOupK4bbDRB4 NIFSNu2HSA0cjsu8zUiiAvhd/6gajlZmV/GLJKQZp0MjHOvFS5Eb1DaRvoCf27L+BXBMH4Jq 2XIyBMm+xqDJd7BRysnImal5NnQlKnDeO4PrpFq4JM0P33EgnSOrJuAb8vm5ORS9xgRlshXh 2C0MeyQFxL6l+zolEFe2Nt2vrTFgjYLsm2vPL+oIPlE3j7ToRlmm7DcAqsa9oYMlVTTnPRL9 afNyrsocG0fvOYFCGvjfog/V56WFXvy9uH8mH5aNOg5xHB0//oG9vUyY0Rv/PrtW897ySEPh 3jFP/EDI0kKjFW3P6CfYG/X1eaw6NDfgpzjkCf2/bYm/SZLV8dL2vuLBVV+hrT1yM1FcZotP WwLEzdgdQffuQwJHovz72oH8HVHD2yvJf2hr6lH58VK4/zB/iVN4vzveOdzlzsFNBFYs6bUB EADZTCTgMHkb6bz4bt6kkvj7+LbftBt5boKACy2mdrFFMocT5zM6YuJ7Ntjazk5z3F3IzfYu 94a41kLY1H/G0Y112wggrxem6uAtUiekR9KnphsWI9lRI4a2VbbWUNRhCQA8ag7Xwe5cDIV5 qb7r7M+TaKaESRx/Y91bm0pL/MKfs/BMkYsr3wA1OX0JuEpV2YHDW8m2nFEGP6CxNma7vzw+ JRxNuyJcNi+VrLOXnLR6hZXjShrmU88XIU2yVXVbxtKWq8vlOSRuXkLh9NQOZn7mrR+Fb1EY DY1ydoR/7FKzRNt6ejI8opHN5KKFUD913kuT90wySWM7Qx9icc1rmjuUDz3VO+rl2sdd0/1h Q2VoXbPFxi6c9rLiDf8t7aHbYccst/7ouiHR/vXQty6vSUV9iEbzm+SDpHzdA8h3iPJs6rAb 0NpGhy3XKY7HOSNIeHvIbDHTUZrewD2A6ARw1VYg1vhJbqUE4qKoUL1wLmxHrk+zHUEyLHUq aDpDMZArdNKpT6Nh9ySUFzlWkHUsj7uUNxU3A6GTum2aU3Gh0CD1p8+FYlG1dGhO5boTIUsR 6ho73ZNk1bwUj/wOcqWu+ZdnQa3zbfvMI9o/kFlOu8iTGlD8sNjJK+Y/fPK3znFqoqqKmSFZ aiRALjAZH6ufspvYAJEJE9eZSX7Rtdyt30MMHQARAQABwsFfBBgBCgAJBQJWLOm1AhsMAAoJ EKTPgB1/p52GPpoP/2LOn/5KSkGHGmdjzRoQHBTdm2YV1YwgADg52/mU68Wo6viStZqcVEnX 3ALsWeETod3qeBCJ/TR2C6hnsqsALkXMFFJTX8aRi/E4WgBqNvNgAkWGsg5XKB3JUoJmQLqe CGVCT1OSQA/gTEfB8tTZAGFwlw1D3W988CiGnnRb2EEqU4pEuBoQir0sixJzFWybf0jjEi7P pODxw/NCyIf9GNRNYByUTVKnC7C51a3b1gNs10aTUmRfQuu+iM5yST5qMp4ls/yYl5ybr7N1 zSq9iuL13I35csBOn13U5NE67zEb/pCFspZ6ByU4zxChSOTdIJSm4/DEKlqQZhh3FnVHh2Ld eG/Wbc1KVLZYX1NNbXTz7gBlVYe8aGpPNffsEsfNCGsFDGth0tC32zLT+5/r43awmxSJfx2P 5aGkpdszvvyZ4hvcDfZ7U5CBItP/tWXYV0DDl8rCFmhZZw570vlx8AnTiC1v1FzrNfvtuxm3 92Qh98hAj3cMFKtEVbLKJvrc2AO+mQlS7zl1qWblEhpZnXi05S1AoT0gDW2lwe54VfT3ySon 8Klpbp5W4eEoY21tLwuNzgUMxmycfM4GaJWNCncKuMT4qGVQO9SPFs0vgUrdBUC5Pn5ZJ46X mZA0DUz0S8BJtYGI0DUC/jAKhIgy1vAx39y7sAshwu2VILa71tXJ In-Reply-To: <20231229032507.2016012-1-bo.wu@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023/12/29 11:25, Wu Bo wrote: > 'f2fs_is_checkpoint_ready()' checks free sections. If there is not > enough free sections, most f2fs operations will return -ENOSPC when > checkpoint is disabled. > > It would be better to check free sections before disable checkpoint. > > Signed-off-by: Wu Bo Reviewed-by: Chao Yu Thanks,