Received-SPF: pass (google.com: domain of linux-kernel+bounces-24226-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
IronPort-PHdr: A9a23:MoAbXxfkYngCHp0JuGWvOUH+lGM/eYqcDmcuAtIPgrZKdOGk55v9e
 RWZ7vR2h1iPVoLeuLpIiOvT5rjpQndIoY2Av3YLbIFWWlcbhN8XkQ0tDI/NCUDyIPPwKS1vN
 M9DT1RiuXq8NBsdA97wMmXbuWb69jsOAlP6PAtxKP7yH9vRht6r1uS7+LXYYh5Dg3y2ZrYhZ
 BmzpB/a49EfmpAqar5k0BbLr3BUM+hX3jZuIlSe3l7ws8yx55VktS9Xvpoc
IronPort-Data: A9a23:AyB/BK2pwf7Qx+DP3fbD5d5wkn2cJEfYwER7XKvMYLTBsI5bp2FRm
 GtNWGqCbPrcNzSmfIpyat6x8UgBv5/Um95mSAE+3Hw8FHgiRegpqji6wuYcGwvIc6UvmWo+t
 512huHodZ1yEzmE4E/3aNANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq8wIDqtYAbeORXUXV5
 bsen+WFYAX5g2ctaDpNg06+gEoHUMra6WtwUmMWPZinjHeG/1EJAZQWI72GLneQauF8Au6gS
 u/f+6qy92Xf8g1FIovNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ajs7XAMEhhXJ/0F1lqTzeJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXcG7lyX7n3XQL/pGT2c0Hqs/2LpLLU4e6
 OdBEDUcRQuErrfjqF67YrEEasULNsLnOsYUvWttiGqfBvc9SpeFSKLPjTNa9G5v3YYVQrCPP
 IxANGYHgBfoO3WjPn8UAYgineOhhVH0ciZTrxSeoq9fD237llQriOGzb4uPEjCMbd0Pj2qcl
 0/Hxki6OwszEcKm2APY1kv504cjmgu+Aur+DoaQ9fNwhlCXg24aDhwKUkGgiee2h1T4WN9FL
 UEQvC00osAa8E2tU8m4XBCipnOAlgATVsAWEOAg7gyJjK3O7G6xAmkCUy4Ec9c9tecoSjEwk
 FyEhdXkAXpoqrL9dJ6G3q2foTX3Mi8PICpZIyQFVgACpdLkpenfky7yczqqK4bs5vXdEjDry
 DfMpy8774j/R+ZSv0ln1TgrWw6Rm6U=
IronPort-HdrOrdr: A9a23:UmTQNqOmWRJgDMBcT47255DYdb4zR+YMi2TDiHoBKiC9I/b5qy
 nxppUmPEfP+UgssREb9expOMG7MBXhHO1OkPgs1NCZLUbbUQqTXc1fBOTZskfd8kHFh4pgPO
 JbAtdD4b7LfBZHZKTBkXSF+r8bqbHtntHL9ILjJjVWPH1Xgspbnn5E43OgYzZLrX59dOIE/f
 Snl616jgvlU046Ku68AX4IVfXCodrkqLLKCCRtOzcXrCO1oXeN8rDVLzi0ty1yb9pI+9gf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi+AOQw+cyjqAVcBEYfmvrTo1qOag5BIBi9
 /XuSotOMx19jf4Yny1mx3wwAPtuQxeqEMKiGXow0cLk/aJAA7SOPAxwr6xtSGprXbIiesMlZ
 6jGVjp7qa/QymwxBgVrOK4Jy2C3nDE0kbK19RjzkC2leAlGeVsRUt1xjIPLL4QWC3984wpC+
 9oEYXV4+tXa0qTazTDsnBo28HEZAV5Iv6qeDlKhiWu6UkfoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBZLfMB2BfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPJgF1oE7lp
 jNWE5R8WQyZ0XtA8uT24AjyGGGfEytGTD2js1O7ZlwvbPxALLtLC2YUVgr19Ctpv0Oa/erLc
 pb+KgmdMMLAVGebbqhhTeOKaW6AUNuJfEohg==
From: "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: "Satish Kharat (satishkh)" <satishkh@cisco.com>,
        "Sesidhar Baddela
 (sebaddel)" <sebaddel@cisco.com>,
        "James E.J. Bottomley"
	<jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "Arulprabhu Ponnusamy (arulponn)" <arulponn@cisco.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
Thread-Topic: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
Thread-Index: AQHaQ/S4wCJM6FLsDkqtdo8A4xgFVrDVcADw
Date: Fri, 12 Jan 2024 02:14:32 +0000
Message-ID:
 <SJ0PR11MB5896EF08C7E85D91B16C8531C36F2@SJ0PR11MB5896.namprd11.prod.outlook.com>
References: <5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain>
In-Reply-To: <5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?7rpJxr2l7RzrkHTjEtjSKv2gvMXoE1/M3dNfSygLy0pwC5v5gGOvIzdjRf5a?=
 =?us-ascii?Q?zC9KAKCAPGbSUjnZm7Y0XBGjfHoWh5TwMI4F/DDyCyWObrT8qfBvGzRXn+yh?=
 =?us-ascii?Q?h2zfgmiCstx/L1mhAwiFg9G1+mSHrHuv2cBu+LNsGT3PpP1lem7YXfcIOrwe?=
 =?us-ascii?Q?Cp6XIkdGsTPxxtW8/yboiOAoRAbJPZ34m7eY5cqAYJrv9BNUMLUuIdwyMxrr?=
 =?us-ascii?Q?cTLh1tIbdVQoddQR2tPM96zkOqZo/SJFfA6lYb6BfbbIqeR2/OBBVWMp8ao5?=
 =?us-ascii?Q?2Ur63SgfRebRMurebQpEosMLWN+T3djPRq9yGqANVx/XfHZVbR1+9s6WdaeJ?=
 =?us-ascii?Q?SWLQaWwD7ZaTa7oEScn6QP54mknLFPRSp4aAAIGKTnE2RxjWGOPVZd+Z+ZGO?=
 =?us-ascii?Q?tCy4UISEThtgn0mrHOpz9ulDBlP4fCDYu7tuOpks5ELes7ycRs6CZm3/99GY?=
 =?us-ascii?Q?TCOdvRiTWZ/FLxRiBD3AQJQbLHwgtjRmvbMsmRnoNaGB7HlnbYQ8lLd+lYmq?=
 =?us-ascii?Q?2gfuFPRwk+5ZvEWGhvaT7NDOC6o2ikb2hWGAYmF62nQGeZZuyydtn3X1iFxk?=
 =?us-ascii?Q?0VrefaSOIBIZnROHrKuj0IjbLHdFJDPQjAwlqN6NIIg5H2fT7/MkVc7x2lv+?=
 =?us-ascii?Q?RLMvd/JR8A4Tk5bujoU9+rUA4MOjsi41FZpEtrEsZLNcMzASciM54dZV2kda?=
 =?us-ascii?Q?oPZ8hgGANJQUa2iLObWnndBMNErACOU+oWg8ISKA2v2hpSbRndNV12cPUq/+?=
 =?us-ascii?Q?JvsYzx6orR1HWauLlnEJVvyjrd7h7MVSDmuQOzw3YGTALqTa5fZl4IebQLw4?=
 =?us-ascii?Q?tGKT+UEQ02nukfiUTrevnX6sj/bb9ZaMc08N9Rq3+6DxEozNERpjpXplQiHa?=
 =?us-ascii?Q?zDVCEVK3E4AGYEkhPwhKOnqtPuUQHMOdQJNtlpCJ8H/77KHTwe7C2jpAplqV?=
 =?us-ascii?Q?uYWlhGfjDpRdurk7XBJYbMtP4ZdSXjLr38HU6VPiuLBiqgaRLnRfu5vMNnvQ?=
 =?us-ascii?Q?lLoZyfyDeT26WWqFXm5zDLK5E4VvY/yMqN6lNe/tiwrYipc+a/s+Z2QtrpRw?=
 =?us-ascii?Q?JUQxWkdBMkYBSO6hebSKceJsjw7VVtBGnqeA/w+cia6R5J1XRYBVULNrAsTS?=
 =?us-ascii?Q?lsHXIZ+ZMVPz7bGrf8kfyPYVlj7XvgqbJWEL63f0MKMk/KDJVTI53h6xg4NA?=
 =?us-ascii?Q?Yx3hR+wVgOjtv7kiEtFbmyZGrZ/9b5F1FIWELiEoO+Lo+i9g603qa0VzLT1G?=
 =?us-ascii?Q?TCLhaRXADtaxu2f91CcMjrQhuFXj2+LtSzarv2tO3wVKOzMfEd2s3/mTFGFg?=
 =?us-ascii?Q?u6sImidxcc/cofuB1/fXS+T6a4zz4kRNfMSFk7SmTAbNuYMIgBM+3MMLgWDJ?=
 =?us-ascii?Q?Meb3K4LVhDt1fK4IqAG9eaMuna6AU9FxkZfujZjoNF2D+ql+ghac4M6YyVED?=
 =?us-ascii?Q?3C0FN7t/s3+1P7HCahoAXkMJsanUNvv3Tqhtf7qH4W8PMeSuFzfBikG9sYoj?=
 =?us-ascii?Q?qYih7Aqw115+86yyA8k7IAEiZ/L07OUp+dw09zvTE0X6pMf+xJE2iY3yHQGc?=
 =?us-ascii?Q?hopBMB08sZ6jEW9N5qULpFu7LrWyajINpHok9i3x6nPcnWEu+l1MfjdVQPw1?=
 =?us-ascii?Q?0cy4Iiuz//rIP7mAwtwpzTw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: cisco.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5896.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5d76b9d-c6a7-49dd-62f7-08dc1314375f
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2024 02:14:32.8424
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TCawmbra7/4Z+mO0iL4NC0Ttavu7rcVsYaQmrdhgguFR9LoyMCq9MmbkAEdxzPNVJGujmnh+DbbfMndZ1Xq0GA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7933
X-Outbound-SMTP-Client: 173.37.147.229, alln-opgw-1.cisco.com
X-Outbound-Node: rcdn-core-3.cisco.com

On Wednesday, January 10, 2024 10:42 AM, Dan Carpenter <dan.carpenter@linar=
o.org> wrote:
>
> Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before
> returning.
>
> Fixes: c81df08cd294 ("scsi: fnic: Add support for multiqueue (MQ) in fnic=
 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.=
c
> index 4d6db4509e75..8d7fc5284293 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -546,6 +546,7 @@ int fnic_queuecommand(struct Scsi_Host *shost, struct=
 scsi_cmnd *sc)
> if (fnic->sw_copy_wq[hwq].io_req_table[blk_mq_unique_tag_to_tag(mqtag)] !=
=3D NULL) {
> WARN(1, "fnic<%d>: %s: hwq: %d tag 0x%x already exists\n",
> fnic->fnic_num, __func__, hwq, blk_mq_unique_tag_to_tag(mqtag));
> +             spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
> return SCSI_MLQUEUE_HOST_BUSY;
> }
>
> --
> 2.42.0
>
>

Thanks for your change, Dan.
Looks good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>

Regards,
Karan