Received-SPF: pass (google.com: domain of linux-kernel+bounces-24229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
        Pavel Machek
 <pavel@ucw.cz>, bvanassche@acm.org, hch@lst.de,
        hare@suse.de, linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net,
        jslaby@suse.cz
Subject: Re: scsi_get_lba breakage in 5.10 -- Re: Linux 5.10.206
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1il3z5m4y.fsf@ca-mkp.ca.oracle.com>
References: <2024010527-revision-ended-aea2@gregkh>
	<ZZ042FejzwMM5vDW@duo.ucw.cz> <yq1jzoi7hrt.fsf@ca-mkp.ca.oracle.com>
	<2024011047-clench-scheme-1f46@gregkh>
	<2024011121-unfailing-backroom-14e6@gregkh>
Date: Thu, 11 Jan 2024 21:21:00 -0500
In-Reply-To: <2024011121-unfailing-backroom-14e6@gregkh> (Greg Kroah-Hartman's
	message of "Thu, 11 Jan 2024 10:45:38 +0100")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?3KawuotghE91fqTlZlbfX49D7MsH/Z5o35Cf/YOVOuBA+c5P62REENVjeiNf?=
 =?us-ascii?Q?rQDU1UT3xNnCM4enxfmoKHD+q/3PSx5Fhn2idUrKOtNUZMOstCMLX1yIE7io?=
 =?us-ascii?Q?9459XGBa+h43Jvi5evVK1FgckeFOhiz1UMnMicI/8orNs2zrWoqPekC+ia92?=
 =?us-ascii?Q?fvGDbVT0lb5PkReYRd8ddPSN5QWXJMOaoPJonnJr6pvlB0xcdh+R9wdRPSnU?=
 =?us-ascii?Q?R8BySj+2WMAsP/4UmZcjDXxxmcJ3MMOHfDi44vk6gotQOTB2cm2Rl4wLphMt?=
 =?us-ascii?Q?MLT4sOwj5Ing3Fppj9IycSi9X/RV9otg9mm65+aDHeBqKxz59LNtAgEpT9GF?=
 =?us-ascii?Q?a6vIJ7seCdvimG6rA5BydgHppWPUden3YiO6FQo+DHCVbvfa6EScxAfhx3kv?=
 =?us-ascii?Q?EMARXCWnSR+0RWU3kD7qtW2Zk/VM+ZA2/1+OyZS93FLD+cRENr0Lf7fHtmnI?=
 =?us-ascii?Q?suNNSr3dPsCWYhrKLWmz4yayVRXFsEhm6rvSx0/fq6DXNjmGlNvddf8nqAo3?=
 =?us-ascii?Q?1o5snCJHfQR7U9cLrQML7Xg1eIrafwqH3p3S38OxU+4cJRv12FIS7Bt6IR/z?=
 =?us-ascii?Q?AOVo2r0svMLKzAaHgtNUdoCCEpHAl2/+PVx/hlT2D3Wa80wrG4nKnkka7rlW?=
 =?us-ascii?Q?PLbiEQUnoLu+Ou5qF7oAJJZ1m+1p01yde4HI9l5xvKUSooHXYoPFfeoRvH/5?=
 =?us-ascii?Q?Pdzx2YvoyfcjBHT4IhosuEAPT31uE6IYcNooSn8oTmqgz9nKYC4UZskfV4Hk?=
 =?us-ascii?Q?i3pJP7wHJeB02GF5cWWkVV3Ilz3vtb9JKu5mpDagLDzTBORJ0G+rhdruU9s+?=
 =?us-ascii?Q?8BOThQnb41XaTsFzlWixlrn0NWGFkOuKpy76xGBOiShKBnUOFWAVkWChGFRI?=
 =?us-ascii?Q?ceChCIaVOjAWJtIRON7xh3KBWhKP+VBOKPyfUM9sAU+sK1sO4pLPPkQVp9d2?=
 =?us-ascii?Q?kIlBMC+pGMLvZsb4yTa1ZIQQ8fDZmZaY4q4H07yx+AS+P6xmLASQoWz8UiAd?=
 =?us-ascii?Q?0yivDEX6P13OmLDQd5cFBc3oJI/a9MegDZKzZeZNHCx9nJLTxTbvhR8Pdg+G?=
 =?us-ascii?Q?a3TZTj9Pay3vaYb8wrMhVUNxtmNCaZB0dFkgwZgBSRx3PKMxKq+uf5X3ky77?=
 =?us-ascii?Q?Grf+q6vvUe3SJT43vvkAb0GR5K8DQf/+aroS0tof4Eg4iGrVHTms/lomeXKK?=
 =?us-ascii?Q?7E/+CXTgIYvyZv36l/Q9HM8+SH1h7HtmkoRfy3ldlS4fPwTs3qq5S4oUJCLj?=
 =?us-ascii?Q?1MN0CIZgYG4q+SJpuYR46EHukrBfvdd2LCDOPh+BRheJSz7gHjMAuQxKTnX3?=
 =?us-ascii?Q?tFaCcfZ/gGCUdCsQjXO8AuKzGJ+114DX0i7DAfwKcfthHM2H44DIMbSUwRqy?=
 =?us-ascii?Q?RYTScaSjci84/3qKgkrz5zP3F4j4nZBr/3vqnWP43/gU916GZkUIRkev4pk9?=
 =?us-ascii?Q?LrzRplz/LIs+wy86ClhxxJOvWJYkivVbU1e/2PXDAPwF3ESfGa9KOZFEb81O?=
 =?us-ascii?Q?/BT7qnN++nJg3nd3so/WVhwoJqMTepOXZTAijhqKgIRQ3fLT/GJf4xQYSWEz?=
 =?us-ascii?Q?nw/2T50rUQaIy3GGKXlQtv38mtLDENMpoNNOjJEu0wGo+k5WsfZO188l6SN+?=
 =?us-ascii?Q?HA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Vywfcy1lTpPgz95M7gQbUV5F79WE92Tnzq92r/VShSfezt8UQ/ClqT9fsfzw6jGPp0QiYr6UA+ZNSvZiczBxftzWj6qNauPIfC/lXYpcH/mzFcAQgvO3mB8T3QgObojzT3lQAvxQvlWzpumJfaGnj9MZ7+7fU+rgbHWsCLF9EkzJ8theKj397rlgXzQgKTalRDRiPMwmcpqDcfOlKsoRUSfoqQ/DTgVvH564DE6Bh5luLZRyddTHQ54m/voNdnQeXn6XFBNvUskHsWPExjei7hzBj/1OdYket0EU5tqQSZ5R49tmXtHuojDEwl5Vi8u3qOiMe5+vnLaAkWoOom0Q+4OTD9iC0vcld+Sob8tVSFiIKKQhoHx9aoSE7EdsiPzcuFSMpI6w5uZYwjSNT0dhrGdM4MAt14MpZ/l558GMWtVMu6OaVzwvJqb1deI8ZfR369chMFOMZPxM0dsH37z5d5CvfJfZvVXtCq4+tfxLOEgnYRtKqm7HRtZ4dcwbXmcGiwUnag1IaC51GQ77oW9ZZRuCdp+GPVRroFOgykaq4PISiQl4aDl2adDZO9gKORyzGcRlqUUQJjsPCLGBc3hYZZy1sH3e9HrbJzVvR/R1vvE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4b6e389-d9c6-42f1-bc42-08dc13151f9a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 02:21:02.7580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OsZhnBFgOhRQs3u9IbnIoLciPPBOXU17YmYAI7Ptb7JAguA9OT8Rd3cIA7v2Vynila/9ad5gYuxArMHFmTRSkgiyfZnAQyKGgpE21b6il5o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4969
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-11_15,2024-01-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=968 phishscore=0 mlxscore=0
 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401120014
X-Proofpoint-GUID: yWpU9yXzRgewfb2SKcf17dezgBpQPBV8
X-Proofpoint-ORIG-GUID: yWpU9yXzRgewfb2SKcf17dezgBpQPBV8


Greg,

>> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>> index 0c4bc42b55c2..3d3d139127ee 100644
>> --- a/drivers/scsi/scsi_error.c
>> +++ b/drivers/scsi/scsi_error.c
>> @@ -1069,6 +1069,7 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
>>  
>>  	scsi_log_send(scmd);
>>  	scmd->scsi_done = scsi_eh_done;
>> +	scmd->flags |= SCMD_LAST;
>>  
>>  	/*
>>  	 * Lock sdev->state_mutex to avoid that scsi_device_quiesce() can
>> @@ -2361,6 +2362,7 @@ scsi_ioctl_reset(struct scsi_device *dev, int __user *arg)
>>  	scsi_init_command(dev, scmd);
>>  	scmd->request = rq;
>>  	scmd->cmnd = scsi_req(rq)->cmd;
>> +	scmd->flags |= SCMD_LAST;
>>  
>>  	scmd->scsi_done		= scsi_reset_provider_done_command;
>>  	memset(&scmd->sdb, 0, sizeof(scmd->sdb));
>
> Ok, I have now done this and will push out a -rc1 with these changes in
> it.

Yeah, no need to bring in all those PI updates with associated driver
changes just for this.

-- 
Martin K. Petersen	Oracle Linux Engineering