Received-SPF: pass (google.com: domain of linux-kernel+bounces-24232-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Hannes Reinecke <hare@suse.de>,
        "James E.J. Bottomley"
 <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Justin Stitt <justinstitt@google.com>,
        Kees Cook
 <keescook@chromium.org>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
        kernel-janitors@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH] scsi: fcoe: Fix unsigned comparison with zero in
 store_ctlr_mode()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1cyu75lss.fsf@ca-mkp.ca.oracle.com>
References: <20240102085245.600570-1-harshit.m.mogalapalli@oracle.com>
Date: Thu, 11 Jan 2024 21:27:24 -0500
In-Reply-To: <20240102085245.600570-1-harshit.m.mogalapalli@oracle.com>
	(Harshit Mogalapalli's message of "Tue, 2 Jan 2024 00:52:45 -0800")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?gniT8lTMhYZTWCEgrw7E4CjE2W5QV/+wVF9hygeczcuhan2Pr4SlbKptbqu1?=
 =?us-ascii?Q?KEblJjXVl4Jre6YhA6MDUX7vLBVQRVV4bfT8CnPnZmaf0IGguVLEM0RinfuS?=
 =?us-ascii?Q?fVi3xstVBiM/6zePwdq0shDDAJ3RSlO3UVuBwGzERFAcWT7yYyiOlFCX8WjB?=
 =?us-ascii?Q?yRe2mxojNfkL5imjd4F9Zo6/clgVLHgEmY/Jq5p21UIkubnvNrw0A3peqBG1?=
 =?us-ascii?Q?uOBjMSUcocyWGtrKBNzoiL3mdUR06EcnGK49ZEDDRq0lSlvUPEFiIKPlj3J9?=
 =?us-ascii?Q?r+bN1q2YUy3jOoz+PbQ07TBixDehREQLR12mzWp4c3ng/loqFwxHafGqk+DI?=
 =?us-ascii?Q?QbJb491edUT/D6efpxu8dCPv9TxLkAZ0eYoXIBtYZ17EFf8XmKr9+D6FF8YN?=
 =?us-ascii?Q?+KTQG/wdmOkg/DmxbkSZbkzzM1fXkiSrIIWuHwCGUlRlP8ggJnIMoC+u4IZV?=
 =?us-ascii?Q?Sz1Vl/IWsX7XuVmU79dURSgRjRy+KFIJckOnPtaqcSP1oZrhWyH9j/XQW2M9?=
 =?us-ascii?Q?z8dAion61ccqm2bTjkbYRFFKabfS2zkTQCFPqo1KrJgfPchciXBgNvHIA+oM?=
 =?us-ascii?Q?41PYNr0l3Ni0pzQLdlxB5j38FpSnC4JJOSGy4k5kVxNq1MMPpX+68uZWmgjn?=
 =?us-ascii?Q?VFjjQk7wKQR77ni6Wd5PlrKdNAGkPi1cHDJ9H3u/UCADCBhTkiZ8jwbE3E5c?=
 =?us-ascii?Q?BauyYnRfYCZ7q1tnU1sTWLvXiRWoCtqOrZe9wO2EM8DI8geFCGOwwVJ63MOI?=
 =?us-ascii?Q?WvcbkBXluBSxgaPU2tvnh9EJIU8L8OsxM1x8vnWMqjC658M1Ktk+F0WGB9Sp?=
 =?us-ascii?Q?er9JW5+xnXIkk4ZSNiX/pVmyX7AC9uk4l2vHa3Hiuq85DsYqDWm0iRujy46n?=
 =?us-ascii?Q?d3YDXki9pqsxhj+TDdlw1HM6y0vyGJF1I8tSPAgI/0cega63r97dgrcWGAQp?=
 =?us-ascii?Q?uOwAf8QAqxvXP5SXdj28g8roZVNCn6qmyWKcxqkZeDP8tr5ME9sM6NthFXkt?=
 =?us-ascii?Q?m8ucnoff4ltl0DszGj0T+f+M0s4xundAF8LKJCnjcCnp7BZr4gty5EXfseJC?=
 =?us-ascii?Q?KTU9MB404DON/BY0eXZyk/ahkbjGl2/XzqVNYp0bFoWzwrPcdsdNJdzT4jxg?=
 =?us-ascii?Q?Zq0EYtKez0U/ZfXrGUfGvWoTzqPeH5VnT/uwZf4+726zJjjwycDVDwR75sYK?=
 =?us-ascii?Q?oZgVUJ+kNyigvzWp33EDx0V0c4WsoTivt79Xst6e8hUjKz6K36Mf4l/kAuqV?=
 =?us-ascii?Q?rYJ2f5esJ3l39B1NV705ljOppQCciNeQ6wFg82yW0IRCP47u0+DtwurcsmMx?=
 =?us-ascii?Q?CeUFis2GXeYFL5vx4hEx2sIJ9F4PNa6zropGgtrZGUNcxDQT/aPBeYqWIy73?=
 =?us-ascii?Q?ub7nYPL/439qeXdG2kLvb4dNyRC1w889fTSU21sLkzyOM98T/sgYK1EL1AGb?=
 =?us-ascii?Q?VqEa1VebKnzFBXT35Xvh+NaLs2hT3ZcPTorQI44GITAMSd86M74IqYW9o7kt?=
 =?us-ascii?Q?HifeY1XxRDj7I2OxuGFhJ+7M4Fq+4tsXbsONxovxevoJkp4CeGXzr5fZ/aBm?=
 =?us-ascii?Q?YIW4ywz7zZrlSwrdwXxKY+I6WzKqwBpJIHhKyomMV66yG7xwIxQp9emDkvQA?=
 =?us-ascii?Q?YA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	gusL5YWIPrN6wCLP6dB+BnHxdYylt1zQ73BTXCSaKp4RUba+AwV1biz7G7KYw/jrjZmXGq9Fl3cpDqNI2SkQh36Czd7BSHdoVvrv9AQi74kStzMIse5e9tkSiTKKJJsfUS9FrH/4KYurnC1VKRawMl0/f3sDSxo231PJ1CodZ1bdhvLFTm4I9Pgop/Ki76wxXiXkx2L3vIPtiOVnRdFwD/P4FrZ4RMv67Za7Shf5rTLneTNUueNdlrjqP41N1r+EM34ytthhuJ1Ou0oKfU95t3K0pQbR9HDgjwgd6RxhbiXPbcN8GBE4MkPAkBGfd4xmCExYRvY9yQxuVWTyYSS7gphpODk12mIX2xwVkER9P+iHFZlfedibKbpW7ayK7/KnX/+zzjI0v4QD8I2XIybjdHYj5kiNFAlT8IAEMq7O8/16WwYj6aTqOGEJ/yNqbzhPQyT+uQwzlc8FmwnMzUlgG4+tqICyeddguvHIpbjHvpp7cXd/J4TUX0JffzzF61Y1u2G3k9zQskNtPcO5ujt9L7YDAuxClbYxzsgKR7ZgN1Tam4PHqsdPyudFoq4JMsHgFOJvf2EMpOgV/EeLCqtM8jX0COayXKEcaBS2eaB2IAw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95a56f4b-b25a-4ab4-1fe9-08dc1316045f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 02:27:26.4375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4MAlF/2ijGC4zSgnbLl7CRMMuRpFRWQKpjCz+V1Zp02ncschNxecfoay5DvcnWTt7UKvEcAFFJyIrtiX+8RnSh8Ylrcb93nz4nT8OXr2E9w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7641
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-11_15,2024-01-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0
 mlxlogscore=677 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401120015
X-Proofpoint-GUID: H02pjjMoJ7a42be1zUR92CEybUiffgww
X-Proofpoint-ORIG-GUID: H02pjjMoJ7a42be1zUR92CEybUiffgww


Harshit,

> ctlr->mode is of unsigned type, it is never less than zero.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering