Received-SPF: pass (google.com: domain of linux-kernel+bounces-24241-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Karan Tilak Kumar <kartilak@cisco.com>,
        Satish Kharat
 <satishkh@cisco.com>,
        Sesidhar Baddela <sebaddel@cisco.com>,
        "James E.J.
 Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen"
 <martin.petersen@oracle.com>,
        Arulprabhu Ponnusamy <arulponn@cisco.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq134v35ldu.fsf@ca-mkp.ca.oracle.com>
References: <5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain>
Date: Thu, 11 Jan 2024 21:35:49 -0500
In-Reply-To: <5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain> (Dan
	Carpenter's message of "Wed, 10 Jan 2024 21:41:55 +0300")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?RBAZN/xxNGlgW5maapuicoSNN6HbLFZRGHQKE8VnLmRHgik2Dul2d3O9sUQZ?=
 =?us-ascii?Q?bTHWxFMUgFQzgm+cyhNOwbOeDpDAVNRG4nFiTnR9L0di0bL2yrTVaBvkyS5Y?=
 =?us-ascii?Q?dpGu40xYkp8tyNFaWmJWBCz5i1dg7gc1LYUE1Xa4CeDZOE92N1edPFaVvdEn?=
 =?us-ascii?Q?gEkD1mqZ874JYvVjpbB483giQ8JFPZ3fNunE82UujPeA2TgUSK6qyfv2Bqth?=
 =?us-ascii?Q?bTsgbSMJq6tDVkfBVhzSc7JmSZg+vJhaBM/0SDFJb7+yAQfOwgCFU1Fqk5Y4?=
 =?us-ascii?Q?W+sRqQOpzcHnERYqg/QI+9hiRgUs8+b60h5T7svKBnDEEmJaD7Zq6OicDLZh?=
 =?us-ascii?Q?WHdBJQ7dFT/RGO5xWCK82XJkR8FAwmwHtK9HQOlOhqfqrqpdE1/C9jsTi7aL?=
 =?us-ascii?Q?62of6n4s9uePkycL77UMRSUGiBTItDDvkfWhyxMqKxMKGyDf1EWtKMIkTj5F?=
 =?us-ascii?Q?u8LlOeDWg/J/hnE1Z2pv9AH+1kWqCHpOXC0JeuX4NY7ToN/F/qsho/EjWCn3?=
 =?us-ascii?Q?RyiOSGu5myqPOy3mvGjrZjVbGhz8iin8Fl563pniEUYO/xuEqlM1TY/9btga?=
 =?us-ascii?Q?4ZCqCMmQKI8auCq/LBomRYKT2odVsvoxaXI8OMjnfzq5uj2Lrf0mYWlh65OV?=
 =?us-ascii?Q?NhZfmhFxBWuOeiAVddMiIIPsHHyw3F4Nrh94Yx+7cAglwuQKEQK4ixq52dI0?=
 =?us-ascii?Q?CyJEKYg4+KhGAzmfGa1NACZbjDMnctHCzVr9UxaQ4keCUzIzyerLikdM1dpr?=
 =?us-ascii?Q?sb+8ypo8VTAoV3PqPs/ZrfBWn5N1Np9RhZMPi+9FZbfFXWkJYnbdpH+rdicL?=
 =?us-ascii?Q?xFZ+OfweLpY+APVYFU8NTb4ARb6OEJrMTb2Un5p7lYgPh8z+dys0w+rpPdYs?=
 =?us-ascii?Q?Aa0k8KbhG6xkk21MdXl+UngWGTY+NGE7aD9FcJCwy7n9z5Vf+Z7Bq+Aoc207?=
 =?us-ascii?Q?zWL7+m21CXPfbmS84LstI9+5P+Hvn4cmEJBmhVjtauaY2etfs2nARx0YhRKv?=
 =?us-ascii?Q?elKNd4xnYy8ehr1znQs9QCj1o7CP1X2Qh3smbjKRL+afOP64Ihst0MalUCQN?=
 =?us-ascii?Q?JfKIjtdhXbWTCIvzXZqCi82hevqydSGDtO9Fx/W60JOv+lvIJglqTQTYIY91?=
 =?us-ascii?Q?/oMYIMAh3j92y4cTsjbnsK+XHKCs3lhR0udRiifLgBp2RneGPu28XGurXPvL?=
 =?us-ascii?Q?RmPzMUIU1UbafnI7LWRR+U8V9lKDgJfpKI6AlY6q2ZvvHWSNXEK4Mg3b8W4M?=
 =?us-ascii?Q?J3YwuEEFVwvLTDWAaYoJw93I6m7J1aBPPN0anMSi5in+axMxE2CqrYKkMko8?=
 =?us-ascii?Q?Y3Q+oLv+wdyhxOB9jNLuwuPks7WSVVo+cUUzlazlAtwNHFxG+0Hu51zeAAoz?=
 =?us-ascii?Q?7e9Fo8YpXQODtPKrujB/3QoxIh+nYJ4V7g48wA4h0D40HHNUqMeqDHFekAZT?=
 =?us-ascii?Q?R0JvnijdH443TZsgTmRPbtGQgxk6h+OSJdNrSHDo/xzNtxaHtboLsOwDQpHQ?=
 =?us-ascii?Q?aXk4MAQ4yxe/VU8K84ghhekfUwt3ziEDLkrb+aIxq81nRRJTlYhebhGto1R7?=
 =?us-ascii?Q?+r7GLyzVrZRiyIjDi1sjhNGg/P/c6P3tjrNctBPnGgTH7YV3SNWl2mh5eIrf?=
 =?us-ascii?Q?/g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	gwZCcAHRKH2ZFfhSHtqA7TPa3Sw36/vVrTT9dJKCJBibLaDHAExW40TBxONLBIa/7KAe+85rqCHcrflkhYFurUJ4RX+pOPEdOEW58M830nUC5zJgF9/wo0v06TCcuNdw8u495ruF7veNjL4ftCGWiSELZuojCP+n2/1Im4YsrwDZ4RMXHbHi5OzxLHvdul6CR3k9nLmO3dCZYyZM/8DfuKnejcQkCdNTtcURTKEmW+jnypJnP4qxzvh1GoodeW/KtvWgBxSmKJL3FmTbromxLK0e5JmJY4wAxsYpUM2n0zmxfczIXRQUXQ7bbxn512mEzpkJyfpkJ96GcRXZnZ+jRF1mN0EDpJCqSXkJegKAKhRjMC4xlLv0pomwY3xk+7k0yeiw5i9/062z9t3rmLpmhFFZjCQ46pc4GqmjqUi9RO34wZ+G3UTzJIFptgElukGbK7S48dHHj1givXjk9qvv9d0VhQNxaQEZ5jf8Lg01Gpn4R/8GxkTGPv5Yn6swus2Jlzn8GhftFIxTVltHjRdREnvRiQIbRt+2nOwzswbRuh0/aJnwoMBcY0iwLX7fmJQlP1o+nk2veKqRoJz6kpLasweqHKYdWTWlL1dlLUPh8Rg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c78db4a1-4624-44f2-cdfb-08dc13173274
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 02:35:53.2488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0r1naVlhsWxpdnCMz3wqyhF0QAY/ROWe9U5Nk0rTEfLKVAGUoSaky3C4c2Mc5Ok+lmekADvZOl8btFqNA49y80KaqbXTmi4WcNO51f8ZXzY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7641
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-11_15,2024-01-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 mlxlogscore=747 adultscore=0 spamscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401120016
X-Proofpoint-GUID: CyCPYKWXW25OXwF3sk_0WPoDErhEInfC
X-Proofpoint-ORIG-GUID: CyCPYKWXW25OXwF3sk_0WPoDErhEInfC


Dan,

> Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before
> returning.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering