Received-SPF: pass (google.com: domain of linux-kernel+bounces-24245-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 12 Jan 2024 13:46:22 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Dan Carpenter" <dan.carpenter@linaro.org>, "Naresh Kamboju"
 <naresh.kamboju@linaro.org>, "Uladzislau Rezki" <urezki@gmail.com>,
 linux-next <linux-next@vger.kernel.org>, "open list"
 <linux-kernel@vger.kernel.org>, "Linux Regressions"
 <regressions@lists.linux.dev>, clang-built-linux <llvm@lists.linux.dev>,
 lkft-triage@lists.linaro.org, "Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: mm/vmalloc.c:4691:25: error: variable 'addr' is uninitialized
 when used here [-Werror,-Wuninitialized]
Message-ID: <20240112134556.1c73c072@oak>
In-Reply-To: <bb175a67-462b-41a7-804a-ec990291a00e@app.fastmail.com>
References: <CA+G9fYvDNksfKNvtfERaBa9t2MJNucfD_s3LgKGw_z2otW+nyw@mail.gmail.com>
	<628bf675-77fc-4ccc-be2f-9c3ec8a7b0b8@moroto.mountain>
	<908325ed-08af-4b0c-926e-da9afba25772@app.fastmail.com>
	<bb175a67-462b-41a7-804a-ec990291a00e@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/FXcs1LWAtjjuljVrt8TKt6X";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/FXcs1LWAtjjuljVrt8TKt6X
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Thu, 11 Jan 2024 17:37:12 +0100 "Arnd Bergmann" <arnd@arndb.de> wrote:
>
> On Thu, Jan 11, 2024, at 13:55, Arnd Bergmann wrote:
> > On Thu, Jan 11, 2024, at 12:16, Dan Carpenter wrote: =20
> >> On Thu, Jan 11, 2024 at 04:23:09PM +0530, Naresh Kamboju wrote: =20
> >>> Following build failures noticed on i386 and x86 with clang builds on=
 the
> >>> Linux next-20240111 tag.
> >>>=20
> >>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >>>=20
> >>> Build error:
> >>> ----------
> >>> mm/vmalloc.c:4691:25: error: variable 'addr' is uninitialized when
> >>> used here [-Werror,-Wuninitialized]
> >>>  4691 |                 va =3D __find_vmap_area(addr, &vn->busy.root);
> >>>       |                                       ^~~~
> >>> mm/vmalloc.c:4684:20: note: initialize the variable 'addr' to silence
> >>> this warning
> >>>  4684 |         unsigned long addr;
> >>>       |                           ^
> >>>       |                            =3D 0
> >>> 1 error generated. =20
> >>
> >> We turned off uninitialized variable warnings for GCC a long time ago.=
.
> >> :/ I don't know if we'll be able to re-enable it in a -Werror world
> >> although Clang seems to be managing alright so perhaps there is hope. =
=20
> >
> > The problem with gcc's warning is that it is non-deterministic and
> > in recent versions actually got more false-positives even without
> > -Os or -fsanitize=3D. Clang does not catch all that gcc does because
> > it doesn't track state across inline functions, but at least its
> > output is always the same regardless of optimization and other
> > options.
> >
> > At least this particular one is an obvious bug and easily gets
> > caught by lkft and lkp even if gcc's -Wuninitilized doesn't
> > flag it. =20
>=20
> As it turns out, gcc did find this one in the default -Wuninitialized
> regardless of -Wmaybe-uninitialized:
>=20
> mm/vmalloc.c: In function 'vmalloc_dump_obj':
> mm/vmalloc.c:4691:22: error: 'addr' is used uninitialized [-Werror=3Dunin=
itialized]
>  4691 |                 va =3D __find_vmap_area(addr, &vn->busy.root);
>       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> mm/vmalloc.c:4684:23: note: 'addr' was declared here
>  4684 |         unsigned long addr;
>       |                       ^~~~
>=20
> and I see that Uladzislau Rezki already sent a fix, which
> is the same that I tried out in my randconfig tree:
> https://lore.kernel.org/lkml/ZaARXdbigD1hWuOS@pc638.lan/

I have applied that to linux-next today.

--=20
Cheers,
Stephen Rothwell

--Sig_/FXcs1LWAtjjuljVrt8TKt6X
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWgp/4ACgkQAVBC80lX
0GyUgQf7BqMWgH6cRs1tGNAs4BKWtftlLyJyZxCjYclzY9kjUIECSS6YKmZqH13Q
XPy97i7GodFZJWaOwgf0RGtGB45wBjK/odZHpxLGmPVddDW3Lw4b+hoz/VnPzUyx
3UcHxWZrX2sjM7MHASXOmNlRvTr7BYVDTUFIojzdOFpELAaDHgIp+25i3NT/s7b9
xuE4cywwHA7i49iKZHBCPahxT9wcIaREwKMcClWM824G0oTEZ9hFjkTlOUy7EGfV
vxgUIvc4KBRGUXq+ghdfru/SDnFXSjVxQzBF/Y/+u6CbLJpXsl4/zAmHH01c39q4
Tf4CfWS8RbJHiEfFwPeSAw5ayu+f/w==
=YCNG
-----END PGP SIGNATURE-----

--Sig_/FXcs1LWAtjjuljVrt8TKt6X--