Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2099705rdd; Thu, 11 Jan 2024 21:48:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6FK+9oi8vMLO5dqccekmvii5W9PDw2EZ7UtVxzLhk0quuoX/8trc/F0LVaDqM5shvo6oS X-Received: by 2002:aa7:d6cf:0:b0:558:c19b:38dd with SMTP id x15-20020aa7d6cf000000b00558c19b38ddmr595440edr.22.1705038500947; Thu, 11 Jan 2024 21:48:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705038500; cv=none; d=google.com; s=arc-20160816; b=W3slYAgpWC/0qqrfzcY6+AY/bighQ4WrVhGka9AkzVo0ts5tU00N+K4ZyEzGnFBREl J9d2W1kNHddTqnqPnw6uhYgYqNVKJRyfcAviRWFOV6Kp9F0UHMx+JRcisfNlESjpFUNK HE+OWKIk4YFQO+CV08PyGfsVOFgZcBlpOXCqMgoHF3+VkKuhzevCmUgSwVwgf5Y3c74i vnJ4Jv52VFWr0XLYwNMuBP6IlhWwZj8BbPrHn2vlk9RWfBCQx3Dtm9qikV29LHPa7uWN /yD08QJ+a/Y8TGjAQDQTJFwD3Mf2Gr1elicGR4FxVPPS0fMQIV63CquchXeFq0wUqLTP Vcxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=P7BoQkKVZMgf6vnmP1aQ9LNyV+OuN5zAeIwFDZGSshE=; fh=Y4Ekuch2R1SBUyr//CrvR6PJaZvlWLg7AMl6wNQphpA=; b=SgH1ZdzNxjGzkF2xiTTmYMYsCK8nlasEgwWWnmPqA0D3FBRsTnC28Ff96CbiymCawJ 6q38U7vvaIoUMKaUEgq8Lofp7rdUxHy6Bag+CbrP+0CXEE9ME6g8uimaL3ZZLNAcea2r Fl3lrrz17++mlcKBeZjbQH7We53yZljmKCWAQNYx8GYmVahUkti2kAT75ZTZh4pfN3dC j8e+mUZ0qXgSRVoZFY9sSP35Xff+w6DVeoFfbs3Xmv28d5G1h1bZWVwCsL0sdRG0F1Xe t9JSt2slhqFovAYOzHuZP9TVGjyj5H0A+Q0AvOKWtBLytpcnMiDVs3hl6Tei+z9/M0QI rIJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HIzrxhlC; spf=pass (google.com: domain of linux-kernel+bounces-24323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24323-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id bo26-20020a0564020b3a00b0054cd723d668si1116714edb.655.2024.01.11.21.48.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 21:48:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=HIzrxhlC; spf=pass (google.com: domain of linux-kernel+bounces-24323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24323-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AD7EA1F25529 for ; Fri, 12 Jan 2024 05:48:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C23085B5DB; Fri, 12 Jan 2024 05:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HIzrxhlC" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5D8CF4F7 for ; Fri, 12 Jan 2024 05:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P7BoQkKVZMgf6vnmP1aQ9LNyV+OuN5zAeIwFDZGSshE=; b=HIzrxhlC3lQeP8d0vel1OTHYYS H9ExqFhsFjfNhDSzJCRwzNhJB9AZaP1Jro1YhYIlFkxBrAafxGA/RRuViLWdQ019rXzxfSWCQ7Mjw VCKFwpcJI/fx+pcv4Uce59rr08TsSJcH1QYtXVmHbObokLqnRRTuvU7Yr6b5H7+D46soliAsMUWFm AkOUfscdOwyElzbDGkcNi6nIIcJkmwhk7cgpLlgwOYTFDjHLD2mMEMUbgOKo/FIEXJoNlPJTjZNFU itggmrSDxrPXQaugbmylsV1mirs3SCETYWB+38PZ0O6R+SzTecCKxjl+MfbGxf5/RIZsZHbwYZNwS CSf0MHsQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rOAOn-001yLf-2L; Fri, 12 Jan 2024 05:48:09 +0000 Date: Thu, 11 Jan 2024 21:48:09 -0800 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init() Message-ID: References: <20240111192329.449189-1-urezki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111192329.449189-1-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Jan 11, 2024 at 08:23:29PM +0100, Uladzislau Rezki (Sony) wrote: > #endif > VMCOREINFO_SYMBOL(_stext); > - vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", VMALLOC_START); > + vmcoreinfo_append_str("NUMBER(VMALLOC_START)=0x%lx\n", (unsigned long) VMALLOC_START); Well, the right fix is of course to make sure VMALLOC_START has a consistent type, else we need to plaster this crud all over. unsigned long seems like the right type for it, so at least m68k should be fixed to confirm to that by adding a UL postfix to the definition.