Received-SPF: pass (google.com: domain of linux-kernel+bounces-24344-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <bfb6f6ac-d29f-4857-aa8c-6b8da9c2f436@collabora.com>
Date: Fri, 12 Jan 2024 11:50:33 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Shuah Khan <shuah@kernel.org>,
 "Joel Fernandes (Google)" <joel@joelfernandes.org>,
 Lorenzo Stoakes <lstoakes@gmail.com>, kernel@collabora.com,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: mremap_test: fix build warning
Content-Language: en-US
To: Andrew Morton <akpm@linux-foundation.org>
References: <20240111082039.3398848-1-usama.anjum@collabora.com>
 <20240111131405.4b47521fb8884760d712e93d@linux-foundation.org>
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240111131405.4b47521fb8884760d712e93d@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 1/12/24 2:14 AM, Andrew Morton wrote:
> On Thu, 11 Jan 2024 13:20:38 +0500 Muhammad Usama Anjum <usama.anjum@collabora.com> wrote:
> 
>> Fix following build warning:
>> warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long long unsigned int’
>>
> 
> Looks good to me, but... grumble.
> 
> `i' is an integer.  That's just how it is, Blame Fortran if you like. 
Didn't know this. Thanks for sharing. I'll send a v2 by using two variables.

> Discovering that someone used `i' for an unsigned long long is like
> seeing
> 
> 	struct inode *page;
> 
> It is surprising, and readers shouldn't be subjected to surprises.
> 
> `i' is used in two ways here.  Twice to iterate across threshold values
> (as a ULL) and once to iterate across dest_preamble_size, which is an
> int.  It would be better to have two different variables for the two
> different uses.  Ones with more appropriate names than `i'.
> 

-- 
BR,
Muhammad Usama Anjum