Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2132034rdd; Thu, 11 Jan 2024 23:24:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhqaHS9O4UGyeI1TCm8LSoFurX215JmN8SQ9PGJpi4Bqrm5aK9xaJv0GMf56cba4u1IPCy X-Received: by 2002:a05:6871:414b:b0:204:29f5:be17 with SMTP id lb11-20020a056871414b00b0020429f5be17mr1015782oab.59.1705044281326; Thu, 11 Jan 2024 23:24:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705044281; cv=none; d=google.com; s=arc-20160816; b=D5PKAXEzOn/hH7bQ/syxmH+uslOGmh5TL+1FkbD2PuHpUFLYzglnUwFTvYpWT6qg87 yG0hLyP0dcuQxpGJi5J/+8BPR6NB6IvbxiE2xXkcBUrM4t8zmGbl3twXmshUHvZywt1e iKLZxU6C+v+qNc/c3+AjZS1aEk5MYi20evN20TTa3+Hy0f/SkB8ReI3ICaKnh3SFvUQw JXvqi8kZD5zoV1SZaxYOrZMv6jGnA5NiwPhqScKWYehVAvwCccrUZB5bPo3PBMy+sOFO 9cJtf7a9L9ErIA6r4N8YZhVOI0am5IMw0S/fELCW3zuoyo8bz27TJca4y2eVw+qljUhT Bjzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=1fcEEU2wk6GX+jnaxPZQWkZOX1G7oxu1vYGYKPoo5wM=; fh=cKN27NzqEscnSBEVcBnI73HLQQL+yl/XHT5bCWHrtZ4=; b=W2ANRPA4v3fzO8toxUUxTzQH4k1eC6Feqw3om7pd/FftYpVeYMNWvHEkamXhNJrJwD vU8sBKLHpcO7CnQraFK6Jk+YFhtOC13F1UC2iTLoRGY+wxMnX/9VoDfSJX70OX1Opz0I J+BO4hYDolgQ7ENdwpGONZSedq9TAUT6f2HB2T3jdL1cvalnWjYC6e8IHo0SCpFAmnkd /IolTc5XE1DqGxMfTx2ijhwDSSADsLuJoWXIqeavcimAth3nhiVuJI1C2EAYdR6K+tBc Z8igqZ44Wi1HobFSIdJ2YxfjCJpJPw9rfBiELpaHLA5W3kqmtVk0y9YByEEMwddxxiEW 3iBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vfDnBQab; spf=pass (google.com: domain of linux-kernel+bounces-24376-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24376-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k65-20020a632444000000b005c67196cbf5si2778412pgk.330.2024.01.11.23.24.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 23:24:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24376-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vfDnBQab; spf=pass (google.com: domain of linux-kernel+bounces-24376-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24376-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B9C5E288228 for ; Fri, 12 Jan 2024 07:24:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6630B5C919; Fri, 12 Jan 2024 07:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vfDnBQab" Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E9A35C8FF for ; Fri, 12 Jan 2024 07:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3374e332124so4615653f8f.2 for ; Thu, 11 Jan 2024 23:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705044270; x=1705649070; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1fcEEU2wk6GX+jnaxPZQWkZOX1G7oxu1vYGYKPoo5wM=; b=vfDnBQabsdChdC3oEaxsfrUsRfI/mNY3mj0nx+BVUc+KpDoMuygVyzirnUGqF6TxbD bhXkHvdiMipQ1HCkF6cOvVt90uvfJbtrlTUexywrxpNGef8kwBViwgOOyP2IoHcIDZre mZFIi6MPA8rUhlHvowT/wLssjmO/svcHZJFdOK/Pb35k7I5DtxZNCrZF06dzmfbYiQeh LOfUqZvQKJeW8N9xJVLWB3SkkgUqM0RO+hypj+QGf/XXqiG9y7HkNV7fXb2hY8ipy8OI alH2NjJ09V+XVSmb/UJJJvzPCcTDDEp7ne76EWcN8mhSx/XX6SRWKCuamV0wHgNTpD+D 1p0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705044270; x=1705649070; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1fcEEU2wk6GX+jnaxPZQWkZOX1G7oxu1vYGYKPoo5wM=; b=j53xWbaHQYv2tDsXpryXAYk/+1oqBap9aLPj6oqs444eVkTEwwxs8JOIYuRCB426wh LJXXgx2zmq5zTCT/nisfCQLzt/4JWyHZjGomX1g9+jU3vbYoiV3C1JJb9npBA55f4Z87 WpbPKWB3PSF0Ldf9xHOeUi8hTtLmK6MeflFEILoEpRKXSWTrOVuAjI/Sm+9NaEJczGdu bFxndt+/Amw4pUl4h6PsGhU76CrSVJc4PpAtQZ2U9SqZ1kyLNTdM0mp9qnAFOQ17Z7CM ZWkM8SThLiFUxXa6I//LjkT8URfysNMMePMkYeP2pVotxs20Tx3zPEb92T6kuRKga8x7 +HFg== X-Gm-Message-State: AOJu0Yxqtj1LbMPbAPtZKTVc5gZdSzeoqTeznAaJllyCeFSBu2omdDvi 7DOZ+zPgsQdqBgYMozTttUElONDG3crx/g== X-Received: by 2002:a5d:4087:0:b0:336:ca46:2ce1 with SMTP id o7-20020a5d4087000000b00336ca462ce1mr424839wrp.122.1705044270393; Thu, 11 Jan 2024 23:24:30 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id q6-20020adf9dc6000000b003378e67fd2asm2407525wre.86.2024.01.11.23.24.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 23:24:30 -0800 (PST) Message-ID: <5c789b3a-1a2c-47a4-b8f7-191bb13f060f@linaro.org> Date: Fri, 12 Jan 2024 08:24:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's Content-Language: en-US To: Ben Levinsky , jassisinghbrar@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, shubhrajyoti.datta@amd.com, jaswinder.singh@linaro.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240111172226.1816105-1-ben.levinsky@amd.com> <20240111172226.1816105-4-ben.levinsky@amd.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240111172226.1816105-4-ben.levinsky@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/01/2024 18:22, Ben Levinsky wrote: > /** > * zynqmp_ipi_free_mboxes - Free IPI mailboxes devices > * > @@ -748,6 +861,9 @@ static const struct of_device_id zynqmp_ipi_of_match[] = { > { .compatible = "xlnx,zynqmp-ipi-mailbox", > .data = &zynqmp_ipi_setup, > }, > + { .compatible = "xlnx,versal-ipi-mailbox", Not documented. Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof