Received-SPF: pass (google.com: domain of linux-kernel+bounces-24410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <2296235e-b15a-445d-b867-125c6d85a8a6@linux.dev>
Date: Fri, 12 Jan 2024 16:07:54 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v3 4/7] hugetlb: pass *next_nid_to_alloc directly to
 for_each_node_mask_to_alloc
Content-Language: en-US
To: Tim Chen <tim.c.chen@linux.intel.com>,
 David Hildenbrand <david@redhat.com>, David Rientjes <rientjes@google.com>,
 Mike Kravetz <mike.kravetz@oracle.com>, Muchun Song <muchun.song@linux.dev>,
 Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 ligang.bdlg@bytedance.com
References: <20240102131249.76622-1-gang.li@linux.dev>
 <20240102131249.76622-5-gang.li@linux.dev>
 <66af5bce84c9b6480feaa2ddaff199cd5722fcde.camel@linux.intel.com>
From: Gang Li <gang.li@linux.dev>
In-Reply-To: <66af5bce84c9b6480feaa2ddaff199cd5722fcde.camel@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/1/12 06:21, Tim Chen wrote:
> On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote:
>> The parallelization of hugetlb allocation leads to errors when sharing
>> h->next_nid_to_alloc across different threads. To address this, it's
> 
> Suggest you say
> With parallelization of hugetlb allocation across different threads,
> each thread works on a differnet node to allocate pages from, instead
> of all allocating from a common node h->next_nid_to_alloc.  To address this, it's
> 
>> necessary to assign a separate next_nid_to_alloc for each thread.

LGTM, thanks.