Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2201088rdd; Fri, 12 Jan 2024 02:28:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEchfYzzpjNkF/AtuwIyOmXpKMTBjcCeV0vQ701c41FZXEo0dMidMdxvg8FvJyiABAaKMuF X-Received: by 2002:a9d:62d7:0:b0:6dd:de32:6f62 with SMTP id z23-20020a9d62d7000000b006ddde326f62mr1341978otk.1.1705055284609; Fri, 12 Jan 2024 02:28:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705055284; cv=none; d=google.com; s=arc-20160816; b=Lx+v6ea3CJPhuxW1JeJZC4IhIkKqE9r3eoccmI4V1OzSr5ETu/OduCAkCrNYXSPBu2 7woh8Dz1LbGZhLMStNU5rzkZXaUFUlCyiQ62NHTnRMaS2zdlxCNM9t7alGb7urKhfs/x aJcYU6YXHHFvLaYOsr6hUuLJSRygW3Vfj0ycTE9wprw012unWTCQQiqCTd6CeYYPJAEz xIyebYoszdoIbPozZFum17NfOGdQSaZqrHsZFjDq8gIw/H2I3moJUcJfDpSXoVLMmhle 6IStCaN0P/cUU+gHiW4sG+PdGYscGkLtocebx8HzsKHo8hP9Dvi7S9fUYIIjvfOMl0nG n7tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=yIxi8v6Ma1Grko/+1NBLzi5Oysu1LXKfrIWH4Vh6r3U=; fh=/mGhCvLEAeGOrlJl+AKJYjVkMlmkGpTUQtybzGc7PEc=; b=0nrQyYCmy6AWXEdDEDaHMvBKSsC3pUXN6iBdqUOQb5QYMKx+z8S9u8Gc38tUXzhAE9 dcc+iHdNS4Nj0VfSyFPVfx3ajybMQrcoXQio0UOEbFb5KN4tJIQ6eP/0tQ6i2LqkqQuT UNazNITTTKpWGKzRwxtWu2V6p4hoHMON1bwkhTXQlF1eVQJXQ1pKYrLbLuYvVVu5JuAo uT7Cwvf/oaFuTKVXJGCwjrpR4ebsJDmMycAURpYTdYzHiq3gy7+PFXhfSAuf7VK7FQtd RlStsrfcMbJYL4mIq+CtOHvqkgpNHxq+9ZJVKvXp8Zetk69Be42KaKQJGRfJhxcEODjz abwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=rXXBYWI0; spf=pass (google.com: domain of linux-kernel+bounces-24589-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s14-20020a65644e000000b005ce0b70d2a0si2976135pgv.88.2024.01.12.02.28.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 02:28:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24589-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=rXXBYWI0; spf=pass (google.com: domain of linux-kernel+bounces-24589-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24589-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 241322853FC for ; Fri, 12 Jan 2024 10:26:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD1F15EE95; Fri, 12 Jan 2024 10:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rXXBYWI0" Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9195EE8A for ; Fri, 12 Jan 2024 10:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5f70c085d64so55434697b3.1 for ; Fri, 12 Jan 2024 02:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705055157; x=1705659957; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TrpYiiUZvW6/AnFbosBlfeKS3Uh1NSZM2E5hPQsUkps=; b=rXXBYWI0vGvvTKV6ygv88oM6VN6fXHHyZjLlGKMs/s3CbH5ci8S/ZMTvCYqPcVxfOb b/+PWxhNxncyKnZ2ZkHpqQOqBTe4gKaDV25oFWex16yfaOE64JSa4tp+TLnaaZsHp+gL oFC2MfirbpqhGs6e4AsAZfDwo1A3MsFZA/KR/pfITivpSG7AG/wdl6SxqjWLVznZgfJV ni4KSOTYAA0g7P63wJnFem26JwLAtTtDjDNoJ0WASue6Y4AJOdltlY1FMXp86bmziBQi gEWZ07W7emdb6aNONrB8+e+cxwvhZfV33DKXp1PQVpdNsnb6H1EV+T85vLkz/uCKh+T9 A/Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705055157; x=1705659957; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TrpYiiUZvW6/AnFbosBlfeKS3Uh1NSZM2E5hPQsUkps=; b=KgwjleB0Afzp7y1zbkbF5ykeJ884VaKwe5wnVDWVdYD8QIj1Ejn35IDodQsg+QRVAB j7iGh0goQvZCSL8sABBPFd3vChdSWOqViQh1nq25Q2QxTrUf9QNjm54IpRYGtydx12y1 MrYhWVFfGqgJTH+Io23DqIrLpnMgY+EaXgdfsuC7F9QjUcaCIM0hoMAyExo//p7UaF9w ZeAH24lSM7d6PV6gEa0OEP/pmQ+rg8m6jxe/Xe0iphXfalWVLIJ9aZ9VgRUDNVgNCpvC WjdzJ9K3gp29TKnMwsPFTidNYGGHRneIlg9Usr9FFMKr6EKOAsuLaryIN7zAGUmA2xut vBuA== X-Gm-Message-State: AOJu0YwymFPAgPtTsl2VnHStph42xfY5e7479ECARXpmDqp6xUyOOBPK nHYlo9+E8SUlefgUn2SrEfmuehJSJRv37OJhESoItC1b+1LnKQ== X-Received: by 2002:a25:ea44:0:b0:dbd:e651:a32f with SMTP id o4-20020a25ea44000000b00dbde651a32fmr439006ybe.114.1705055157730; Fri, 12 Jan 2024 02:25:57 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <46566e85-4afa-4c55-93b2-0d0b71d76b12@moroto.mountain> In-Reply-To: <46566e85-4afa-4c55-93b2-0d0b71d76b12@moroto.mountain> From: Linus Walleij Date: Fri, 12 Jan 2024 11:25:46 +0100 Message-ID: Subject: Re: [PATCH] gpio: rtd: Fix signedness bug in probe To: Dan Carpenter Cc: Tzuyi Chang , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 7:55=E2=80=AFAM Dan Carpenter wrote: > The "data->irqs[]" array holds unsigned int so this error handling will > not work correctly. > > Fixes: eee636bff0dc ("gpio: rtd: Add support for Realtek DHC(Digital Home= Center) RTD SoCs") > Signed-off-by: Dan Carpenter Looks right to me! Reviewed-by: Linus Walleij Yours, Linus Walleij