Received-SPF: pass (google.com: domain of linux-kernel+bounces-23858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1374-gc37f3abe3d-fm-20240102.001-gc37f3abe
Precedence: bulk
MIME-Version: 1.0
Message-Id: <5d2d8e57-0041-40af-b237-05f3275008bd@app.fastmail.com>
In-Reply-To: <ZaASsqnq5ZYdcjm6@lizhi-Precision-Tower-5810>
References: <20240110232255.1099757-1-arnd@kernel.org>
 <ZZ8wMWQMo4eGnSuG@lizhi-Precision-Tower-5810>
 <343cedc4-a078-4cf8-ba3b-a1a8df74185b@app.fastmail.com>
 <ZaASsqnq5ZYdcjm6@lizhi-Precision-Tower-5810>
Date: Thu, 11 Jan 2024 17:23:03 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Frank Li" <Frank.li@nxp.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
 "Peng Fan" <peng.fan@nxp.com>, "Fabio Estevam" <festevam@denx.de>,
 dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH] dmaengine: fsl-edma: fix Makefile logic
Content-Type: text/plain

On Thu, Jan 11, 2024, at 17:09, Frank Li wrote:
> On Thu, Jan 11, 2024 at 07:23:34AM +0100, Arnd Bergmann wrote:
>> On Thu, Jan 11, 2024, at 01:02, Frank Li wrote:
>
> It should be better link into same module because some debugfs and trace
> improvement are on my TODO list. Export symbols will make more unnessary
> complex.

Ok, I'll see what I can come up with

> Or simple exclude MCF_EDMA by change Kconfig
>
> config MCF_EDMA                                                            
>         tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"   
>         depends on !FSL_EDMA
> 		   ^^^^^
> 	depends on M5441x || COMPILE_TEST 

This does not actually prevent building both as modules, it
only enforces that you can't have them both enabled if one
of them is built-in.

     Arnd