Received-SPF: pass (google.com: domain of linux-kernel+bounces-24617-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5838205f-41ba-4666-9786-11181552a738@intel.com>
Date: Fri, 12 Jan 2024 19:28:17 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [linus:master] [connector] c46bfba133:
 stress-ng.netlink-proc.ops_per_sec -97.2% regression
Content-Language: en-US
To: kernel test robot <oliver.sang@intel.com>, wangkeqi
	<wangkeqiwang@didiglobal.com>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<ying.huang@intel.com>, <feng.tang@intel.com>
References: <202401112259.b23a1567-oliver.sang@intel.com>
From: "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <202401112259.b23a1567-oliver.sang@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHo1dWJhaU8rakduclMwcEFsb2lRQ2d6d0EvUzAwRGRVMnBIZWxzKzBZeG9U?=
 =?utf-8?B?ak1wMU85aDhLRjZtdWRiaHhJRTZjZ0UwU1VKcDd5Q1Y1Sk80NjZjdno1c3Fq?=
 =?utf-8?B?RE5jT0F4R2o3bmtZVThQYnB3QndVcDZWL1U5bFl5ZGZVOWdkc1RFb013UTNS?=
 =?utf-8?B?RHF1VTFvL1N5T2ZGWDJ6RWR3Q1pjOXp1S2xQWVNvS1ZDSnJWU3g2c0p5RWI0?=
 =?utf-8?B?OUVoRGRtdEllNjljNndCdll3RytHTGZtbGtublN3SjExakdMY3BIdU1iUnht?=
 =?utf-8?B?UDg3QU8yYWNySlIzNzFkMGNMZTFPNGh6YURYT2VMbXZtdFZvRWhxeUF0a01z?=
 =?utf-8?B?QWt6QlV6SnNPanJhZzV3QkhyVkpzM2FHV2ovOHBVRmVMeGdVZnZuYmZXcldK?=
 =?utf-8?B?WXRpQjBqK2owTTBvZHE1R3NLK1gxVlo0MGdqVlQ1Vytlb3dVRTdzdUJ1SE9p?=
 =?utf-8?B?THpZakY5ZmdEYWI1anBKaTdsTzQ3Ti9MOFlNMGxDcTVPSXBmMmdES2YyL0FV?=
 =?utf-8?B?ZUlqUnhUMy9WR0g5eC9TK3VSZDM0eFZpZUxxeWFCdFFwVGVBU0VsRVI5QWVL?=
 =?utf-8?B?c0NxcXVmUCt4TW5jUERTYXdod0FVY2R3d2pmaUNOREpoWXF0Vkozbml5ZThC?=
 =?utf-8?B?N29aM09IQ3czYkJwcjV3TTdQSkRCcE5MYmdhQndSNXk2NFQ4bTJVTVhCWUo4?=
 =?utf-8?B?ZGZCWC9EZGgrV3Y3bVNpMWY2Y1FlWG5OSDVHTjJkbFdiSzNKYk8wNVcwMzFw?=
 =?utf-8?B?a3huQnFSSWNCWlJ6UU45bjJkSS9XYUhaRTNUc2NuMjhqS0ZweG9XQXlRTTVx?=
 =?utf-8?B?TytLckRlQjlnUVJ3R2piVm9IaW55dVdiNWpxckoxVUFlTVFDNWozR0dIRElP?=
 =?utf-8?B?WGQrSUpCNTZXQUxxMk5MelZHT2oyektYK1Z1UlA2UURMdGp1ZGJLTDJiZ1hw?=
 =?utf-8?B?ek9JUkpEa3lBUnl6cHJMbWpsT2kvVkFudDNKRE5hdUM5WXRBak9MV2NkOVcz?=
 =?utf-8?B?L1pUclgrUXNDc2dyMGlad3ZWUjlIb0NMKzRPNFhFMGdWeEdsMnkxWVBjRkV4?=
 =?utf-8?B?TFVyMC94ZGhhWExtSDVrcmZ0aWRyek9PVWhRR3Z3eStabytnTEpMakhtR3VR?=
 =?utf-8?B?dkhTbzVybGJqQ0UySUMvRXFEQlQyYndNYXdCZFJ1UjVPNng4Z0ZlMUxKT3Fo?=
 =?utf-8?B?Vm1WOE5xS2dwUmhlT0xEVnRyb1JFZTU2dWFjNW9Fd1BsZkt1WGVXRFlyRjds?=
 =?utf-8?B?UjZrZUloSzFJRjNyam9TV1dRakp6VWgrdnhib0RSRFo4UU5zZEpDOGY4djhO?=
 =?utf-8?B?QmRyU3ZYcnowUGRoUk1uaFQwdSt3R1B5R0xLVk9yRzNudEl5bU9GQWxLMEt1?=
 =?utf-8?B?dFZXb2ROTDRyc1JHOFQxei91UzNYL3pSazl3ZWkrS0FsWDlYKy85ZXhlOGVB?=
 =?utf-8?B?UHJSR3Z4QldjOGxPWWNvbnlab3FiNWJXeDIrdHh5bHRVdjFCbXpHcGg2UEIy?=
 =?utf-8?B?bS9WOW9LUkZPVndaMjk1b1QyZVdoWDdXVGV0aThVSkpwTURBS05iM1NmZUVO?=
 =?utf-8?B?TWZRejdodXhIT2tEN1hOa3Fva3Ezbi9NakxkKzR5RHAzNGJrOGdKcmhnbWlp?=
 =?utf-8?B?OXppQk1ZeVR6Z2dtbFhablZUZjltTno1QVJLQ1VEc1pjSHVVcnJMN3ZVRDFG?=
 =?utf-8?B?cjVtZnc2V3dWUnBFd0tjcnJYYksxWDhRbVo2TEQzMVdnTWNkU3owS1R0YXo3?=
 =?utf-8?B?OUY3UHBxbDkwZTBqeS9tVFQ0OXFYUlFlcWVWZEdmNVIySmtqc3pUN2RlOWpK?=
 =?utf-8?B?Tm5WNyttWWtuWFFzNURLcittcGdQbkVtQ2xTaCtKRC8vMXZRdkEzUklES28z?=
 =?utf-8?B?ajdDb1pqZTFHeWRFTVNBVk5wa2NpVDg2MkFHVCsrLytsOFNjRnNPUkFtTjlv?=
 =?utf-8?B?cEluSWNBVzNGQmFFVllEbXNsSkFEL3cycjNoMlFhWk8xWjh4YlBwck84YXlD?=
 =?utf-8?B?N2JnUTMrS0tUN0tHVXVtMXEvOXI1SjQ5VnZKQmIvVnJVRDBIdm9HR2RLeWwx?=
 =?utf-8?B?cVFRUTFjb09zckY2dk1HNGdha2Y5Nkk2MWc3VGpRK2Z5ZjJ3NHQ1cVhSWDBN?=
 =?utf-8?B?NmRhLzQzYjdwcElkNjNHcmVheExVc2lncTI1SW5mZVcrdGNrSUJzV0ZvUXMz?=
 =?utf-8?B?VHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3734bc-603d-4e71-55fb-08dc13619722
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 11:28:25.1091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OmmLN0Frw5Q5+nEARPD5z6+ZQP054sRD6P3o0TGVIbJl5AN7EQQshykakBBECy7TxCyeNUmwT6wM1ZJJdaGq1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5810
X-OriginatorOrg: intel.com


On 1/11/2024 11:19 PM, kernel test robot wrote:
> 
> 
> Hello,
> 
> we reviewed this report and Fengwei (Cced) pointed out it could be the patch
> breaks functionality, then causes stress-ng netlink-proc performance drops
> dramatically.
> 
Just FYI. Here is what I observed when running
stress-ng.netlink-proc testing:

Whatever with/without the patch, cn_netlink_send_mult() returns
-ESRCH in most case.

The following is what the cn_netlink_send_mult() returns when
stress-ng.netlink-proc is running:

..
213801  213801  stress-ng-3     cn_netlink_send_mult -3
213801  213801  stress-ng-spawn cn_netlink_send_mult -3
213801  213801  stress-ng-spawn cn_netlink_send_mult -3
213801  213801  stress-ng-wait  cn_netlink_send_mult -3
213802  213802  stress-ng-4     cn_netlink_send_mult -3
213802  213802  stress-ng-spawn cn_netlink_send_mult -3
213802  213802  stress-ng-spawn cn_netlink_send_mult -3
213802  213802  stress-ng-wait  cn_netlink_send_mult -3
213803  213803  stress-ng-5     cn_netlink_send_mult -3
213803  213803  stress-ng-dead  cn_netlink_send_mult -3
213803  213803  stress-ng-dead  cn_netlink_send_mult -3
213802  213802  stress-ng-wait  cn_netlink_send_mult -3
213801  213801  stress-ng-wait  cn_netlink_send_mult -3
213800  213800  stress-ng-wait  cn_netlink_send_mult -3
213799  213799  stress-ng-wait  cn_netlink_send_mult -3
213798  213798  stress-ng-wait  cn_netlink_send_mult -3
154697  154697  stress-ng       cn_netlink_send_mult -3
..


Looks like it's not accurate to reset proc_event_num_listeners
according to cn_netlink_send_mult() return value -3.


Regards
Yin, Fengwei