Received-SPF: pass (google.com: domain of linux-kernel+bounces-24657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240109214828.252092-1-tj@kernel.org>
In-Reply-To: <20240109214828.252092-1-tj@kernel.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 12 Jan 2024 13:34:48 +0100
Message-ID: <CAMuHMdW4iYbi-cwGBZgiS72=hP9X9r9Tc_UQaYBAsC=KNox2dw@mail.gmail.com>
Subject: Re: [PATCHSET driver-core-next] kernfs: Protect kernfs_find_and_get_node_by_id()
 with RCU
To: Tejun Heo <tj@kernel.org>
Cc: gregkh@linuxfoundation.org, andrea.righi@canonical.com, ast@kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Tejun,

On Tue, Jan 9, 2024 at 10:48=E2=80=AFPM Tejun Heo <tj@kernel.org> wrote:
> The BPF helper bpf_cgroup_from_id() calls kernfs_find_and_get_node_by_id(=
)
> which acquires kernfs_idr_lock, which is an non-raw non-IRQ-safe lock.
> kernfs_idr_lock used to be a non-irq-safe lock which could lead to deadlo=
cks
> as bpf_cgroup_from_id() can be called from any BPF programs including e.g=
.
> the ones that attach to functions which are holding the scheduler rq lock=
.
>
> To resolve the situation dad3fb67ca1c ("kernfs: convert kernfs_idr_lock t=
o
> an irq safe raw spinlock") converted kernfs_idr_lock to an irq-safe raw
> spinlock. However, this was also broken as we call idr_alloc*() while
> holding the lock and idr itself uses an non-irq-safe lock and also calls
> into memory allocator.
>
> Let's instead RCU protect kernfs_node and kernfs_root so that
> kernfs_find_and_get_node_by_id() can use rcu_read_lock() instead of
> kernfs_idr_lock. While this unfortunately increases the size of kernfs_no=
de,
> it's the most straightforward thing to do and there likely are other plac=
es
> that can take advantage of RCU protection and improve scalability too.
>
> Please see the patch descriptions for more details.
>
> This patchset is on top of the current driver-core-next - dad3fb67ca1c
> ("kernfs: convert kernfs_idr_lock to an irq safe raw spinlock"), and also
> available in the following git branch.
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git kernfs-use-rcu

No more BUGs seen (with v2) on the few platforms I tried, so
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds