Received-SPF: pass (google.com: domain of linux-kernel+bounces-24715-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b04ae5f5-4770-466d-87bb-d1b96d65e89c@nvidia.com>
Date: Fri, 12 Jan 2024 19:27:18 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V1] PCI: Clear errors logged in Secondary Status Register
Content-Language: en-US
To: bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 treding@nvidia.com, jonathanh@nvidia.com, kthota@nvidia.com,
 mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20240104013229.693041-1-vidyas@nvidia.com>
From: Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <20240104013229.693041-1-vidyas@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NFQ2ZFNnK1dKV1hqWWs3dHgyd3Y0Y2QzRG1oekR5b2ViMG1tVnhaUW1TVkl6?=
 =?utf-8?B?dHVhdHBnT3E1Z0pDdkZIaWVCV3lKWk1JNDRzT0pRdDVVa0UvcERHZFRTRTMy?=
 =?utf-8?B?YmxIc0RCQVhjZlNRVGh2NkVRRUdtRkI0R210WW0yN0tDYzJPMjlQVExNcWtI?=
 =?utf-8?B?MWUwdHZodlBlQnNxOUNtdVh5Vjh3S3g4NHFYOXVuemtrR1BaZW5RTFJNcjEz?=
 =?utf-8?B?SUd0b2syNDBRdCtYUVJtRDZHQlNHd0ZKc0dmTFpCN1YwNitoSk5tamUzay9p?=
 =?utf-8?B?K0xPQ1BUenhHd0swUVoyUkZ1c0crUWd1Y2I3amJpQnpMYytJSTArc0Y0R2Rz?=
 =?utf-8?B?YmNqTFAvUDZndHpHblJrTXUycVphbmIrMC94TzFTRmJvMGFGNW00MXpYVGVr?=
 =?utf-8?B?MlU1bFhjQ2pMSVk2d0k2djV4clNhbnVlOFQ3dXNwM2tIRDVjeWRCcHlQN1hr?=
 =?utf-8?B?b2JqYVRQNDVnNzJZUHdoUm9TRDZSVkdMdytOcHhOY0d5dGxnNHZDdUExTGxZ?=
 =?utf-8?B?emhML1NZNmFoNnpwRGdJb0loSEVGNWg4QXVpNzM2UmowSVBQTWx6QU0wT1pz?=
 =?utf-8?B?WVB0U1lvQmt4T1lMNlN1T0ExSm1HUzZDODQvb1FXQWVTa05rL2pSK1RLWGN0?=
 =?utf-8?B?TUgvZWNYeFBQZG9aMmhxZXBZL0hpUTFrOE44dGozdDhkNFBDdUtJODFadHkw?=
 =?utf-8?B?Tm1FMmd4MTA4TWNsMnEvMmJwYUNRaCtSUStGeFAxSHRPYklmOFBiRVpXZkow?=
 =?utf-8?B?enMydG5yRmZVTVcyYW5qYnUrbnFTZFMweTI1ck9KN3BETSs5RHlIQm1KYis5?=
 =?utf-8?B?c0dORDZ5Zm52NlpjUmhpSjdsYnY0V2IvMHJnSGdKQS9IMEQ5SW1vUmZTL3Vs?=
 =?utf-8?B?OUE2QU1lZVdmaEZ1U0ZsMHVyamhvaWhPZGVRTkJIWkZuL1Rtb3d4eGxVTlJp?=
 =?utf-8?B?NlU2UWFZWGlmb3EzZUs5TnI4MitzaldPd0V0UHdaZXF1U2RzZGNIR3BpdGw3?=
 =?utf-8?B?ZVdnb29nb2JURlZqTzVhMDF4NE4rRlFEYWVmamhyV3pCNVRVcU5iMWZqTFBk?=
 =?utf-8?B?cG5yMEJ4WEJ0MFBOZmFERW1xZ2I0QXllYzFSeEdCNGx1eEw5TjZjcnV4QXJl?=
 =?utf-8?B?NEp6c3VYNG1EcWIzTEMwcUZvbHliR3U5Q3dkYmg4ZlM5Q2EvV1ZTbVRyam1i?=
 =?utf-8?B?YTJycGphTVZub21OcTgxMDFjZS8wdEREQnViNmVkSTNIOHlWUkM4cmRVWjVF?=
 =?utf-8?B?RlJ3TWVtUFdZUlIwSHFnbktoWjhiaXBJL2hycHEwaDJMRFZGZ3VhVnJHMytC?=
 =?utf-8?B?N3RsNGRWakh2bEZ2cVhST3czVHptM0VVTEVpL3kvNmcxbGFlV1l3T0JNYVFP?=
 =?utf-8?B?bG9LRnlzZVFBVHVHbTdadWxYaWg5bHZLSVE3ejFoWm0wWSs5SktUOEMxdU5n?=
 =?utf-8?B?MzRQUjY5YXdoV1lSUzVwWEJNOFdPK1pOci9hTzBzTUJFdzJIdzJVMzVoc1VM?=
 =?utf-8?B?cW43ei9pVm5MME1oMmxFUFMvdXNrYmVJRU5MVlAwbEY2MW9TSy9OeUpYdEV3?=
 =?utf-8?B?SjBLVzBxUnJhMVpYR1hmV1UrUis0SEhJdVkyUTk2K2kyMlRqK1ZLYmpVbmo2?=
 =?utf-8?B?OGdJZVZtQUhSekR6R2l6QVhGcnd5MGdvaTBWY1Y2UzlYTkUvQmRORGM1MVI2?=
 =?utf-8?B?RkxTYUJUUTZoVGNnR0pqQlNTTEZMbmo1NWRqUERKSWpRb2xHMW9LSldDZlpN?=
 =?utf-8?B?dDJPMlBtMFZwdU5WU1VNZlcyS0J6blhoeFl0UGxBcFp3UGhRTjI0Zzk5Q3FV?=
 =?utf-8?B?bW9pdzNoK1Z2WHR0bkRvNjNnbndGVjFqRjd0L3BUUStxblRhK2xORngvSUF3?=
 =?utf-8?B?V0ZPcVRZMG1zdVlmcWpMMk9reHdDLzVLYnplaVBTNlZHbG50K3FIdkFuZWVJ?=
 =?utf-8?B?eFF6MU1Pb042T2ptRzV3UitDTnNzWm5jbXV4cEh3QktieVNxQ3Y4QmJudDAv?=
 =?utf-8?B?R3h1RUp2bzZyelVIYjJOOVFiREU0NFdwQU5UZlNpalBERjJxK0VUaHR0T2RY?=
 =?utf-8?B?NWt1OHkrcENSMUo3ZUhQVm1xVVk1bndoZUxoYThxVTVuVUFJMEdFUU9zcmVB?=
 =?utf-8?Q?mJOOPpimEox9rawkWfIlJGp0s?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d875d7f-6fe7-4049-6568-08dc137668cf
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 13:57:26.9027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8UlqrPqQ7S3O8++B0b66SFD/Y7x0bdyf3wwjhHnDepP/bGbtkxYLypfebMdXob/Vn6JJ+FQbpOsJvH4WAh5mjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219

Hi Bjorn,
Do you have any comments for this patch?

Thanks,
Vidya Sagar

On 1/4/2024 7:02 AM, Vidya Sagar wrote:
> If a downstream port has a PCIe switch connected to it, the enumeration
> process leaves the 'Received Master Abort' bit set in the Secondary
> Status Register of the downstream port because of the Unsupported
> Requests (URs) take place in the downstream hierarchy. Since the
> ownership of Secondary Status Register always lies with the OS including
> systems with Firmware-First approach for error handling[1], clear the
> error status bits in the Secondary Status Register post enumeration.
> 
> [1] https://lore.kernel.org/all/1fb9d746-0695-4d19-af98-f442f31cd464@nvidia.com/T/
> 
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>   drivers/pci/probe.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 43159965e09e..edf8202465d8 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1470,6 +1470,9 @@ static int pci_scan_bridge_extend(struct pci_bus *bus, struct pci_dev *dev,
>   	}
>   
>   out:
> +	/* Clear errors in the Secondary Status Register */
> +	pci_write_config_word(dev, PCI_SEC_STATUS, 0xffff);
> +
>   	pci_write_config_word(dev, PCI_BRIDGE_CONTROL, bctl);
>   
>   	pm_runtime_put(&dev->dev);