Received-SPF: pass (google.com: domain of linux-kernel+bounces-24742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 12 Jan 2024 08:25:37 -0600
From: Nishanth Menon <nm@ti.com>
To: Sjoerd Simons <sjoerd@collabora.com>
CC: <linux-arm-kernel@lists.infradead.org>, Roger Quadros <rogerq@kernel.org>,
        <kernel@collabora.com>, Conor Dooley <conor+dt@kernel.org>,
        Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring
	<robh+dt@kernel.org>, Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra
	<vigneshr@ti.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am625-beagleplay: Use the builtin
 mdio bus
Message-ID: <20240112142537.axjy5risfe5lpnqc@quintet>
References: <20240112124505.2054212-1-sjoerd@collabora.com>
 <20240112135000.b54xz3boeua7y2jf@music>
 <2ce27ed917b9bd569ee4a7f87b3d9b78d07cecbd.camel@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2ce27ed917b9bd569ee4a7f87b3d9b78d07cecbd.camel@collabora.com>

On 15:20-20240112, Sjoerd Simons wrote:
> On Fri, 2024-01-12 at 07:50 -0600, Nishanth Menon wrote:
> > On 13:44-20240112, Sjoerd Simons wrote:
> > > The beagleplay dts was using a bit-bang gpio mdio bus as a work-
> > > around
> > > for errata i2329. However since commit d04807b80691 ("net:
> > > ethernet: ti:
> > > davinci_mdio: Add workaround for errata i2329") the mdio driver
> > > itself
> > > already takes care of this errata for effected silicon, which
> > > landed
> > > well before the beagleplay dts. So i suspect the reason for the
> > > workaround in upstream was simply due to copying the vendor dts.
> > > 
> > > Switch the dts to the ti,cpsw-mdio instead so it described the
> > > actual
> > > hardware and is consistent with other AM625 based boards
> > > 
> > > Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> > > 
> > > ---
> > 
> > We have had issues with the ethernet integration previously (also why
> > ethernet in u-boot is not yet functional on beagleplay[1]).
> > 
> > https://openbeagle.org/beagleplay/beagleplay/-/issues/101
> > 
> > we should probably do a 1000 boot nfs test or something to ensure
> > this
> > doesn't introduce regressions (I recollect mdio wasn't stable on
> > beagleplay) and switching to bitbang driver stopped all complains.
> 
> I can do a longer test with that over the weekend sure; For reference
> I'm seeing issues in u-boot as well on initial probe with these
> changes, but i've not seen the same on the linux side.
> 
> Do you remember with what kernel versions users saw the mdio
> instabilities? I wonder if that was a version with the commit mentioned
> that includes the errata fix for the mdio driver.
> 

we were on TI 5.10 kernel (the image that went into production) and it
did have errata fix (I am not sure if it is similar or same as what
finally went into upstream now).. I have started an automated multiple
boot test on my end as well..

The signature as I recollect was spurious link Down and Up logs
(though the cable is not physically disconnected).. been a bit of
time.. so my memory on exact signature might be vague.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D