Received-SPF: pass (google.com: domain of linux-kernel+bounces-24749-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Dan Carpenter' <dan.carpenter@linaro.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Linus
 Torvalds" <torvalds@linux-foundation.org>, 'Andy Shevchenko'
	<andriy.shevchenko@linux.intel.com>, 'Andrew Morton'
	<akpm@linux-foundation.org>, "'Matthew Wilcox (Oracle)'"
	<willy@infradead.org>, 'Christoph Hellwig' <hch@infradead.org>, "'Jason A.
 Donenfeld'" <Jason@zx2c4.com>
Subject: RE: [PATCH next v4 1/5] minmax: Add umin(a, b) and umax(a, b)
Thread-Topic: [PATCH next v4 1/5] minmax: Add umin(a, b) and umax(a, b)
Thread-Index: AdnqCG3fyWBHnOXsRX2exERoRDa2+hbTWv2AAAC2xJAAAdpggAAAPeZw
Date: Fri, 12 Jan 2024 14:26:33 +0000
Message-ID: <d05f91a308174cf0b3e5707625a212bc@AcuMS.aculab.com>
References: <b97faef60ad24922b530241c5d7c933c@AcuMS.aculab.com>
 <41d93ca827a248698ec64bf57e0c05a5@AcuMS.aculab.com>
 <737627fd-b68b-4c9d-8700-f0e0d6d9cec8@moroto.mountain>
 <8e45b321c49b4c27a61b2db076ed5383@AcuMS.aculab.com>
 <02701430-65cf-44ab-8a8b-752c5d973d21@moroto.mountain>
In-Reply-To: <02701430-65cf-44ab-8a8b-752c5d973d21@moroto.mountain>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Dan Carpenter
> Sent: 12 January 2024 14:03
>=20
> On Fri, Jan 12, 2024 at 01:40:30PM +0000, David Laight wrote:
> > From: Dan Carpenter
> > > Sent: 12 January 2024 12:50
> > >
> > > On Mon, Sep 18, 2023 at 08:16:30AM +0000, David Laight wrote:
> > > > +/**
> > > > + * umin - return minimum of two non-negative values
> > > > + *   Signed types are zero extended to match a larger unsigned typ=
e.
> > > > + * @x: first value
> > > > + * @y: second value
> > > > + */
> > > > +#define umin(x, y)=09\
> > > > +=09__careful_cmp((x) + 0u + 0ul + 0ull, (y) + 0u + 0ul + 0ull, <)
> > >
> > > Why do we match "a larger unsigned type" instead of ULL_MAX?  Presuma=
bly
> > > it helps performance somehow...  I agree that it's probably fine but =
I
> > > would be more comfortable if it skipped UINT_MAX and jumped directly =
to
> > > ULONG_MAX.  These days 4 gigs is small potatoes.  The vmalloc() funct=
ion
> > > can allocate 4G so we've had integer overflow bugs with this before.
> >
> > The '+ 0ul*' carefully zero extend signed values without changing
> > unsigned values.
> > The compiler detects when it has zero-extended both sides and
> > uses the smaller compare.
> > In essence:
> > =09x + 0u converts 'int' to 'unsigned int'.
> > =09=09Avoids the sign extension adding 0ul on 64bit.
> > =09x + 0ul converts a 'long' to 'unsigned long'.
> > =09=09Avoids the sign extension adding 0ull on 32bit
> > =09x + 0ull converts a 'long long' to 'unsigned long long'.
> > You need all three to avoid sign extensions and get an unsigned
> > compare.
>=20
> So unsigned int compares are faster than unsigned long compares?
>=20
> It's just sort of weird how it works.
>=20
> =09min_t(unsigned long, -1, 10000000000)); =3D> 10000000000
> =09umin(umin(-1, 10000000000)); =3D> UINT_MAX
>=20
> UINT_MAX is just kind of a random value.  I would have prefered
> ULONG_MAX, it's equally random but it's more safe because nothing can
> allocate ULONG_MAX bytes.

umin() is only defined for non-negative values.
So that example is really outside the domain of the function.

Consider:
=09int x =3D some_positive_value;
=09unsigned long long y;
then:
=09min_t(unsigned long long, x, y);
=09Does (unsigned long long)x which is (unsigned long long)(long long)x
=09and requires that x be sign extended to 64bits.
=09On 32bit that is quite horrid.
whereas:
=09umin(x, y);
=09Only has to zero extend x.
=09So is compiled as:
=09=09y:hi || y:lo > x ? x ; y

If both values are 32bit the compiler generates a 32bit compare
(even on 64bit).

=09David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)