Received-SPF: pass (google.com: domain of linux-kernel+bounces-24754-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: io-uring@vger.kernel.org,  kernel-janitors@vger.kernel.org,  Jens Axboe
 <axboe@kernel.dk>,  Pavel Begunkov <asml.silence@gmail.com>,  LKML
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] io_uring: Improve exception handling in
 io_ring_ctx_alloc()
In-Reply-To: <49ecda98-770d-455e-acd7-12d810280fdd@web.de> (Markus Elfring's
	message of "Wed, 10 Jan 2024 21:50:15 +0100")
References: <6cbcf640-55e5-2f11-4a09-716fe681c0d2@web.de>
	<aa867594-e79d-6d08-a08e-8c9e952b4724@web.de>
	<878r4xnn52.fsf@mailhost.krisman.be>
	<b9c9ba9f-459e-40b5-ae4b-703dcc03871d@web.de>
	<49ecda98-770d-455e-acd7-12d810280fdd@web.de>
Date: Fri, 12 Jan 2024 11:30:21 -0300
Message-ID: <87frz2k4jm.fsf@mailhost.krisman.be>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Markus Elfring <Markus.Elfring@web.de> writes:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 10 Jan 2024 21:15:48 +0100
>
> The label =E2=80=9Cerr=E2=80=9D was used to jump to a kfree() call despit=
e of
> the detail in the implementation of the function =E2=80=9Cio_ring_ctx_all=
oc=E2=80=9D
> that it was determined already that a corresponding variable contained
> a null pointer because of a failed memory allocation.
>
> 1. Thus use more appropriate labels instead.
>
> 2. Reorder jump targets at the end.
>

As I mentioned on v1, this doesn't do us any good, as kfree can handle
NULL pointers just fine, and changes like this becomes churn later when
backporting or modifying the code.

--=20
Gabriel Krisman Bertazi