Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2342889rdd; Fri, 12 Jan 2024 06:51:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHO1J5E/M1gvU4gpPY4W0yLu5q+A4t6JDMFzp5hJ20dR0bFeYRfsivOtrL02570I3J1WIq8 X-Received: by 2002:a05:6870:55d0:b0:204:16:8e82 with SMTP id qk16-20020a05687055d000b0020400168e82mr1786647oac.57.1705071115952; Fri, 12 Jan 2024 06:51:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705071115; cv=none; d=google.com; s=arc-20160816; b=THZOntBhNSKXIE+FFlRqHsmiEbLI8IbYHde+iMpHpu25jKhrANHVsJBFJhqi/2INGY 3uP0m1s2Kj6Ca+PPl2Iq7N9LlcpG/85cKFkUK9LbtrTrvtC1jducGpZCfnkjXczWPVwy y7IO+LcDjA84YAWZikbrw+fPyNouzUscwC9Il1BTPWEOvyA0JCiTZQfQJyAFnnz9InJz yi/9UvHKcgIMCVi5TuIIJ4AaBytLoALuIXgs1RtDG5Nf/YZ1LaWMEfSwqZZb5jP4OBzK CSy+5Mew9NMlXauu9Ux4qF0qf1uLhxTcKquX6QuXI28JJ9MdQG2LW2fw4E+Q/aPHaoB5 qRWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=TOSFjCkguS/KVsZYh402qjCoXFgnZrrR1wyDruqxevI=; fh=3D6wY5hYhBNCmrOV7BdxyToiH87V1FqI0MTEDRmwq08=; b=HcgjtTJ5vtm9+w7KTcyKkZPBCji9OFaduvSvXuzc/IZ+ThBcjJU/WNFripDIa4O4G+ SMtw/VgOyPSHwGEdrmnDS8gH2tXedv08pJFVLxSNbZPMIBbn1aJecmzfculSiHZ4v2Ox NLdcAjCzNsGEaBF0esITxAVuIuaChcn3IEtEl6BdnI7cJB1sQ9lGdspAfoDxrgxlxZqL YBFstiCyXglPeHMZOG1eVA9jS7GbOz/mABQumoRqksnAw9iWviLvFcppyLBwCKicWKHz fnNh3fFa1JC5n8pMt/RRHn1M6e8HGGv+U9r1GqqmyoBxSegKSO/KbLGOOabQKFHiDJt3 pNRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mdy1ArtD; spf=pass (google.com: domain of linux-kernel+bounces-24770-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24770-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cm24-20020a056a020a1800b005cdf9923679si3638348pgb.727.2024.01.12.06.51.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 06:51:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24770-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mdy1ArtD; spf=pass (google.com: domain of linux-kernel+bounces-24770-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24770-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1ADD1287BE4 for ; Fri, 12 Jan 2024 14:51:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C55F86E2BD; Fri, 12 Jan 2024 14:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Mdy1ArtD" Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA351E529 for ; Fri, 12 Jan 2024 14:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40e5f615a32so18028355e9.1 for ; Fri, 12 Jan 2024 06:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705071098; x=1705675898; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TOSFjCkguS/KVsZYh402qjCoXFgnZrrR1wyDruqxevI=; b=Mdy1ArtDVT6LoTJsKsXKfcjjVA8Yi8hWXDT8KDppI7J6rp833w6+5Ik1C2N8FyqKfC e7TmZsg8+diobUaNGYuu4LuiIIwA5wsv2wlpgOZJ4sxJPQGOEt2rWEJwTiPLHK5UWWZH czw019XWvML0oMEzj/qmZ8xL/OeTn34ROLKIyLfGqLVA6WfMfijwh0FiEX5W6FHkVDtg OQhq5en1Y+Ckbev6qo8metr7ynQ9eMWeiupg/lSvV8z22aJzpFibNe7OBmkPMK2Q5G19 aiBR2c2rKfoeEMhH0P1Bqz8MvkRTC2jN2zhWsk93nxYLdi3j5YMU9BRhmuAk8U+qyvf3 IOnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705071098; x=1705675898; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TOSFjCkguS/KVsZYh402qjCoXFgnZrrR1wyDruqxevI=; b=nXYOfSeblS88XcYs5qLxJlbWuzM7KgMDXMyB6m4CsoEBVwMvPCXmdKkQbxLwNDucI1 Hfbj5kcbgxM2deXcWQkb8TU0mHRlnLd/ngTTYXQPkLt5onoNzX/Ex5W5rFGnaHHzIilt AdSPV3Ny1rudbXJoq+bliGu98ea17c9N1pA8uwfASwiwaLEgS0hhwzB2OGaDzib3VLCg KPLfQfwj9joWL0U7rdsD0aeGiYGzUdQZQHy6Qznp0cQor4AaskTJJOg8ACkkYxCcyoh/ 775OjdASX0lf8gaDF9vzmTRshE9GJmAUxyuQffuCFzUrhg1v3VMxH6RowhHNZ6xP+QXA XVoA== X-Gm-Message-State: AOJu0Yyl/Dy4pcDkpMAqcetjuV7VYfSsDl6Pg7rquOUaBFa2+1YVP2lU rrfXH9IXVLki5hojGBqFoWZPlK4q4yoXyw== X-Received: by 2002:a05:600c:2101:b0:40e:5afe:a42e with SMTP id u1-20020a05600c210100b0040e5afea42emr429172wml.247.1705071098722; Fri, 12 Jan 2024 06:51:38 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id s17-20020a05600c45d100b0040d3db8186fsm6136405wmo.5.2024.01.12.06.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jan 2024 06:51:38 -0800 (PST) Message-ID: <84366aa2-e51e-4bce-a9d5-2420f1d9db0c@linaro.org> Date: Fri, 12 Jan 2024 15:51:36 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] arm64: dts: qcom: ipq9574: Add PPE device tree node Content-Language: en-US To: Jie Luo , Dmitry Baryshkov Cc: andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_suruchia@quicinc.com, quic_soni@quicinc.com, quic_pavir@quicinc.com, quic_souravp@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com References: <20240110112059.2498-1-quic_luoj@quicinc.com> <20240110112059.2498-2-quic_luoj@quicinc.com> <6fc9e65a-709a-4923-b0b3-7c460199417a@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <6fc9e65a-709a-4923-b0b3-7c460199417a@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/01/2024 15:40, Jie Luo wrote: >> >> From the first glance, the bindings do not follow upstream principles. >> You have all the settings (tdm, port config, etc) in the DT, while >> they should instead go to the driver. Well, unless you expect that the >> board might need to override them. >> > Hi Dmitry, > The TDM configuration varies per SoC type, since the ethernet port > capabilities of the SoCs vary. So we will have two different TDM > configurations for IPQ5332 and IPQ9574 SoC. The driver also will > need to support future SoC, so we choose to configure this from the > DTSI. The same reason applies to the port scheduler config as well. Your statements here confirm Dmitry suggestion, so these are not board specific and should go to the driver. Please read again Dmitry's sentences. Best regards, Krzysztof