Received-SPF: pass (google.com: domain of linux-kernel+bounces-24777-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <efe2a897-4af0-4204-8105-1bee7d6b9380@moroto.mountain>
In-Reply-To: <efe2a897-4af0-4204-8105-1bee7d6b9380@moroto.mountain>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 12 Jan 2024 15:56:31 +0100
Message-ID: <CAJZ5v0isUXAPq0Vh-RU0iopes_4r7KaejgqgFpzRT_zeZySDBQ@mail.gmail.com>
Subject: Re: [PATCH] thermal/debugfs: Unlock on error path in thermal_debug_tz_trip_up()
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, 
	Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 3:30=E2=80=AFPM Dan Carpenter <dan.carpenter@linaro=
org> wrote:
>
> Add a missing mutex_unlock(&thermal_dbg->lock) to this error path.
>
> Fixes: 4731c8f16a0e ("thermal/debugfs: Add thermal debugfs information fo=
r mitigation episodes")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/thermal/thermal_debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_=
debugfs.c
> index a3fa09235da1..a3f06029fc54 100644
> --- a/drivers/thermal/thermal_debugfs.c
> +++ b/drivers/thermal/thermal_debugfs.c
> @@ -591,7 +591,7 @@ void thermal_debug_tz_trip_up(struct thermal_zone_dev=
ice *tz,
>         if (!tz_dbg->nr_trips) {
>                 tze =3D thermal_debugfs_tz_event_alloc(tz, now);
>                 if (!tze)
> -                       return;
> +                       goto unlock;
>
>                 list_add(&tze->node, &tz_dbg->tz_episodes);
>         }
> @@ -619,6 +619,7 @@ void thermal_debug_tz_trip_up(struct thermal_zone_dev=
ice *tz,
>                 (temperature - tze->trip_stats[trip_id].avg) /
>                 tze->trip_stats[trip_id].count;
>
> +unlock:
>         mutex_unlock(&thermal_dbg->lock);
>  }
>
> --

Applied, thanks!