Received-SPF: pass (google.com: domain of linux-kernel+bounces-24796-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8dee1738-0bde-48fb-bd0e-b8d06b609677@ti.com>
Date: Fri, 12 Jan 2024 20:53:32 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net: can: Add support for aliases in CAN
To: Marc Kleine-Budde <mkl@pengutronix.de>, Bhavya Kapoor <b-kapoor@ti.com>
CC: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-can@vger.kernel.org>, <mailhol.vincent@wanadoo.fr>,
        <rcsekar@samsung.com>, <pabeni@redhat.com>, <kuba@kernel.org>,
        <edumazet@google.com>, <davem@davemloft.net>, <wg@grandegger.com>,
        <vigneshr@ti.com>
References: <20240102102949.138607-1-b-kapoor@ti.com>
 <20240102-chop-extending-b7dc1acaf5db-mkl@pengutronix.de>
Content-Language: en-US
From: "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20240102-chop-extending-b7dc1acaf5db-mkl@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Marc

On 1/2/2024 4:43 PM, Marc Kleine-Budde wrote:
> On 02.01.2024 15:59:49, Bhavya Kapoor wrote:
>> When multiple CAN's are present, then names that are getting assigned
>> changes after every boot even after providing alias in the device tree.
>> Thus, Add support for implementing CAN aliasing so that names or
>> alias for CAN will now be provided from device tree.
> NACK, please use udev or systemd-networkd to provide stable names for
> CAN interfaces.

Would you like to re-consider this NACK.

 From kernel side,

IMO if aliasing is set in device tree then kernel should provide 
consistent baseline names.

However, distributions may choose different or other stable naming,

Also, if some distribution want to rely on kernel naming they still can do.

Thanks

>
> regards,
> Marc
>