Received-SPF: pass (google.com: domain of linux-kernel+bounces-24812-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Jan 2024 08:35:49 -0700
From: Alex Williamson <alex.williamson@redhat.com>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: diana.craciun@oss.nxp.com, eric.auger@redhat.com,
 Bharat.Bhushan@nxp.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/fsl-mc: Remove unnecessary free in
 vfio_set_trigger
Message-ID: <20240112083549.04db8f8a.alex.williamson@redhat.com>
In-Reply-To: <20240112072128.141954-1-chentao@kylinos.cn>
References: <20240112072128.141954-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 12 Jan 2024 15:21:28 +0800
Kunwu Chan <chentao@kylinos.cn> wrote:

> 'irq->name' is initialed by kasprintf, so there is no need
> to free it before initializing.

This is just as bogus as the vfio-platform version.  Thanks,

Alex
 
> Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
>  drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> index d62fbfff20b8..31f0716e7ab3 100644
> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> @@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev,
>  	hwirq = vdev->mc_dev->irqs[index]->virq;
>  	if (irq->trigger) {
>  		free_irq(hwirq, irq);
> -		kfree(irq->name);
>  		eventfd_ctx_put(irq->trigger);
>  		irq->trigger = NULL;
>  	}