Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2382414rdd; Fri, 12 Jan 2024 07:52:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHDgHpXedkI87IdobFCItQYQVuNfGTqAuy5J4drnXMr7XNkHC43r9GOBdj2RD9OHAouOl+ X-Received: by 2002:a17:903:2444:b0:1d4:4e13:6b59 with SMTP id l4-20020a170903244400b001d44e136b59mr1295673pls.45.1705074725065; Fri, 12 Jan 2024 07:52:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705074725; cv=none; d=google.com; s=arc-20160816; b=W6SNdTArbzNRlk0AYRkosY8p3qWpgnJzeVQe98U4viNI4pSArk0UZZk1INq72Rj+im AwPUQCbYXY66zRl89xPMGJMajQA4Oj8whfc5jt74B7sVg+rY1V/rEMGwHstROkZ3jI2o aicNZmjLb7za5X25AZdPU8Hn9te1kkIQrnYMVLRvq7GGwrxWfiM45kx/1w289OgzXCo5 hbjoKNNUQwW8YWpOxmtGk/otqQKiGlASrTzseCoiUf0cQeCulGXAsPYqyO3uGW9j8hUM EZp5VOstINBpoMoBHWXKmLvQ/GaGw0GniZTEn8iAof856HPmgTm6YQLyOJQ3YFyqv7ZZ T6Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=godOMp+xB/8b+SwNVvmIz5aXGAQrkx1QMjaDlquO9Jc=; fh=AGrrcLa6YXQdopeDNwqz20HUo/dEput9mBxLHBRZKo0=; b=zWGutXImLOL2WOIBhFxtj5Fktk1gy8Y6ydokkiL/NHibQCivDie7xgIcdhvDivOmi/ OAVymJN1a68PPI4/bE9TAziEShRSNqAdZiTg9ctEYqKVei4LMDcGxEaCKI9i07TcY3J4 zaJsCQzI1qrU1uKYnYA5L5X6lIK4WckfRvUBW60iLuKKJvcuOr1k8aQ17jmd+pK/hEUt 29ceYKYMuTJ8LtVZ96bfagA6gLrxJUdC5WB4F3YSUl8rGZbfiQO+PUROgdCfBfQcEyDL ZRQUKUit+tMOMXM3ACLkR4dPeZ3caBPm8oLjvQt01D/ptSqtDSEXd4o7uE1A76X5/W3q WGMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=eHPoiG6N; spf=pass (google.com: domain of linux-kernel+bounces-24829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id l10-20020a170902f68a00b001d510c1285bsi3751653plg.325.2024.01.12.07.52.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 07:52:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=eHPoiG6N; spf=pass (google.com: domain of linux-kernel+bounces-24829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B099AB24105 for ; Fri, 12 Jan 2024 15:50:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E136F73180; Fri, 12 Jan 2024 15:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="eHPoiG6N" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D2C6EB6E; Fri, 12 Jan 2024 15:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40CEhLdd009370; Fri, 12 Jan 2024 15:49:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=godOMp+xB/8b+SwNVvmIz5aXGAQrkx1QMjaDlquO9Jc=; b=eH PoiG6N3Z2r7zwDho/Kv/Xbcmza0okC+lwRUpP/vTKuSS5n1EZNU+vjLsbfJk8Ox5 hRcocNO+5nvsRbhaer3Ip0PFBVusfMmjNhIWt5nWvJ/FvKTh/CMGSJLBLUfitB2I TdwAHyQdS705MYTeFF58LxyeN7AcFQo5USMQpcXU14WWFl9LRsAhuUObsn26tiWd sBuwpr8lWzKjbZJ+VbysqjyWNHUE6c10+6x9IZvnD6fCyEAInMLaVfIpJqv86GFQ tWLHgAY7qEiMBtjyen5D4b5nZtA5jwcEpe2jhBDAdv/IcDPnVwfxG1XxpsP+6Cc5 y6vdR2ame3JkNQcLWOsw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vk6ee88y6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 15:49:51 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40CFnowV017974 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jan 2024 15:49:50 GMT Received: from [10.253.78.164] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 12 Jan 2024 07:49:37 -0800 Message-ID: <29d744c3-b06b-4959-acc1-288b2804356d@quicinc.com> Date: Fri, 12 Jan 2024 23:49:35 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 00/20] net: ethernet: Add qcom PPE driver Content-Language: en-US To: Simon Horman , Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20240110114033.32575-1-quic_luoj@quicinc.com> <20240110154414.GH9296@kernel.org> From: Jie Luo In-Reply-To: <20240110154414.GH9296@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ybGN_sbOMlh8_paMCeNBYLvIpmaTQ9IS X-Proofpoint-GUID: ybGN_sbOMlh8_paMCeNBYLvIpmaTQ9IS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 impostorscore=0 mlxscore=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401120124 On 1/10/2024 11:44 PM, Simon Horman wrote: > On Wed, Jan 10, 2024 at 01:24:06PM +0100, Krzysztof Kozlowski wrote: >> On 10/01/2024 12:40, Luo Jie wrote: >>> The PPE(packet process engine) hardware block is available in Qualcomm >>> IPQ chipsets that support PPE architecture, such as IPQ9574 and IPQ5332. >>> The PPE includes integrated ethernet MAC and PCS(uniphy), which is used >>> to connect with external PHY devices by PCS. The PPE also includes >>> various packet processing offload capabilities such as routing and >>> briding offload, L2 switch capability, VLAN and tunnel processing >>> offload. >>> >>> This patch series enables support for the PPE driver which intializes >>> and configures the PPE, and provides various services for higher level >>> network drivers in the system such as EDMA (Ethernet DMA) driver or a >>> DSA switch driver for PPE L2 Switch, for Qualcomm IPQ SoCs. >> >> net-next is closed. > > Also, please try to avoid sending patch-sets with more than 15 patches > for net or net-next. > > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#dividing-work-into-patches Got it, at a later point when this review resumes, we will split the PPE driver patches into two series, one is for PPE switch core feature, another is for MAC/UNIPHY features. Hope this is fine. Thanks for this comment.