Received-SPF: pass (google.com: domain of linux-kernel+bounces-24841-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 12 Jan 2024 11:06:01 -0500
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh@kernel.org, alexandre.belloni@bootlin.com,
	conor.culhane@silvaco.com, gregkh@linuxfoundation.org,
	imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, miquel.raynal@bootlin.com,
	zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c:
 silvaco,i3c-target-v1
Message-ID: <ZaFjaWCA6k+tiCSJ@lizhi-Precision-Tower-5810>
References: <20240110175221.2335480-1-Frank.Li@nxp.com>
 <20240110175221.2335480-3-Frank.Li@nxp.com>
 <3c0be658-e7a6-4231-b206-86ffb47e0cb2@linaro.org>
 <ZaFbbeQrC7o2dchO@lizhi-Precision-Tower-5810>
 <e3b9aa63-25a5-41cc-9eb7-6e7d1eacb136@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e3b9aa63-25a5-41cc-9eb7-6e7d1eacb136@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kHita5PIxOlpCgCuWiHXoMym+IaHz4kve5cAtI2YSAk+ofPZnR4WbNGeQQLf?=
 =?us-ascii?Q?EWScRGIhDjGEEJeBu86wX2Y9+psf/TUDByLiqvz+CzEEm0D5pL1kj1q52tsl?=
 =?us-ascii?Q?IVmB69SmQ2t+2esa3hVwTve5NEyfDsTirW5amv4d+UFACdcK0zLlGKtlrvDF?=
 =?us-ascii?Q?PIynMAopFNt6QWS1l0/OA3OUJZOgjVlS6iL8rEB+yL5uJZICIlVSqw0LEgtI?=
 =?us-ascii?Q?Vf2vVf5LU/Y8aNtF1PuMfOEr2cZUwN7nkD+2gAMvua8n7ymvipu+Qbs/y+B8?=
 =?us-ascii?Q?dqUQmr3VCfxnmVnnPelsbI9YS7XIYGSM3s8f+LyCPzdWmQUnzJi0bouiGT4I?=
 =?us-ascii?Q?hpEiJDmL69re+JbSrb0IZ3ZiIZ+PvZLiPFy/dyU8Nm9DXN4iyw/DHbnG5tWm?=
 =?us-ascii?Q?C8cVF5E718ra4Vb+SbrjynXaZEQqRS84YBFDh36z+JR6imNpRkpwBS7MnfA2?=
 =?us-ascii?Q?MpqZT9GEnyOez7z8jNEKO5581tbvniFIZl/sOQHfv81T5jGE36duT50lYxZQ?=
 =?us-ascii?Q?cJKTRPtFWQTnA6kR8FSBgJA/3lsNweJmaAes5chF1sr2wBapSoR1OH0DVDC3?=
 =?us-ascii?Q?rHbvdQ2lrAFo56e40wmWmEZaXIxKi9zVBn4d8VMRlaj6XPDD7/96RrhhO1/l?=
 =?us-ascii?Q?SH5oUWixKrlbc8xHVITU7a8Xz8y8paOfq6AF+VcvF/A14K6cGIgxKiZ+mSeE?=
 =?us-ascii?Q?xmPkw8R06u/4HMcnslBHr/BO0PcFJQJ4VpT/R7oQ5flTdocBiejHbQLgLa7t?=
 =?us-ascii?Q?8BlOczNiroiWx5DBGdMAM0e8IuJMHJsZi9GKL7HyRY9i0TSbApyv2Muv3ktB?=
 =?us-ascii?Q?flIXq1NALh4fVWdZYi4az58AtUQAu69Nn4/9OCZbvPUN7ZB0SPz0LU6NWAHo?=
 =?us-ascii?Q?yxQzaOaqSgMN63zQBBQ8GB6/E3HihWSRYwmPbg1oX2fFaRyy7SdTHea6htEJ?=
 =?us-ascii?Q?lcsWb49ugEk8YTwrH+3XIUvzRoEtjYGtSKeaUgUoEuHJVrahSVBMAQfpHldy?=
 =?us-ascii?Q?fAdf5kdvu9VKvkYqMre/qEFr0XVkG9uoISTaVyYQKByLgymsYliUlMRtxPcZ?=
 =?us-ascii?Q?NVMnLh3RNY9AVLv7IYsWgTMaEPFK9pO1sk3BhT0EsT7yNj+choY2DYawhsbT?=
 =?us-ascii?Q?vopFhSWugcrcZb4A61PKs8utT/LEVoA1xAenohZ9pmcrGBXVesLnZtFi0zZ8?=
 =?us-ascii?Q?Mag20bSGadjaT7nY+xuq8/HJa3oGnaSTCXqkMoybNbryMGigqeJTZgYFiVYw?=
 =?us-ascii?Q?IBU4jbzSIl8PKT7Uqasx03NoCYHct1XvGExAVwP+pBkB7CCg95PJ9kS7m5vk?=
 =?us-ascii?Q?sE+2eOixP+60EpH10l8RihE20ia1bOSY6grmb+5IMCoxwkQbVpLHwds8sY71?=
 =?us-ascii?Q?eZ62VNHBGND3BgEpWN+9H9mPIxYA4o5Z6KXD6kXKgsxX131FSRpeoDFIKrHG?=
 =?us-ascii?Q?zQ4YAZfXXk/++5KvrgbG1k7Zu5HbtRpsc83DlBy4tiiVnIEv9rvOfZwgmo10?=
 =?us-ascii?Q?uV89xH7vXOEr9rCj0rO35tDaVFZchq7nNnj2XZKH1mKoP5zbg3snfekoUkaA?=
 =?us-ascii?Q?PVv6tmGMoKOn5gXCpd/8enNvAuNefLHY4I7BEcra?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6204ec90-a0ca-4735-e422-08dc1388646f
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB7511.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 16:06:10.2348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MSFC46ZJWitHICzQiNlEDK5Y3BXWKEXRs5DckfHgnzBboVo0Uof5wKLsBpeB3axa2rMAbTjVW0D9t1nrWheWEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8321

On Fri, Jan 12, 2024 at 04:50:25PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 16:31, Frank Li wrote:
> > I review previous comments. The previous RFC patches and I just want I3C
> > expert review to check if there are comments about whole software
> > architecture. Of course, thank you for your comments about "slave".
> > 
> > Go back this binding doc problem. 
> > 
> >   "No, it's the same device.
> > 
> >    Anyway, this was not tested.
> > 
> >    Please use scripts/get_maintainers.pl to get a list of necessary people
> >    and lists to CC. It might happen, that command when run on an older
> >    kernel, gives you outdated entries. Therefore please be sure you base
> >    your patches on recent Linux kernel.
> > 
> >    You missed at least devicetree list (maybe more), so this won't be
> >    tested by automated tooling. Performing review on untested code might be
> >    a waste of time, thus I will skip this patch entirely till you follow
> >    the process allowing the patch to be tested.
> > 
> >    Please kindly resend and include all necessary To/Cc entries.
> >    "
> > 
> > It is the same devices, work at difference mode (master  and target).
> > what's do you want to change to?
> > 
> > Copy to new file like pci/pci-ep? all context is the same, except for
> > compatible string. 
> > 
> 
> Apologies, I mixed up a bit patches, so this was not obvious. I meant
> this comment:
> 
> https://lore.kernel.org/all/20231017201404.GA2570433-robh@kernel.org/
> 
> There is no indication in your commit msg that these concerns were
> addressed.

Look like everyone already accecpted 'silvaco,i3c-master-v1'.

driver part:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=8911eae9c8a947e5c1cc4fcce40473f1f5e475cd
dts part:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b8ec0f3b42a3498d5115d1fb1490082ab525747b

Frank

> 
> Best regards,
> Krzysztof
>