Received-SPF: pass (google.com: domain of linux-kernel+bounces-24875-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 12 Jan 2024 16:58:04 +0000
From: Conor Dooley <conor@kernel.org>
To: KyuHyuk Lee <lee@kyuhyuk.kr>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Chris Morgan <macromorgan@hotmail.com>,
	Jagan Teki <jagan@edgeble.ai>, Tianling Shen <cnsztl@gmail.com>,
	Andy Yan <andyshrk@163.com>, Ondrej Jirman <megi@xff.cz>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S
 board
Message-ID: <20240112-granola-underline-36a525dc789c@spud>
References: <20240112134230.28055-1-lee@kyuhyuk.kr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="8SF8l+0YFEFPpEIl"
Content-Disposition: inline
In-Reply-To: <20240112134230.28055-1-lee@kyuhyuk.kr>


--8SF8l+0YFEFPpEIl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote:
> Add device tree binding for Hardkernel ODROID-M1S board based on
> RK3566 SoC.
>=20
> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Docume=
ntation/devicetree/bindings/arm/rockchip.yaml
> index 5cf5cbef2cf5..cc37d2118131 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -566,6 +566,11 @@ properties:
>            - const: rockchip,rk3568-odroid-m1
>            - const: rockchip,rk3568
> =20
> +      - description: Hardkernel Odroid M1S

if the vendor for this board is hardkernel...

> +        items:
> +          - const: rockchip,rk3566-odroid-m1s

=2E..why is the vendor prefix here rockchip?

Thanks,
Conor.

> +          - const: rockchip,rk3566
> +
>        - description: Hugsun X99 TV Box
>          items:
>            - const: hugsun,x99
> --=20
> 2.34.1
>=20

--8SF8l+0YFEFPpEIl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaFvnAAKCRB4tDGHoIJi
0n/AAQDkHzkEpbkEcPgsWiysuI7BEp4nrEoSAcQvm/4eChZuegD6Aztb5FfajYfD
gJvPbsipxJ9PyVMsiM5/pyUwU68MZwk=
=bjqJ
-----END PGP SIGNATURE-----

--8SF8l+0YFEFPpEIl--