Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2422461rdd; Fri, 12 Jan 2024 08:58:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyZBSLuqvRxvNX9nANghIfTyMIpDFG+BK+cqXFCYc22Ptny7L0o7aQGkGgGeL4C7Hh3UIW X-Received: by 2002:a05:6359:a02:b0:170:17eb:9c45 with SMTP id el2-20020a0563590a0200b0017017eb9c45mr1737116rwb.38.1705078734657; Fri, 12 Jan 2024 08:58:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705078734; cv=none; d=google.com; s=arc-20160816; b=ZDWfO9Tsxm9DKaV1X9Pb7OgH+VzLVQxvMHugyV8X05tE9+yBM97HuG3enDK7C7fS7k sFL5bPa0h4sa0CP3zYqUS1rCGZg+pE8P1UiDhLpk3kaKGkvxDjdRYy1lvYL1rgdpgwRb YecH9o8kkig8NlYXzEOrZOPDBtYZ4ci1EawTk91pqf6Z45R2s+8DTjWAzri7ARmb+q67 xn3cqehc5sFqPS+cutIwEnWd0QtWv75+IHuQQgzZFxEy1NRmziYWumaw05Z1KSK59eiq Th7tfeyNidjenuIdM25oaQhWOm8l/sSen+kulhV4sBvBEkLUBFi6emrHRz5NcPr3KKUl wk2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=u+lQGn74TGq7hrOXT4TkI+kQ8ytJDBxjKrUJkE5tzl4=; fh=5XYVu0MefMgUpQWyyVZ+rtZU+dglrpJSFUxxI/nZVAs=; b=ruTYHYSgWKNuy0jFGXjQaG9M9MnZJGO+ju1f/MLExywOssVMLOFdrTejORWFJwOsAZ z/xrS9sFL63Aoxf3CpgJIkxusW2zUlkQf/hXK6J4Rd7EpGNPKnrc6zlOSJqxO+++Uxk7 Ftx0h7Gv0d2OKz5mMI8WJnb538o0koc2yYGONlfu2gk28QN1XFaIxDZ2cMNQnzEge5jg OZqCTkvJQq2GGE6xvWhh/0yk829N/BRpXej7plZQqvERQRWnp/S+ap1BFt5f5RjwwZgF 0S+gXwaQTXP1+pU4PqDxG8s2SdhzhJU4e3OUGbyv1W8jkvsY4uKrIOcEHKbq16OZ84yx maVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qaWX86vl; spf=pass (google.com: domain of linux-kernel+bounces-24877-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24877-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l125-20020a632583000000b005cd98356cc5si3576591pgl.902.2024.01.12.08.58.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 08:58:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24877-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qaWX86vl; spf=pass (google.com: domain of linux-kernel+bounces-24877-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24877-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4A7F32857FC for ; Fri, 12 Jan 2024 16:58:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 99CAC17C96; Fri, 12 Jan 2024 16:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qaWX86vl" Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4045617540 for ; Fri, 12 Jan 2024 16:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6dc36e501e1so4571686a34.1 for ; Fri, 12 Jan 2024 08:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705078710; x=1705683510; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u+lQGn74TGq7hrOXT4TkI+kQ8ytJDBxjKrUJkE5tzl4=; b=qaWX86vlJlNHKDapvCjUIJO13Fb2vfor+fqeSrXYleqqEjUBux4pDDQ8QtY/bCXnjG 1e2DAyJPjvAdtcShn14coOIIqHgYVJGENXmLEtPMGnDSI093N8cPpYOXdNpCZlkKl69P T//1B4x6ldVbV7mgWvCeaQQvCoTCJtYpOLa3ileVnHQ6UikdZHm4mbP7GO+L27PIWJb8 LmCLnhVpr1gJ+xKfjhk2/uLDcyihV65wlMYwPayusKP1Y2A6Ocayg8GHh6I1HLLeUrnl BKaxLYMjZCVBAsTf7MBQc/0JvB7ZxZB07INL+ZMSrYoCm5uACzobz47vhQzzK+UdGOPU UnSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705078710; x=1705683510; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u+lQGn74TGq7hrOXT4TkI+kQ8ytJDBxjKrUJkE5tzl4=; b=JUYtXfuPGAR/0XfhJCatu/CHuqRTg3fbhfFb/wXD4JnDiUKlGj3LZIyTTKBIeylaZH cDJglFs4iW+sfg2R4tpWdw465kTvfUo4E3yJKBaUtsTcgi96xGRepJ5ZJlvobw5+YphU OlVZKmrPCIViK23vwZPjsGejD2HUEyGEhnDktE5zI72yZAKTH6eG6DnvIxU0frYk7PTh eCrRx5VvCyzRHfrZrzhMtQeEBMQroaw/pcPP+1bwYq1ob4CsnI1gEOmV8Mv9VkGtlsa7 KyL67LKkxmuGZIwBVk37VOR4mOelHxHbVHUyXtH+/xlojlN9rtwHTU1ZuYBckfyNICP2 cqaw== X-Gm-Message-State: AOJu0YzW8gvyEtvHU1VfSpRpn2GRPYG9YYs3k0jG5xzW3rx0jhVhhv5t iPBOHw3SuFerGxKi0ZhlXx9lcRARhe+JSBkLIPgcDNEDGSi7sQ== X-Received: by 2002:a05:6358:917:b0:175:97b6:af54 with SMTP id r23-20020a056358091700b0017597b6af54mr2046614rwi.15.1705078710054; Fri, 12 Jan 2024 08:58:30 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <4405adb5-0b16-4716-9542-47d8bb1737ee@arm.com> In-Reply-To: <4405adb5-0b16-4716-9542-47d8bb1737ee@arm.com> From: Vincent Guittot Date: Fri, 12 Jan 2024 17:58:18 +0100 Message-ID: Subject: Re: [GIT PULL] Scheduler changes for v6.8 To: Dietmar Eggemann Cc: Linus Torvalds , Ingo Molnar , linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , Juri Lelli , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider Content-Type: text/plain; charset="UTF-8" On Fri, 12 Jan 2024 at 15:23, Dietmar Eggemann wrote: > > On 11/01/2024 19:16, Vincent Guittot wrote: > > On Thu, 11 Jan 2024 at 18:53, Linus Torvalds > > wrote: > >> > >> On Thu, 11 Jan 2024 at 09:45, Linus Torvalds > >> wrote: > >>> > >>> On Thu, 11 Jan 2024 at 00:11, Vincent Guittot > >>> wrote: > >>>> > >>>> Could you confirm that cpufreq governor is schedutil and the driver is > >>>> amd-pstate on your system ? > >>> > >>> schedutil yes, amd-pstate no. I actually just use acpi_cpufreq > >> > >> Bah. Hit 'send' mistakenly too soon, thus the abrupt end and > >> unfinished quoting removal. > >> > >> And don't ask me why it's acpi_pstate-driven. I have X86_AMD_PSTATE=y, but > >> > >> /sys/devices/system/cpu/cpufreq/policy0/scaling_driver > >> > >> clearly says 'acpi-cpufreq'. Maybe I'm looking in the wrong place. My dmesg says > > > > That seems to be the right place to look > > > >> > >> amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled > >> > >> which is presumably the reason my machine uses acpi-pstate. > >> > >> I will also test out your other questions, but I need to go back and > >> do more pull requests first. > > > > ok, thanks > > > > I'm going to continue checking what else could trigger such regression > > having in mind that your system should not have beeb impacted by this > > changes > > I can't see the regression on my > > 20-core (40-thread) Intel Xeon CPU E5-2690 v2 > > with 'schedutil' and 'acpi-cpufreq'. Thanks for the tests > > f12560779f9d - sched/cpufreq: Rework iowait boost <- (w/ patches) > 9c0b4bb7f630 - sched/cpufreq: Rework schedutil governor performance estimation > 50181c0cff31 - sched/pelt: Avoid underestimation of task utilization <- (base) > ... > > # cpufreq-info -c 0 -e > ... > analyzing CPU 0: > driver: acpi-cpufreq > CPUs which run at the same hardware frequency: 0 > CPUs which need to have their frequency coordinated by software: 0 > maximum transition latency: 10.0 us. > hardware limits: 1.20 GHz - 3.00 GHz > available frequency steps: 3.00 GHz, 3.00 GHz, 2.90 GHz, 2.70 GHz, 2.60 GHz, 2.50 GHz, 2.40 GHz, 2.20 GHz, > 2.10 GHz, 2.00 GHz, 1.80 GHz, 1.70 GHz, 1.60 GHz, 1.50 GHz, 1.30 GHz, 1.20 GHz > available cpufreq governors: conservative, ondemand, userspace, powersave, performance, schedutil > current policy: frequency should be within 1.20 GHz and 3.00 GHz. > The governor "schedutil" may decide which speed to use > within this range. > current CPU frequency is 1.20 GHz (asserted by call to hardware). > > > cpufreq is still fast-switching, so no schedutil 'sugov' DL threads.