Received-SPF: pass (google.com: domain of linux-kernel+bounces-24880-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3915b289-2741-4b18-ab11-3c7c8e7fbac4@quicinc.com>
Date: Fri, 12 Jan 2024 09:00:43 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels
Content-Language: en-US
To: Jianhua Lu <lujianhua000@gmail.com>,
        Neil Armstrong
	<neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maarten
 Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard
	<mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie
	<airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
CC: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
References: <20240112140047.18123-1-lujianhua000@gmail.com>
From: Jessica Zhang <quic_jesszhan@quicinc.com>
In-Reply-To: <20240112140047.18123-1-lujianhua000@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/12/2024 6:00 AM, Jianhua Lu wrote:
> After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock limits")
> merged, 120Hz is working on xiaomi,elish panels, so feature it.
> 
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

> ---
>   drivers/gpu/drm/panel/panel-novatek-nt36523.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> index a189ce236328..d6fa76dbf948 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> @@ -933,8 +933,7 @@ static int j606f_boe_init_sequence(struct panel_info *pinfo)
>   
>   static const struct drm_display_mode elish_boe_modes[] = {
>   	{
> -		/* There is only one 120 Hz timing, but it doesn't work perfectly, 104 Hz preferred */
> -		.clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 104 / 1000,
> +		.clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 120 / 1000,
>   		.hdisplay = 1600,
>   		.hsync_start = 1600 + 60,
>   		.hsync_end = 1600 + 60 + 8,
> @@ -948,8 +947,7 @@ static const struct drm_display_mode elish_boe_modes[] = {
>   
>   static const struct drm_display_mode elish_csot_modes[] = {
>   	{
> -		/* There is only one 120 Hz timing, but it doesn't work perfectly, 104 Hz preferred */
> -		.clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 104 / 1000,
> +		.clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 120 / 1000,
>   		.hdisplay = 1600,
>   		.hsync_start = 1600 + 200,
>   		.hsync_end = 1600 + 200 + 40,
> -- 
> 2.41.0
>