Received-SPF: pass (google.com: domain of linux-kernel+bounces-24917-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 12 Jan 2024 18:23:45 +0100
From: Michal Hocko <mhocko@suse.com>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shakeel Butt <shakeelb@google.com>,
	Muchun Song <muchun.song@linux.dev>, Tejun Heo <tj@kernel.org>,
	Dan Schatzberg <schatzberg.dan@gmail.com>, cgroups@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol: don't throttle dying tasks on memory.high
Message-ID: <ZaF1oQyovAOMA3be@tiehlicka>
References: <20240111132902.389862-1-hannes@cmpxchg.org>
 <ZaAsbwFP-ttYNwIe@P9FQF9L96D>
 <20240111192807.GA424308@cmpxchg.org>
 <ZaFxn7JC8FeR-Si0@tiehlicka>
 <ZaFyiTFC-ped0IdA@P9FQF9L96D.corp.robot.car>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZaFyiTFC-ped0IdA@P9FQF9L96D.corp.robot.car>

On Fri 12-01-24 09:10:33, Roman Gushchin wrote:
> On Fri, Jan 12, 2024 at 06:06:39PM +0100, Michal Hocko wrote:
> > On Thu 11-01-24 14:28:07, Johannes Weiner wrote:
> > [...]
> > > @@ -2867,11 +2882,17 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask,
> > >  		}
> > >  	} while ((memcg = parent_mem_cgroup(memcg)));
> > >  
> > > +	/*
> > > +	 * Reclaim is set up above to be called from the userland
> > > +	 * return path. But also attempt synchronous reclaim to avoid
> > > +	 * excessive overrun while the task is still inside the
> > > +	 * kernel. If this is successful, the return path will see it
> > > +	 * when it rechecks the overage and simply bail out.
> > > +	 */
> > >  	if (current->memcg_nr_pages_over_high > MEMCG_CHARGE_BATCH &&
> > >  	    !(current->flags & PF_MEMALLOC) &&
> > > -	    gfpflags_allow_blocking(gfp_mask)) {
> > > +	    gfpflags_allow_blocking(gfp_mask))
> > >  		mem_cgroup_handle_over_high(gfp_mask);
> > 
> > Have you lost the check for the dying task here?
> 
> It was moved into mem_cgroup_handle_over_high()'s body.

Ohh, right. Somehow overlooked that even when I was staring at that
path.

Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

-- 
Michal Hocko
SUSE Labs