Received-SPF: pass (google.com: domain of linux-kernel+bounces-24919-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 12 Jan 2024 17:26:12 +0000
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: KyuHyuk Lee <lee@kyuhyuk.kr>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Chris Morgan <macromorgan@hotmail.com>,
	Jagan Teki <jagan@edgeble.ai>, Tianling Shen <cnsztl@gmail.com>,
	Andy Yan <andyshrk@163.com>, Ondrej Jirman <megi@xff.cz>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S
 board
Message-ID: <20240112-headsman-concur-1d47da7e3e14@spud>
References: <20240112134230.28055-1-lee@kyuhyuk.kr>
 <20240112-granola-underline-36a525dc789c@spud>
 <dc4e9808-cd36-4b99-afd9-8dd4cd16a2a9@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="BlTaGf17Fz4L1eNA"
Content-Disposition: inline
In-Reply-To: <dc4e9808-cd36-4b99-afd9-8dd4cd16a2a9@linaro.org>


--BlTaGf17Fz4L1eNA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 06:02:09PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 17:58, Conor Dooley wrote:
> > On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote:
> >> Add device tree binding for Hardkernel ODROID-M1S board based on
> >> RK3566 SoC.
> >>
> >> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
> >> ---
> >>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Doc=
umentation/devicetree/bindings/arm/rockchip.yaml
> >> index 5cf5cbef2cf5..cc37d2118131 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -566,6 +566,11 @@ properties:
> >>            - const: rockchip,rk3568-odroid-m1
> >>            - const: rockchip,rk3568
> >> =20
> >> +      - description: Hardkernel Odroid M1S
> >=20
> > if the vendor for this board is hardkernel...
> >=20
> >> +        items:
> >> +          - const: rockchip,rk3566-odroid-m1s
> >=20
> > ...why is the vendor prefix here rockchip?
>=20
> Uh, good catch. I missed it when acking their earlier mistake year ago
> :( Would be nice if they fixed that one too.

Maybe they will if they got your email, they did not get mine
apparently:
<lee@kyuhyuk.kr>: host mx02.mail.icloud.com[17.57.155.34] said: 554 5.7.1
    [HM08] Message rejected due to local policy. Please visit
    https://support.apple.com/en-us/HT204137 (in reply to end of DATA comma=
nd)


--BlTaGf17Fz4L1eNA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaF2NAAKCRB4tDGHoIJi
0m7FAQCuvT9Rcw0zZGt/yZ0NOireQ5ZqcA+Vh5bLT+YEF7jv5QD6A8iGqsl6Cz2q
UGZPQh2gBpqx2DAGHZ+yLKZv9WOaQA4=
=J3G+
-----END PGP SIGNATURE-----

--BlTaGf17Fz4L1eNA--