Received-SPF: pass (google.com: domain of linux-kernel+bounces-24927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i68a1478a:Fastmail
Date: Fri, 12 Jan 2024 11:42:02 -0600
From: Patrick Williams <patrick@stwcx.xyz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan =?iso-8859-1?Q?Neusch=E4fer?= <j.neuschaefer@gmx.net>,
	openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: nuvoton: add Facebook Yosemite
 4 board
Message-ID: <ZaF56lwEi1MES89Q@heinlein.vulture-banana.ts.net>
References: <20240112013654.1424451-1-Delphine_CC_Chiu@wiwynn.com>
 <20240112013654.1424451-2-Delphine_CC_Chiu@wiwynn.com>
 <8efef092-e70f-46c0-a60a-e62e676d6eb2@linaro.org>
 <ZaFydbPxbeczo97t@heinlein.vulture-banana.ts.net>
 <c0a83358-09a3-4c51-b8b6-6d6ea8b4f196@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="hWV98mDElNT6jKhP"
Content-Disposition: inline
In-Reply-To: <c0a83358-09a3-4c51-b8b6-6d6ea8b4f196@linaro.org>


--hWV98mDElNT6jKhP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 06:14:26PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 18:10, Patrick Williams wrote:
> > On Fri, Jan 12, 2024 at 08:10:25AM +0100, Krzysztof Kozlowski wrote:
> >> On 12/01/2024 02:36, Delphine CC Chiu wrote:
> >>> Document the new compatibles used on Facebook Yosemite 4.
> >>
> >> There is Yosemite4 board already supported. What is this for?
> >> https://lore.kernel.org/all/20240109072053.3980855-5-Delphine_CC_Chiu@=
wiwynn.com/
> >=20
> > Yosemite4 is a server chassis which is managed by a BMC.  The BMC is on
> > a pluggable module card.  Typically we've used Aspeed chips for this,
> > but we are building an alternative BMC module using Nuvoton BMC chips.
>=20
> There are few ways to solve this, like having different compatibles or
> having some shared compatibles to note common part of hardware. However
> usually the final compatible represents the final device, which here you
> use for two entirely different products. This works only for the cases
> of carrier boards, where that compatible indeed represents the same
> hardware.
>=20
> Not your case. This needs fixing.

This patch:
+	model =3D "Facebook Yosemite 4 BMC";
+	compatible =3D "facebook,yosemite4-n-bmc", "nuvoton,npcm845";

Aspeed patch:
+       model =3D "Facebook Yosemite 4 BMC";
+       compatible =3D "facebook,yosemite4-bmc", "aspeed,ast2600";

These have different compatibles already ('-n' for Nuvoton).  Do we just
need the model to be clearly different also?  Maybe there is something
else I'm not understanding.

--=20
Patrick Williams

--hWV98mDElNT6jKhP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmWheegACgkQqwNHzC0A
wRmuSg/+IUyH4CzVAeyui/NfgsYtbgD5YYyLywW9Gdl3td9rcUn702bmrtZ5t3QD
PmOf443x6sTrZqED46Sw0EiL2/6F9p09IQCfcP0xIDAilhystlZh/aIffi0N2r7Q
meD5whSSe5ur+xNd4T6Y+CW3bBzN9b2NAjhTKaX7t6b+j2otf7quEXW9yenUO8He
hEUqBwrexdtTV6PQSuPDoAbMWmUxdjrU+SFWnP7D98R2HWixaqwG/JcSDYCsrwQc
7LMiO+ICcV2POevQC7zqWKel1T3VXqZa2ShCsWJxW/hyHhl/aWWM+4cwvm6z2XwI
NmQRyfXpqMUcHDFTH3sLnG/pgc1IXbnGmmKXyLFbj97AtORkU9z0zwie6y1z6F9D
/7PY0oBS+mX0NPMHSPVMxQ2UZkUuhyDggTu5T6gdgph/mGFd0hlEWruW7CrxiTfY
z88y48PAJsUzf+fdkeVB7XRE45LPRL64b7pqQGlWbZQEwpHWIL4VDisL+W+Oj7bV
IL2v3BiKKfzt5w0yA5sA7hMhE/k3jvTKkzKqLBsVRpwq4wa5peypz0rcb685dqzZ
GOAHvvZmQaCelXfbZXne8X/cSPuzWJI/XT8MeDJuAzNa/bCVxJuMONNTECxvOMDT
xItWvlKKXLPA+P56a3As6iZAc+ynu+mYghxeKgAF9U4OXFWq0kY=
=3qaC
-----END PGP SIGNATURE-----

--hWV98mDElNT6jKhP--