Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2457342rdd; Fri, 12 Jan 2024 09:57:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEv8leMftIhfOuwOHVEGoKvpquu1EGcjRmSDmUjKQhqoD1IJb8uCxkz9G0B/6IFbIlHwpGo X-Received: by 2002:a05:6214:c2f:b0:67f:af66:c9ca with SMTP id a15-20020a0562140c2f00b0067faf66c9camr1497799qvd.72.1705082251027; Fri, 12 Jan 2024 09:57:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705082251; cv=none; d=google.com; s=arc-20160816; b=AECK0NCfF9mmP8KuJzR9ZC07cCHNETmjfQCCFPsNE1zN4GbIioNUO3uRJahqHQIlhr B8CQPp1Ersi2yz0tGyidFBWKqF8J2m9B5tBLHd78vioG6MNB69YU3rDWVOP3DNb/3R8d OKCENE5PIUy0/a8s1Xx5ImDCIR02t9OcxQqIyhWyExHF0OjBcracC5XP9lMt2XvMad5G 9caLgrvYDNm7vhbfnjObMClzSBtqL9hdm0GklWb/Vwy4B3xIxmG2neqEO1KVy/T6CE0W 7Nw+9Fqc7S/eePxrfBmo2ZRthtdKXBTJeuUnGDeBrqXFk/FfhWyKMP3//+GDh1QFyY0u B3eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=UnAM9wMRuDbUF70i1sO7UDTTR2XU4ykGa9mCuob7srE=; fh=M4QfKMvp2TkNoJWrLAEdoaUhn1sOK65/F0wXYzHQPow=; b=Dkm8ILWrhWL2GYGmQhhggjGDOL6neSPR+IKcM2wJlA3fbZcN9WyjVpMKpmp1z7hXqQ eKlXRaIgM52ihNn3LJBYYGKayCEshYnHx9SzLvVCugirLHdXZ1/AtuQlsBZAbfi5/O8u /1SSBqAj1Ne1P3n7vnRSHxFFqGCV3y1jcfJ6UVcZgdjUqHWz+4abEKbxBF2IkOCPMs4u DWSvZd84kR9rVwbOiecsVoAHR0lqI8yXAKh6i/D1+pTAgnnPzqiRhwoe2olgMVUqJ4pD zVHb6d3cHp2cLV4M1aoiB/+kgQEbgN715R0mCCAE279J1CqwFsYLAsfMuI6vjlHsRegf u1Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="f0/8IGu6"; spf=pass (google.com: domain of linux-kernel+bounces-24945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24945-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id e16-20020a0caa50000000b0067f87fc5e9bsi3192741qvb.136.2024.01.12.09.57.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 09:57:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="f0/8IGu6"; spf=pass (google.com: domain of linux-kernel+bounces-24945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24945-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B4C911C2258A for ; Fri, 12 Jan 2024 17:57:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F4AF1AADF; Fri, 12 Jan 2024 17:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f0/8IGu6" Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23CD71AAD2; Fri, 12 Jan 2024 17:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-336897b6bd6so6275125f8f.2; Fri, 12 Jan 2024 09:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705082222; x=1705687022; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UnAM9wMRuDbUF70i1sO7UDTTR2XU4ykGa9mCuob7srE=; b=f0/8IGu6il5N5X2KjxDfjSTrIpVFA0ZjDkmQ7SJrH1sgC4sKteZXTTPA5mRjIzRxE4 TslEKLToHFeYCeqMJE/z9Y74E7iYYaebMys1XhD1E0Of/hNwlC/b7Q5uTZfXNKKHjqub A968wCZJY3/2oUQeNTuIPZP0me29KtyP1unHzQmYVi1QUrZiFrhjR80XgbozjCXyIqvQ BMKf+5XvL5JYXMEvpOlC3SYCm0xyp4Xcr3mzerUh1riYWqF3HI9QcWmrwAigQk/OIpUa yyX5LwuLNxGSX9iZc5EAaHU6tgft6ZTnGW1KnNUzz3s2Wm43Xce23mkoqXDT0uAe5yk2 YSCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705082222; x=1705687022; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UnAM9wMRuDbUF70i1sO7UDTTR2XU4ykGa9mCuob7srE=; b=b6B8Q7Dtphfp4pagLTcPCeNJyKOgOlGzvv7mawOBOaugu0vIa71PXMFByo2IblirS6 ZhUpJlKqEz1Ah1bOBVY5YBmY1g1t2kSX7mOpt+ElP9kBXUd+64AhxgoDckrXVez6MWXA 5FWP/SX4H1RMRXahr/me79mycTxuNnoi9s5T7O9MgvHjK+1K9ItrPsI/vUvCibMEgdHE zxH4uPpKLDVYImeN15TTNd6z+Qp+PU8uQLE1hUztQ5Vktw/chv3+Sdu48uz796vVtvTu 3+/6qyhMlZGiWkVcaJ9kxuLRiIvMNGGIXmKbg0sDLnz8XUWK0UP2guVTKUx+S8n/mAR3 Om9w== X-Gm-Message-State: AOJu0YxRDhaiqR+BE+KhrACb2bxFsRGqI6bwSeq25iUdW4hEFMOdasEC rheOO7zcIczg8EvnFDjejOhEjay8Nw9FrUbBIsue/BAo X-Received: by 2002:adf:f48a:0:b0:337:7086:b70c with SMTP id l10-20020adff48a000000b003377086b70cmr975292wro.81.1705082222188; Fri, 12 Jan 2024 09:57:02 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240112152011.6264-1-sunhao.th@gmail.com> In-Reply-To: <20240112152011.6264-1-sunhao.th@gmail.com> From: Alexei Starovoitov Date: Fri, 12 Jan 2024 09:56:50 -0800 Message-ID: Subject: Re: [PATCH v3 1/2] bpf: Reject variable offset alu on PTR_TO_FLOW_KEYS To: Hao Sun Cc: bpf , Willem de Bruijn , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Eddy Z , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 7:20=E2=80=AFAM Hao Sun wrote= : > > For PTR_TO_FLOW_KEYS, check_flow_keys_access() only uses fixed off > for validation. However, variable offset ptr alu is not prohibited > for this ptr kind. So the variable offset is not checked. Why resend v3? What changed from v2?