Received-SPF: pass (google.com: domain of linux-kernel+bounces-24948-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240112152011.6264-1-sunhao.th@gmail.com> <CAADnVQK4S2roFHP6W+PwT6+CjcCaUVzTHGHs39bwZPU00PEh8w@mail.gmail.com>
In-Reply-To: <CAADnVQK4S2roFHP6W+PwT6+CjcCaUVzTHGHs39bwZPU00PEh8w@mail.gmail.com>
From: Hao Sun <sunhao.th@gmail.com>
Date: Fri, 12 Jan 2024 19:02:09 +0100
Message-ID: <CACkBjsaO126d1tb-6GpPe62dkqfT7ZynhkWW_WzCaz1AHiY1Tg@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] bpf: Reject variable offset alu on PTR_TO_FLOW_KEYS
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Willem de Bruijn <willemb@google.com>, 
	Alexei Starovoitov <ast@kernel.org>, Andrii Nakryiko <andrii@kernel.org>, 
	Daniel Borkmann <daniel@iogearbox.net>, Eddy Z <eddyz87@gmail.com>, 
	LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 12, 2024 at 6:57=E2=80=AFPM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Fri, Jan 12, 2024 at 7:20=E2=80=AFAM Hao Sun <sunhao.th@gmail.com> wro=
te:
> >
> > For PTR_TO_FLOW_KEYS, check_flow_keys_access() only uses fixed off
> > for validation. However, variable offset ptr alu is not prohibited
> > for this ptr kind. So the variable offset is not checked.
>
> Why resend v3?
> What changed from v2?

Nothing changes in the first patch, the tests in the second patch are
reformatted
with a proper number of tabs after each instruction. Forgot to add changelo=
gs.