Received-SPF: pass (google.com: domain of linux-kernel+bounces-24990-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4c5bb5ac-1e84-4021-845d-cafea5a1fbde@intel.com>
Date: Fri, 12 Jan 2024 11:02:56 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] x86/resctrl: Read supported bandwidth sources
 using CPUID command
Content-Language: en-US
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<seanjc@google.com>, <kim.phillips@amd.com>, <jmattson@google.com>,
	<ilpo.jarvinen@linux.intel.com>, <jithu.joseph@intel.com>,
	<kan.liang@linux.intel.com>, <nikunj@amd.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<rick.p.edgecombe@intel.com>, <rppt@kernel.org>,
	<maciej.wieczor-retman@intel.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <eranian@google.com>,
	<peternewman@google.com>, <dhagiani@amd.com>
References: <20231201005720.235639-1-babu.moger@amd.com>
 <ba1305bf2a29ce2667d01cf997718126a7ea607b.1705009003.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ba1305bf2a29ce2667d01cf997718126a7ea607b.1705009003.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0JuTFpNYjd3a1VGaGtNMllqeElJRWtzVkNaaHZqWG53WUJEUlRPRklQNGI2?=
 =?utf-8?B?dk9RdjBjTWVFY1NtZkVjcG1LbXZLTzBDM1JieUJyYUJZeUI2Si9GRThPYkp5?=
 =?utf-8?B?NWJSY2dQUjRCWWhoY0RZWnd2dGEzQld2bW42bmJGZ0RpRExEaU1jK0dWRGNH?=
 =?utf-8?B?bWE0OTgwYVpIMXFoRnRKVklWai9LOXg0UXVGcFI1OEZjbmxnazFmMDUwdHNi?=
 =?utf-8?B?ZTZ0NU5RWGo3YkdGOStXUXF2Wk1MYmZ6Y3dyQW1aeGt2S05EY0ExL2tpTmxW?=
 =?utf-8?B?N2tzYUdDNjhob21uQ2dNSnk4RnY0TERZeTdNbDFET2Y4WFlBMWxBSlVONXJu?=
 =?utf-8?B?bkIrOWRlZHpnbTNneVVkQXdlalFyY0NQVDBTeFJiV1ByL0V4dVRQWUprTmx2?=
 =?utf-8?B?WU1nd0x1c2VEcTZxNmozL2xpYmJEdGMxMngvbWlmR3VDODU5eTVXOEZENm5s?=
 =?utf-8?B?YU5QZjE1Zmh0eVVCL1NSTmZsOUp1U1QzZi8vak80RCtyWmpRMyswQ0lKdzNY?=
 =?utf-8?B?Z2lrYVNwQ1h0ZDZYdnFtTHJ0NTh3MjVOS3BZdzBCWXNzOTZTSDVRUEd6b1BR?=
 =?utf-8?B?S1dVb0M1ZmpiRDg2YW1QNTRtUUFDenp1K0N0VVAyZWxscGZDTkdlSnJtQUhN?=
 =?utf-8?B?ZzZDaHcwMXFwcEpqQXJhZUMycXdobWVqRXhHQnBLci9qbFJNK0xLSVFvc2pm?=
 =?utf-8?B?MUFFYStxUEJSM0tWTXVQSnZ3czQ2NWEwYWRtNlJUL1NETGJ6MkJUYmFFK2lu?=
 =?utf-8?B?S0FsVVI3MjdWWGhPSmdMZXZjbDdJc0N2OTBwM3hDTGJWU3ExKzNCL0MxWU8x?=
 =?utf-8?B?WWtDditkcnVYZFVIUlB3c3EzZEFxWlBrb2g2VE9FMVdMTGVvTFY5WUg5VEow?=
 =?utf-8?B?My9PeWJLWTJQNG52U2x2L0l6WmNmU3lyZk5LTURJK0R3a21xL1pQY0dZNi9N?=
 =?utf-8?B?RHdyTk8wNGxsVnE5OWphMFlpVEZ4c2ZCQ0l3R3BiQjRqTDljbENCbDdGNy8r?=
 =?utf-8?B?QkJDT3Y2MGhocjdVUkt5Sk1PbWNNWHRFWVJtUEsyYlBPOWcxUFhYdWhpM2xr?=
 =?utf-8?B?MENoa281alFUc2lSZzNINm9IcS9wa1FXanBMdFlaeElLZ0kwS3dDR01pUmdv?=
 =?utf-8?B?bFRCWUVRQnU1WTFKTTQ3YUkzKyt4bjFyS08vM2JTbkd1Uy9YN05QVFRITDRH?=
 =?utf-8?B?NWU5ZldpejY4ZEhsZjRzZkx3NTc2bjd1L3U3RWJZeUs0cDVKTXpKOGxja0ly?=
 =?utf-8?B?ZFA0MjUrL1FjU2RvUi9ESkVqSVE2eFFDVW8za2VnV2pnekZPQWFLQWM2Qm82?=
 =?utf-8?B?ZHRsVkdDWGRub1RaczBNdmJ3U2pQRFQ4NTZvODNwNHVxbVRFV080NTlCSVRI?=
 =?utf-8?B?SmdEN0J1OWZKNXBnNU1vWXMvR3I3cjlmQklSMWNZaHBJQUJWbitWTWQyVlFV?=
 =?utf-8?B?NGtyODc4QWxteVhRQTFKR1g4dTA1b2VwNWxJMmdTck9oeUJiNVQyb20yUEdm?=
 =?utf-8?B?eU55Rjk1YXUzdDdCMG5vS1VDd1pYT2ZwSXR4RVJBVUtTVWZzaFRsOFpsNlNJ?=
 =?utf-8?B?UjRTNjFhT0xidTNtK2UwOHhiWEk4bjJnRmtnQ0RZbkJDMTlmUFJwSkMzNE5N?=
 =?utf-8?B?V0MvRXNULzEwYitFbC9sL1daZDRnSXdpOE81MG9nT0owWHNHcVU4WnJKSEZt?=
 =?utf-8?B?aVoxTXRDT20rTnkzM2Fra3JzUU1mcGpUcnZnZEY0QnYwSk1xQWdDb1VUTW5m?=
 =?utf-8?B?RURuMlA1NFZvdzFrUm8yL2NpVFdWVkJmN3pla2Rac1RiSmFnbytyeUxDL1Mx?=
 =?utf-8?B?UVJKSktSUzF2cHBQVm40L2hpWXZkSGdWTW5lNWZlNllDb0hGY3AycHh5UlNC?=
 =?utf-8?B?SHF0TWw1U2t3cE9jNzZITFRaQUxQaXh2RkszTHRSaC9IMEcyS1BvdlFIQ1Rz?=
 =?utf-8?B?K29yeGdZMmRFdkdwcFpXTWVQOW8rbDNKTWFhUTdqaVYzZU13RjJWLzlMcWV0?=
 =?utf-8?B?M1EzVFQ3NlgrVW5VVTFwNFgyRitPUkRIVGxGeE1MK2E5ZERMVHFQOVQzdTAy?=
 =?utf-8?B?NWxzWkt5WVJBSjl6UXFVNGc1aTU4OTd4d3VkT1JXeXNHT3NBVjNmS2JqL1VL?=
 =?utf-8?B?M1JqLzNlS2tPZ3ptcEZGWmRSYUhwcGRYZEY2bmFQM1J5N042azZEbGlkbE55?=
 =?utf-8?B?dnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fbc45abe-1196-442f-e2ba-08dc13a11845
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 19:02:59.9747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hEB5LsTknklMke20lnFozvPicV8wf04cMgGGDhncQoOVZ+AMnHd1aYCPqSMajjTtiancKIYEu77uUKgFJDbN/gdeElqIqDuE4j8rdFEckzA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7181
X-OriginatorOrg: intel.com

Hi Babu,

On 1/11/2024 1:36 PM, Babu Moger wrote:

> @@ -1686,6 +1681,13 @@ static int mon_config_write(struct rdt_resource *r, char *tok, u32 evtid)
>  		return -EINVAL;
>  	}
>  
> +	/* mon_config cannot be more than the supported set of events */

copy&paste error? There is no mon_config in this function. 

(copy&paste difficulties reminds me of [1])

> +	if ((val & hw_res->mbm_cfg_mask) != val) {
> +		rdt_last_cmd_printf("Invalid event configuration: The maximum valid "
> +				    "bitmask is 0x%02x\n", hw_res->mbm_cfg_mask);

checkpatch.pl should have warned about this split of text across two lines.
Logging functions and single strings are allowed to exceed the max line length.
If you just merge the two lines then checkpatch.pl may still warn for resctrl strings
but that is because it does not recognize rdt_last_cmd_printf() as a logging function.

You can also just shorten the string so this patch passes the checkpatch.pl check.
For example,
"Invalid event configuration: maximum valid mask is 0x%02x\n"
or
"Invalid event configuration: maximum is 0x%02x\n"
or ?

Reinette

[1] https://lore.kernel.org/lkml/cc273d98-d73c-49bd-8799-b119966e226c@amd.com/