Received-SPF: pass (google.com: domain of linux-kernel+bounces-25050-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f75232ea-9e3e-1b21-4369-9a5798afbd6b@amd.com>
Date: Fri, 12 Jan 2024 15:54:06 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v4 2/2] x86/resctrl: Read supported bandwidth sources
 using CPUID command
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>, babu.moger@amd.com,
 corbet@lwn.net, fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de, dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, seanjc@google.com,
 kim.phillips@amd.com, jmattson@google.com, ilpo.jarvinen@linux.intel.com,
 jithu.joseph@intel.com, kan.liang@linux.intel.com, nikunj@amd.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com,
 rick.p.edgecombe@intel.com, rppt@kernel.org,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, peternewman@google.com,
 dhagiani@amd.com
References: <20231201005720.235639-1-babu.moger@amd.com>
 <ba1305bf2a29ce2667d01cf997718126a7ea607b.1705009003.git.babu.moger@amd.com>
 <4c5bb5ac-1e84-4021-845d-cafea5a1fbde@intel.com>
 <3bd2a660-82fd-51fe-f7cd-492908d90ca7@amd.com>
 <920e6d40-78d8-4e98-8f85-6d015681887f@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <920e6d40-78d8-4e98-8f85-6d015681887f@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2lvcHF3bHUxc054QWhycTl3SUJzTkVKVEFGaVhUTUtsN0pDNmFyQ2M2cHpx?=
 =?utf-8?B?QUUydG92M2ZaZTYvVVlGSXdUaUZTVHZmZ3pVUGpQVnhtVU1MZGxZNzBYRVBj?=
 =?utf-8?B?Z1lEaFFseG1oenRiMXg3LzRwbDIwVHJLbm1ZZnZuckxiVjRaT0JnaDhnNHYr?=
 =?utf-8?B?dVdrclY3TVhsbHdzZW5laHNWYXRoWWk0ZE8yV0FrTHg4dGJaUjFGTTlSTVJW?=
 =?utf-8?B?WXBKWGxqQThTeVc1NkJwbnA0cHlMNVp5THlaOFlZbXVCdjkwOWsxcGs5dkRt?=
 =?utf-8?B?azM4TyszODZWRkxZWUxxODdFN1ZzR21Qc091WE5VcU1rL0M5T0RIdTZ1NTFY?=
 =?utf-8?B?N1RRRVphdWF4c01LZmk3VW1GakhscTNSYzgzRFZvU0lDeUt6OGcyVmVmOC9P?=
 =?utf-8?B?R3lsbUJTK3BxMTFWQlA5Q0s1d0srZ2kxaEVHQ01ScGVLQUVRcmlPVFE1ZXJU?=
 =?utf-8?B?YW9Nais4U1N2UklyblNpMmJoUGdLMjZ5dHJMd0piQUhMMjJ4OElCMzFURkQx?=
 =?utf-8?B?N0FCcEwwZi9jaDdEekpoWjlFZGg4SWs3V0NsT0NmUzVDa0lVSGh2d3VjYk82?=
 =?utf-8?B?VGQ1NWs2QmhOZGNwNEV4Uk1HY0lHYmM1K0IrNURZc2NJMDZvdk0xcDFMUmQz?=
 =?utf-8?B?VXNudk4zdi9qeDJQSmFNZmxScGpiSUE1K0pDVnI3aE9BS21ycUNPRURWQTh0?=
 =?utf-8?B?SmlLa3NpbVFZbzA2U25wRlYzcGFJaXF1T08rOWdhK3FRUy91T05KTFMzYjlv?=
 =?utf-8?B?aEFJTVJYdjhXM0Z4SEM0WWlLcGhGN3dvTytnZVY3clJ5UVRGMTlpZ1V6VmN2?=
 =?utf-8?B?YllWZE9vTHB1cHE5MUN3TzFrenMzZmhaV2dnUmo1aVo3M0k5VXloSDdiUldN?=
 =?utf-8?B?NFIxVTJQL1F1ZDl5aHZXaC9mRGtpdmg3R1l5VmswN3dzcng2SkNQWDBBTVhi?=
 =?utf-8?B?d3p0c0dYTmwrWS9iWjFSQnMrZ2dncHRrM3N1L05jOVJ3MzM0akt6Rk1FSlNB?=
 =?utf-8?B?MGkvWHNsRVRnNFAxMHRwSlVMTFZYWXpJdklqZzIvNFhvbkorZDAvZ3FScW5B?=
 =?utf-8?B?NjdFbmo3cFh2dFNZZzNITTNVYklmSUR3Y05UeVAyNHl3YlRXd1FXOFBhdUx0?=
 =?utf-8?B?SGZUVmRPRjVVOUxWMHU1dk1TU1ZNeWxFVmxzRnJObHJ4dWIwMzdudVV1b0Q2?=
 =?utf-8?B?VUY1LzZjUEJnbU1VTGJvQjVXNjhWVUc3ZzhXQUNXRHBJRU9tU05INm80NFVO?=
 =?utf-8?B?R21HVCtnOUcrdUkvN3RJSmFsVEJHbC84dDZCY1U2Z29meWo3YmdMTDZYKzh1?=
 =?utf-8?B?Z1dxQkliWTFZVkROTVNoanpnVW1SSVBtZ0syUlBqMXBKM0FUVS9Pc095RmNJ?=
 =?utf-8?B?S0Rod2FBOVd2QnBENHFzQk5pdFB0bXhTZkpBZUwxNzNNc0tzZXNMQjVadHA4?=
 =?utf-8?B?MkE0bUJraGVVWlBYRGxrd3JuSFdZUHhMdnRWTEVhaWE4d1B3S1ZYQzRyVldo?=
 =?utf-8?B?Y3pPUDU4c0RML29SeklaU05wQWx0ZHhPNlF6V0lsQUVSNU1pd09YUVM4NFZV?=
 =?utf-8?B?eFVCd0pBb05sVDMvckR1NThVZlhBZldqblRKNG9SZ1NieiswRDBoL0MxLzVt?=
 =?utf-8?B?YytiNlBpTDhPUmFKT1VGM1laT1htSit0M3hneVNLeS9FaFpGRE9WZ09VYzlJ?=
 =?utf-8?B?bkhyU3NCeGhBTGd2Z09qMTh1MFd3WG1rL1hKblJxaGZqRDlQRDZZRTZ1VE5h?=
 =?utf-8?B?S0YxNFNadG5CQXNWY3lLTFVvV0dPNndVUHQ1VTVpMnRzU2R5U2dQUjVXZXpZ?=
 =?utf-8?B?S3A4UnQyVE81V2lMTDZpbjhHS2crRGdac1QydkNQSFhVVHlmektQMUY1NHZq?=
 =?utf-8?B?dUVoRlpyUElsbGh0MDlBR0NYSEFLU0xqbVFyRkkvQ2pVNU4yVlJQYWtQYThy?=
 =?utf-8?B?OXh4RGw2OXRPZFlEcmoxd2JITG5EazF3TUlLR1FhTGthK3RTRWNUWWVZZm90?=
 =?utf-8?B?ekFSS1BOZHd4aTJvYkxNcTNSWTI2VDU4V2Z2ZU5HbGt3RkZNNGVCVGN1emdX?=
 =?utf-8?B?RmptdjNCNDZqeEVqTkFKQUVMeCtaU3ZGc0RWNGNFdmtiVGk3a0ZzQVc2RFdF?=
 =?utf-8?Q?qhTcfpI52n2d5sEsuH3BXBjtE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af6b9153-9115-477f-a431-08dc13b90261
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 21:54:11.0945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pLbQmcaFBnyomvKk/UWi2GmzsNZglOwF5p/gHhf34gIyrFUl6ifDXVBBW66CRwIz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7003

Hi Reinette,

On 1/12/2024 3:24 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/12/2024 12:38 PM, Moger, Babu wrote:
>> Hi  Reinette,
>>
>> On 1/12/2024 1:02 PM, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> On 1/11/2024 1:36 PM, Babu Moger wrote:
>>>
>>>> @@ -1686,6 +1681,13 @@ static int mon_config_write(struct rdt_resource *r, char *tok, u32 evtid)
>>>>            return -EINVAL;
>>>>        }
>>>>    +    /* mon_config cannot be more than the supported set of events */
>>> copy&paste error? There is no mon_config in this function.
>> Yea. it should be mbm_cfg_mask.  Will fix it.
> I do not think it is correct to replace mon_config with mbm_cfg_mask. Is this comment
> not referring to the user provided value (that is checked against mbm_cfg_mask)? So
> perhaps something like:
>
> 	 /* Check value from user against supported events. */
> 	or
> 	 /* Value from user cannot be more than the supported set of events. */

This looks good. Thanks

Babu