Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2579112rdd; Fri, 12 Jan 2024 14:19:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGN5CeL9QRMPZW+Grg+UbBkGwBRsTs2m/hWFk05i0GzPEKdwKcnAjGaEBAaYo0og6liyDw8 X-Received: by 2002:a17:902:ead4:b0:1d4:1b4e:ebf5 with SMTP id p20-20020a170902ead400b001d41b4eebf5mr1693912pld.10.1705097998693; Fri, 12 Jan 2024 14:19:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705097998; cv=none; d=google.com; s=arc-20160816; b=Lf7/3sAp400zL4uSQocuwEGvJaC4xyH4Ypbl2OA9qc0t7mapuHU3mRGJs0SmUQ1CvL bgfNHUzGTIAj9YX3bvZeAaxGjBxq6qAZGlUW0MsJkAfTlY9NSa9htUru6iuDVOoX97kV 9jjQxAGlgz9P/85GXa1p5MrJzq9ZiNRN7dE9bKMFRU6wmeYAAYWrbkqd47JA6SNnFsfh 3LDTvHbHWHl/Tx7gUdN69mYjfa2gnFW/JUzkkUxpL9HuqwFNd0S3teo/Ak1EWROg0Vcu jev7C1g1lC/82rz3dJzNjqA2xupntNpdOMRpkL/kMGlnWhkV8N6ehBV7D53s81Hz55zQ 19Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-transfer-encoding:content-id:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:cc:to :from:organization:dkim-signature; bh=+ymLRP9JILIvekC5MUVhC7iuVNk/iKgeY3xqk9V2RCk=; fh=Vl7mAskWIba0cLH3EJEzNbRfp+AwUN9pzpJALlO0r/g=; b=WsUL2si54vgFSWun9wB57vLjuvB1KqEoULs/W4C97tc3U/a3nzevBTY4nY/2S4SgEq iI6Py3z2tQRvvq5PO5xY6oWFgz4Cgy8zZIDz2w26nef6keyCcOEofN+1KpTcmxAFwZUS TMBNQzEoTBELwBcnZQEPO3BUkC6UTwK0C0Nvq4lKzU9wqIlXxU4JF/vsYmmwn2OG7PMh EiOcSAGQcYidmBI5CUkFJe6O/nMEsDaKn4DVteM+MiEDqIxgRFpPcXKmNg+sTQerhYMw +OWrqAkTVTSv5EAzllKs6MwvFYyFCxAKSiRj7xE2eCKu1qp+txoD81hNDgLyW2ha5JNT lqZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eLYWGKbK; spf=pass (google.com: domain of linux-kernel+bounces-25062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id w11-20020a170902a70b00b001d50919c1acsi4010188plq.39.2024.01.12.14.19.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 14:19:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eLYWGKbK; spf=pass (google.com: domain of linux-kernel+bounces-25062-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4E48BB23C2E for ; Fri, 12 Jan 2024 22:19:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0194F17732; Fri, 12 Jan 2024 22:19:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eLYWGKbK" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A61017727 for ; Fri, 12 Jan 2024 22:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705097953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+ymLRP9JILIvekC5MUVhC7iuVNk/iKgeY3xqk9V2RCk=; b=eLYWGKbKad0kJFbalXeaKiQxkIEQ9DbfVe1Bx+MhdbVO0cyl7fnjPV38H35sJVOsj/bf0q 6834hwdH8Vf9yfUHhHEH7pO4BGpQCEvGwGIsUjnwnS8V3Ydr8/ITx2R1rzDlXtJY3P5L5m km/XRE6YmgMLlgZGUM4iKi8AuH/uwcY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-RNbbXOKHNB-wLojw4WRUbw-1; Fri, 12 Jan 2024 17:19:10 -0500 X-MC-Unique: RNbbXOKHNB-wLojw4WRUbw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3EB103C1E9D6; Fri, 12 Jan 2024 22:19:09 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 647672166B31; Fri, 12 Jan 2024 22:19:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: Alexander Viro cc: dhowells@redhat.com, Marc Dionne , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] afs: Remove afs_dynroot_d_revalidate() as it is redundant Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2387316.1705097947.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Jan 2024 22:19:07 +0000 Message-ID: <2387317.1705097947@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Remove afs_dynroot_d_revalidate() as it is redundant as all it does is return 1 and the caller assumes that if the op is not given. Suggested-by: Alexander Viro Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org cc: linux-fsdevel@vger.kernel.org --- fs/afs/dynroot.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c index 2cd40ba601f1..814c65f54d6e 100644 --- a/fs/afs/dynroot.c +++ b/fs/afs/dynroot.c @@ -258,16 +258,7 @@ const struct inode_operations afs_dynroot_inode_opera= tions =3D { .lookup =3D afs_dynroot_lookup, }; = -/* - * Dirs in the dynamic root don't need revalidation. - */ -static int afs_dynroot_d_revalidate(struct dentry *dentry, unsigned int f= lags) -{ - return 1; -} - const struct dentry_operations afs_dynroot_dentry_operations =3D { - .d_revalidate =3D afs_dynroot_d_revalidate, .d_delete =3D always_delete_dentry, .d_release =3D afs_d_release, .d_automount =3D afs_d_automount,