Received-SPF: pass (google.com: domain of linux-kernel+bounces-25158-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 12 Jan 2024 19:29:16 -0600
From: Rob Herring <robh@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Russell King <linux@armlinux.org.uk>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>, Lee Jones <lee@kernel.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	William Zhang <william.zhang@broadcom.com>,
	Pavel Machek <pavel@ucw.cz>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Kursad Oney <kursad.oney@broadcom.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-leds@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	linux-kernel@vger.kernel.org,
	Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
	Anand Gore <anand.gore@broadcom.com>,
	=?iso-8859-1?Q?Fern=E1ndez?= Rojas <noltari@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v9 1/5] dt-bindings: net: phy: Make LED
 active-low property common
Message-ID: <170510935584.3795106.4060460999461861209.robh@kernel.org>
References: <20240105142719.11042-1-ansuelsmth@gmail.com>
 <20240105142719.11042-2-ansuelsmth@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240105142719.11042-2-ansuelsmth@gmail.com>


On Fri, 05 Jan 2024 15:27:13 +0100, Christian Marangi wrote:
> Move LED active-low property to common.yaml. This property is currently
> defined multiple times by bcm LEDs. This property will now be supported
> in a generic way for PHY LEDs with the use of a generic function.
> 
> With active-low bool property not defined, active-high is always
> assumed.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> Changes v5:
> - Make active-low generic
> Changes v4:
> - Drop support for global active-low
> - Rework to polarity option (for marvell10g series support)
> Changes v3:
> - Out of RFC
> Changes v2:
> - Add this patch
> 
>  Documentation/devicetree/bindings/leds/common.yaml          | 6 ++++++
>  Documentation/devicetree/bindings/leds/leds-bcm63138.yaml   | 4 ----
>  Documentation/devicetree/bindings/leds/leds-bcm6328.yaml    | 4 ----
>  Documentation/devicetree/bindings/leds/leds-bcm6358.txt     | 2 --
>  .../devicetree/bindings/leds/leds-pwm-multicolor.yaml       | 4 ----
>  Documentation/devicetree/bindings/leds/leds-pwm.yaml        | 5 -----
>  6 files changed, 6 insertions(+), 19 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>