Received-SPF: pass (google.com: domain of linux-kernel+bounces-25177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <c65170fe-f596-4ce0-96e3-ba83f4e60eaf@infradead.org>
Date: Fri, 12 Jan 2024 18:19:55 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/4] Introduce mseal()
Content-Language: en-US
To: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org,
 jannh@google.com, sroettger@google.com, willy@infradead.org,
 gregkh@linuxfoundation.org, torvalds@linux-foundation.org,
 usama.anjum@collabora.com
Cc: jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org,
 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com,
 linux-hardening@vger.kernel.org, deraadt@openbsd.org
References: <20240111234142.2944934-1-jeffxu@chromium.org>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240111234142.2944934-1-jeffxu@chromium.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 1/11/24 15:41, jeffxu@chromium.org wrote:
> From: Jeff Xu <jeffxu@google.com>
> 
> This patchset proposes a new mseal() syscall for the Linux kernel.
> 

Jeff,
Building arm64 defconfig, on linux-next-20240112, I get:

  CC      arch/arm64/kernel/asm-offsets.s
In file included from ../include/uapi/linux/mman.h:5,
                 from ../include/linux/mm.h:33,
                 from ../include/linux/memblock.h:12,
                 from ../arch/arm64/include/asm/acpi.h:14,
                 from ../include/acpi/acpi_io.h:7,
                 from ../include/linux/acpi.h:39,
                 from ../include/acpi/apei.h:9,
                 from ../include/acpi/ghes.h:5,
                 from ../include/linux/arm_sdei.h:8,
                 from ../arch/arm64/kernel/asm-offsets.c:10:
./arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_prot_bits':
./arch/arm64/include/asm/mman.h:15:24: error: 'VM_ARM64_BTI' undeclared (first use in this function); did you mean 'ARM64_BTI'?
   15 |                 ret |= VM_ARM64_BTI;
      |                        ^~~~~~~~~~~~
      |                        ARM64_BTI
./arch/arm64/include/asm/mman.h:15:24: note: each undeclared identifier is reported only once for each function it appears in
./arch/arm64/include/asm/mman.h:18:24: error: 'VM_MTE' undeclared (first use in this function); did you mean 'VM_MAP'?
   18 |                 ret |= VM_MTE;
      |                        ^~~~~~
      |                        VM_MAP
./arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_flag_bits':
./arch/arm64/include/asm/mman.h:32:24: error: 'VM_MTE_ALLOWED' undeclared (first use in this function)
   32 |                 return VM_MTE_ALLOWED;
      |                        ^~~~~~~~~~~~~~
./arch/arm64/include/asm/mman.h: In function 'arch_validate_flags':
./arch/arm64/include/asm/mman.h:59:29: error: 'VM_MTE' undeclared (first use in this function); did you mean 'VM_MAP'?
   59 |         return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED);
      |                             ^~~~~~
      |                             VM_MAP
./arch/arm64/include/asm/mman.h:59:52: error: 'VM_MTE_ALLOWED' undeclared (first use in this function)
   59 |         return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED);
      |                                                    ^~~~~~~~~~~~~~


-- 
#Randy