Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2665574rdd; Fri, 12 Jan 2024 18:24:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQXIGmTL9BxlacW6Fa2Hz3UnUVyTmiPDtwxpQIcAWG6Kx22a3Of+5Fjs2dSGOiA73REJkO X-Received: by 2002:a05:6a20:6a1b:b0:19a:5a57:875b with SMTP id p27-20020a056a206a1b00b0019a5a57875bmr2069958pzk.54.1705112686015; Fri, 12 Jan 2024 18:24:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705112686; cv=none; d=google.com; s=arc-20160816; b=gCC4eXFYKv6uPWnj/U6nv6+yFYwRFduuSd7onOoOqZHV6sh8Cak5TXDw6y1Tk0vO3W WtXamhI37g4FA2KRw/S2WVh7LI6dzMvn4KnZhxC18ER2bsuKom6o34b59DfXSUPQBZnM 5UHDaSczOS37t4BSHTJ6UtduXGoxiTy4zuZqyPp82jJB3KTl/iwQsfkpFlqFawfT16gg Ggze+EDbZoECtYlIGahsfrJF3ehDR1NT0BDRZNuw+ufmWy2YAT1BMuPiesgfYoGMwHB0 8iyR2whLJJtACpl+IfBPQuwu7byRK71sFyzZ9asybUcA0DJ3pbfa1eIlOOeZ0bNyphL/ bWSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=hmwlXNJOoTR1k7LOFSiGQ/0vxFpvw21hP/LSOtU70eU=; fh=x1vCNI7fu71VtYB2kTA59towdEX+zFLH0suDmsSjiso=; b=MYeUwbNsA9JdsBsbws4P4t4+eX+VIgqik1U2Z/NLA3fk+vfBgXsvUzxXg7WEqvbhJ5 ZP0Or/gOHBGwMuqe7YdpI8XynJqaJxGnhvTlqnVLTSRXB3PEwS0O+NslYDsPclXL+7UB piu3sv3C20BgQ+uP0SDNkpPv1IrzjZHtxQsa8A6Pkg6sSNRB935y4+VugHyyoENV1ePn 2hAz4PUUfK0XvRyIhnvNCar30PhrHlbP5uNM5iiyq/bhkN5pD48aSk3AnhWSkXZBJVxB +qUJgdTXI+Odhg6eWPPaYqmxo4y0Fcfqu1FRKnJooY4IC/PKMg7/NAE7dD9Pkaqxf+qo Uf4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UcwrKIYT; spf=pass (google.com: domain of linux-kernel+bounces-25178-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25178-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id mm4-20020a17090b358400b0028bfce45881si6968367pjb.101.2024.01.12.18.24.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 18:24:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25178-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UcwrKIYT; spf=pass (google.com: domain of linux-kernel+bounces-25178-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25178-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7C5F02870DD for ; Sat, 13 Jan 2024 02:24:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AC28518EBF; Sat, 13 Jan 2024 02:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UcwrKIYT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE2F818C3D for ; Sat, 13 Jan 2024 02:24:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A3CCC433F1; Sat, 13 Jan 2024 02:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705112678; bh=wdMMbXoPATC3XorPezwweQTuHvplH7bKZOEhfAintxU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UcwrKIYTN0bGlBXesIx1JNRz1sbmph2PBzPh5jGEs0WixinHE7jbwrcXWU8osraxG u3aiLwcCdw28QwsnJIjLlnYgjokUS2IWo15vV2qZxwNcgJpEClJw++jBeWAe2Iw7Fm 7ewS/yMoEwDMFD0uMXXVS7kltSB75pZF77gPujQgEMhtlt95GVEHgqyXgsiNU9QyzD tv2W8cXTFm/YfZwXNelXFDJc6fznPDXA0hBP1jQMQQOy7bJjQEaUHDfdMD4SD64rdI cvv5TI8sAyyPd2PeDgW35WV2AAlKKH9yKFznaa13kFmxArERG/xKX0x2FvCP8u6W9C HD93ovU6eutMw== Message-ID: <56bdcf95-2b15-4f5b-9146-e9b37bd5b62a@kernel.org> Date: Sat, 13 Jan 2024 10:24:35 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary f2fs_put_page in f2fs_rename Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Al Viro References: <20240112171645.3929428-1-jaegeuk@kernel.org> From: Chao Yu Autocrypt: addr=chao@kernel.org; keydata= xsFNBFYs6bUBEADJuxYGZRMvAEySns+DKVtVQRKDYcHlmj+s9is35mtlhrLyjm35FWJY099R 6DL9bp8tAzLJOMBn9RuTsu7hbRDErCCTiyXWAsFsPkpt5jgTOy90OQVyTon1i/fDz4sgGOrL 1tUfcx4m5i5EICpdSuXm0dLsC5lFB2KffLNw/ZfRuS+nNlzUm9lomLXxOgAsOpuEVps7RdYy UEC81IYCAnweojFbbK8U6u4Xuu5DNlFqRFe/MBkpOwz4Nb+caCx4GICBjybG1qLl2vcGFNkh eV2i8XEdUS8CJP2rnp0D8DM0+Js+QmAi/kNHP8jzr7CdG5tje1WIVGH6ec8g8oo7kIuFFadO kwy6FSG1kRzkt4Ui2d0z3MF5SYgA1EWQfSqhCPzrTl4rJuZ72ZVirVxQi49Ei2BI+PQhraJ+ pVXd8SnIKpn8L2A/kFMCklYUaLT8kl6Bm+HhKP9xYMtDhgZatqOiyVV6HFewfb58HyUjxpza 1C35+tplQ9klsejuJA4Fw9y4lhdiFk8y2MppskaqKg950oHiqbJcDMEOfdo3NY6/tXHFaeN1 etzLc1N3Y0pG8qS/mehcIXa3Qs2fcurIuLBa+mFiFWrdfgUkvicSYqOimsrE/Ezw9hYhAHq4 KoW4LQoKyLbrdOBJFW0bn5FWBI4Jir1kIFHNgg3POH8EZZDWbQARAQABzRlDaGFvIFl1IDxj aGFvQGtlcm5lbC5vcmc+wsF3BBMBCgAhBQJWLOm1AhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4B AheAAAoJEKTPgB1/p52Gm2MP/0zawCU6QN7TZuJ8R1yfdhYr0cholc8ZuPoGim69udQ3otet wkTNARnpuK5FG5la0BxFKPlazdgAU1pt+dTzCTS6a3/+0bXYQ5DwOeBPRWeFFklm5Frmk8sy wSTxxEty0UBMjzElczkJflmCiDfQunBpWGy9szn/LZ6jjIVK/BiR7CgwXTdlvKcCEkUlI7MD vTj/4tQ3y4Vdx+p7P53xlacTzZkP+b6D2VsjK+PsnsPpKwaiPzVFMUwjt1MYtOupK4bbDRB4 NIFSNu2HSA0cjsu8zUiiAvhd/6gajlZmV/GLJKQZp0MjHOvFS5Eb1DaRvoCf27L+BXBMH4Jq 2XIyBMm+xqDJd7BRysnImal5NnQlKnDeO4PrpFq4JM0P33EgnSOrJuAb8vm5ORS9xgRlshXh 2C0MeyQFxL6l+zolEFe2Nt2vrTFgjYLsm2vPL+oIPlE3j7ToRlmm7DcAqsa9oYMlVTTnPRL9 afNyrsocG0fvOYFCGvjfog/V56WFXvy9uH8mH5aNOg5xHB0//oG9vUyY0Rv/PrtW897ySEPh 3jFP/EDI0kKjFW3P6CfYG/X1eaw6NDfgpzjkCf2/bYm/SZLV8dL2vuLBVV+hrT1yM1FcZotP WwLEzdgdQffuQwJHovz72oH8HVHD2yvJf2hr6lH58VK4/zB/iVN4vzveOdzlzsFNBFYs6bUB EADZTCTgMHkb6bz4bt6kkvj7+LbftBt5boKACy2mdrFFMocT5zM6YuJ7Ntjazk5z3F3IzfYu 94a41kLY1H/G0Y112wggrxem6uAtUiekR9KnphsWI9lRI4a2VbbWUNRhCQA8ag7Xwe5cDIV5 qb7r7M+TaKaESRx/Y91bm0pL/MKfs/BMkYsr3wA1OX0JuEpV2YHDW8m2nFEGP6CxNma7vzw+ JRxNuyJcNi+VrLOXnLR6hZXjShrmU88XIU2yVXVbxtKWq8vlOSRuXkLh9NQOZn7mrR+Fb1EY DY1ydoR/7FKzRNt6ejI8opHN5KKFUD913kuT90wySWM7Qx9icc1rmjuUDz3VO+rl2sdd0/1h Q2VoXbPFxi6c9rLiDf8t7aHbYccst/7ouiHR/vXQty6vSUV9iEbzm+SDpHzdA8h3iPJs6rAb 0NpGhy3XKY7HOSNIeHvIbDHTUZrewD2A6ARw1VYg1vhJbqUE4qKoUL1wLmxHrk+zHUEyLHUq aDpDMZArdNKpT6Nh9ySUFzlWkHUsj7uUNxU3A6GTum2aU3Gh0CD1p8+FYlG1dGhO5boTIUsR 6ho73ZNk1bwUj/wOcqWu+ZdnQa3zbfvMI9o/kFlOu8iTGlD8sNjJK+Y/fPK3znFqoqqKmSFZ aiRALjAZH6ufspvYAJEJE9eZSX7Rtdyt30MMHQARAQABwsFfBBgBCgAJBQJWLOm1AhsMAAoJ EKTPgB1/p52GPpoP/2LOn/5KSkGHGmdjzRoQHBTdm2YV1YwgADg52/mU68Wo6viStZqcVEnX 3ALsWeETod3qeBCJ/TR2C6hnsqsALkXMFFJTX8aRi/E4WgBqNvNgAkWGsg5XKB3JUoJmQLqe CGVCT1OSQA/gTEfB8tTZAGFwlw1D3W988CiGnnRb2EEqU4pEuBoQir0sixJzFWybf0jjEi7P pODxw/NCyIf9GNRNYByUTVKnC7C51a3b1gNs10aTUmRfQuu+iM5yST5qMp4ls/yYl5ybr7N1 zSq9iuL13I35csBOn13U5NE67zEb/pCFspZ6ByU4zxChSOTdIJSm4/DEKlqQZhh3FnVHh2Ld eG/Wbc1KVLZYX1NNbXTz7gBlVYe8aGpPNffsEsfNCGsFDGth0tC32zLT+5/r43awmxSJfx2P 5aGkpdszvvyZ4hvcDfZ7U5CBItP/tWXYV0DDl8rCFmhZZw570vlx8AnTiC1v1FzrNfvtuxm3 92Qh98hAj3cMFKtEVbLKJvrc2AO+mQlS7zl1qWblEhpZnXi05S1AoT0gDW2lwe54VfT3ySon 8Klpbp5W4eEoY21tLwuNzgUMxmycfM4GaJWNCncKuMT4qGVQO9SPFs0vgUrdBUC5Pn5ZJ46X mZA0DUz0S8BJtYGI0DUC/jAKhIgy1vAx39y7sAshwu2VILa71tXJ In-Reply-To: <20240112171645.3929428-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/1/13 1:16, Jaegeuk Kim wrote: > [1] changed the below condition, which made f2fs_put_page() voided. > This patch reapplies the AL's resolution in -next from [2]. > > - if (S_ISDIR(old_inode->i_mode)) { > + if (old_is_dir && old_dir != new_dir) { > old_dir_entry = f2fs_parent_dir(old_inode, &old_dir_page); > if (!old_dir_entry) { > if (IS_ERR(old_dir_page)) > > [1] 7deee77b993a ("f2fs: Avoid reading renamed directory if parent does not change") > [2] https://lore.kernel.org/all/20231220013402.GW1674809@ZenIV/ > > Suggested-by: Al Viro > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,